Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandstorm should do sandstorm-www check, even if hostname matches WILDCARD_HOST pattern #309

Open
paulproteus opened this issue Mar 28, 2015 · 2 comments
Labels
install-config Installation/configuration issues

Comments

@paulproteus
Copy link
Collaborator

In a conversation with Duane Johnson, we discovered that with current versions of Sandstorm, using WILDCARD_HOST=*.example.com means that if you have a blog at blog.example.com, Sandstorm can't tell if blog.example.com is a session subdomain, or if it's a personal publishing domain. It guesses it's a session subdomain, and then refuses to serve the app instance's static content on that domain.

One thing we could do is change the default WILDCARD_HOST to avoid this problem. That wouldn't help existing users, though.

A different thing we can do is to fix shell/server/pre-meteor.js so that if the inbound request doesn't match an active session, then we try the DNS lookup of sandstorm-www per https://github.com/sandstorm-io/sandstorm/wiki/Publishing-to-the-user%27s-domain

@canadaduane
Copy link
Contributor

Thanks for your help on this! I'm pretty excited to have a sandstorm blog working :)

@paulproteus paulproteus changed the title Sandstorm should Sandstorm should do sandstorm-www check, even if hostname matches WILDCARD_HOST pattern Mar 30, 2015
@paulproteus
Copy link
Collaborator Author

@canadaduane , thanks for running into this bug and for saying so. Because you spoke up on the mailing list a week ago, you brought this to our attention; without that, it might have taken months longer to discover this.

I'm very happy the Sandstorm software is able to provide you with a blog! I hope you'll continue to be vocal in the community. (-:

@ocdtrekkie ocdtrekkie added the install-config Installation/configuration issues label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
install-config Installation/configuration issues
Projects
None yet
Development

No branches or pull requests

3 participants