Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When restoring a backup, if app is not installed, help the user install it #1496

Open
paulproteus opened this issue Feb 10, 2016 · 1 comment

Comments

@paulproteus
Copy link
Collaborator

Steps to reproduce:

Expected behavior:

  • Show the user something actionable, such as "This app isn't installed yet. Go check if it is on the app market and install it if possible."
  • Or, check the "app index" (JSON cached from the app market) to see if we can show the app name and then if so provide an install link

Actual behavior:

  • Confusing error message: “Upload failed: App id for uploaded grain not installed [500]”

Thanks to @html5cat for reporting the issue to me elsewhere.

@ocdtrekkie
Copy link
Collaborator

Definitely this. And if you aren't sure which app the grain was from to begin with, currently there's no way to find out! The biggest question is that the grains are package version dependent, I believe... does the app market store the older versions of package to offer up? If someone's restoring a backup, it may be because their upgraded grain was problematic, so assuming the newest version is acceptable may not be a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants