Skip to content

Commit f5b8d3e

Browse files
authored
[py] Adjust xfail markers for window size/position tests (SeleniumHQ#15638)
1 parent 8c9aa17 commit f5b8d3e

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

py/test/selenium/webdriver/common/api_example_tests.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,8 @@ def test_is_element_displayed(driver, pages):
239239
assert not not_visible
240240

241241

242-
@pytest.mark.xfail_chrome
242+
@pytest.mark.xfail_edge
243+
@pytest.mark.xfail_firefox(reason="https://github.com/mozilla/geckodriver/issues/2224")
243244
@pytest.mark.xfail_safari
244245
def test_move_window_position(driver, pages):
245246
pages.load("blank.html")

py/test/selenium/webdriver/common/window_tests.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ def test_should_get_the_size_of_the_current_window(driver):
4545
assert size.get("height") > 0
4646

4747

48+
@pytest.mark.xfail_edge
4849
def test_should_set_the_size_of_the_current_window(driver):
4950
size = driver.get_window_size()
5051

@@ -57,13 +58,15 @@ def test_should_set_the_size_of_the_current_window(driver):
5758
assert new_size.get("height") == target_height
5859

5960

60-
@pytest.mark.xfail_chrome
6161
def test_should_get_the_position_of_the_current_window(driver):
6262
position = driver.get_window_position()
6363
assert position.get("x") >= 0
6464
assert position.get("y") >= 0
6565

6666

67+
@pytest.mark.xfail_chrome
68+
@pytest.mark.xfail_edge
69+
@pytest.mark.xfail_firefox(reason="https://github.com/mozilla/geckodriver/issues/2224")
6770
def test_should_set_the_position_of_the_current_window(driver):
6871
position = driver.get_window_position()
6972

@@ -81,7 +84,6 @@ def test_should_set_the_position_of_the_current_window(driver):
8184

8285

8386
@pytest.mark.xfail_safari(raises=WebDriverException, reason="Get Window Rect command not implemented")
84-
@pytest.mark.xfail_chrome
8587
def test_should_get_the_rect_of_the_current_window(driver):
8688
rect = driver.get_window_rect()
8789
assert rect.get("x") >= 0
@@ -90,6 +92,8 @@ def test_should_get_the_rect_of_the_current_window(driver):
9092
assert rect.get("height") >= 0
9193

9294

95+
@pytest.mark.xfail_edge
96+
@pytest.mark.xfail_firefox(reason="https://github.com/mozilla/geckodriver/issues/2224")
9397
@pytest.mark.xfail_safari(raises=WebDriverException, reason="Get Window Rect command not implemented")
9498
def test_should_set_the_rect_of_the_current_window(driver):
9599
rect = driver.get_window_rect()

0 commit comments

Comments
 (0)