File Manager Singleton #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…variables in MainWindow for improved clarity
…f MainWindow for improved modularity
…f MainWindow for improved modularity
…ndling and modularity
…cluding new, save, and open functionalities
…r improved readability + conged FileManager to instance
…ager declaration in CodeEditor
…unused getFileExtension method
… formatting in MainWindow
…s and update related usages in MainWindow
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the refactoring effort mentioned in issue #10. In this PR, I created a file management system to separate the logic from the mainWindow. The FileManager is a singleton instance that can be reused on multiple components.