Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two small issues #26

Closed
rlancaste opened this issue Aug 10, 2024 · 6 comments
Closed

Two small issues #26

rlancaste opened this issue Aug 10, 2024 · 6 comments

Comments

@rlancaste
Copy link
Contributor

I have been using this driver on my Raspberry Pi for the last couple of years. Every time I had installed it, the run on startup feature has not worked without doing some modifications. As mentioned in another Issue, I had to edit the run.sh file. The line that said:

~/.nvm/nvm.sh

I had to change that line to this:

~/.config/nvm/nvm.sh

After doing that, it started on startup with no problem.

However, the other day I updated the raspberry pi and ran the script again to set this up again. I ran into a more significant issue. During the script, it had a number of errors. A quick google search led me to this person who had the same issue: https://stackoverflow.com/questions/74715990/node-gyp-err-invalid-mode-ru-while-trying-to-load-binding-gyp
I had to edit the file ~/.config/nvm/versions/node/v12.19.0/lib/node_modules/npm/node_modules/node-gyp/gyp/pylib/gyp/input.py
as stated in the post to change rU to r in LoadOneBuildFile()
Then I ran the script again and it worked.

This is already a really great repository, If these two problems could be fixed, I think it would be much more user friendly.

@samyk
Copy link
Owner

samyk commented Aug 10, 2024

Happy to accept a pr

@rlancaste
Copy link
Contributor Author

So I could send a pr that addresses the first issue, but I am not sure about how to address the second one. The issue is in a node module used by this repo, not in this repo specifically

@rlancaste
Copy link
Contributor Author

Maybe using a different node version ?

@rlancaste
Copy link
Contributor Author

Looks like they did fix it: nodejs/gyp-next#83

@rlancaste
Copy link
Contributor Author

Ok I think this should resolve both issues: #27

@samyk
Copy link
Owner

samyk commented Aug 12, 2024

Awesome, thank you for the improvements! Merged.

@samyk samyk closed this as completed Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants