Add missing py.typed file and add explicit reexports
#8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @RobertCraigie! I clearly missed the “as” pattern… going to go read up on that. I haven’t worked much with MyPy and Pyright, so massively appreciate the input. |
|
No worries! I'm more than happy to spread the word about the benefits of static type checking and any tidbits I've come across :) |
|
I have just released version a4 with these changes. Also fyi, I'm hoping to rename the pypi package to just "nodejs" before we go stable, see here: #9 |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6
Context: #6 (comment)