From 1929072d38a41b4420bd1cb936692c4fc6848e97 Mon Sep 17 00:00:00 2001 From: Jeremy Friesen Date: Thu, 21 Dec 2023 17:19:25 -0500 Subject: [PATCH] =?UTF-8?q?=F0=9F=A7=B9=20Rearrange=20order=20of=20filter?= =?UTF-8?q?=20chain?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is not tested in the UI, but the `show_works_or_works_that_contain_files` remains after the troublesome advanced query filters. --- spec/search_builders/adv_search_builder_spec.rb | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/spec/search_builders/adv_search_builder_spec.rb b/spec/search_builders/adv_search_builder_spec.rb index f2816997e..f7352edec 100644 --- a/spec/search_builders/adv_search_builder_spec.rb +++ b/spec/search_builders/adv_search_builder_spec.rb @@ -25,8 +25,12 @@ # # When we had those duplicates, the :add_advanced_parse_q_to_solr obliterated the join logic # for files. + # + # Is the order immutable? No. But it does highlight that you must consider what the changes + # might mean and double check that join logic on files. %i[ default_solr_parameters + add_search_field_default_parameters add_query_to_solr add_facet_fq_to_solr add_facetting_to_solr @@ -35,12 +39,14 @@ add_sorting_to_solr add_group_config_to_solr add_facet_paging_to_solr + add_adv_search_clauses + add_additional_filters add_range_limit_params - add_advanced_parse_q_to_solr - add_advanced_search_to_solr add_access_controls_to_solr_params filter_models only_active_works + add_advanced_parse_q_to_solr + add_advanced_search_to_solr add_access_controls_to_solr_params show_works_or_works_that_contain_files show_only_active_records