Enable -Wall -Werror

Author: samsta

CMakeLists.txt

@@ -21,6 +21,8 @@ add_definitions(
    -std=c++11
    -DGLFW_INCLUDE_GLCOREARB=1
    -DGLFW_INCLUDE_GLEXT=1
+   -Werror
+   -Wall
    )
 
 if("${CMAKE_SYSTEM_NAME}" STREQUAL "Darwin")

flogl/CMakeLists.txt

@@ -23,10 +23,6 @@ set(ALL_LIBS
    ${GLFW_LIBRARY}
 )
 
-add_definitions(
-   -std=c++11
-   -D_CRT_SECURE_NO_WARNINGS
-   )
 
 add_executable(toblob util/toblob.cpp)
 
@@ -37,7 +33,7 @@ set(FASTLED_SOURCES
    "${FastLED_SRC}/lib8tion.cpp"
    )
 set_source_files_properties(${FASTLED_SOURCES}
-   PROPERTIES COMPILE_FLAGS "-include platform.h"
+   PROPERTIES COMPILE_FLAGS "-include platform.h -Wno-mismatched-tags -Wno-unused-private-field"
    )
 source_group(FastLED FILES ${FASTLED_SOURCES})
 
@@ -46,7 +42,7 @@ set(FLOGL_SOURCES
    shader.cpp
    texture.cpp
    Window.cpp
-   "${CMAKE_CURRENT_BINARY_DIR}/LedTexture.cpp"
+   "${CMAKE_CURRENT_BINARY_DIR}/LedTexture.hpp"
    )
 
 # Disable annoying #pragma messages.
@@ -60,7 +56,7 @@ add_library(flogl
    )
 
 add_custom_command(
-   OUTPUT LedTexture.cpp
+   OUTPUT LedTexture.hpp
    COMMAND toblob  "${CMAKE_CURRENT_SOURCE_DIR}/LED.DDS" "${CMAKE_CURRENT_BINARY_DIR}" LedTexture
    DEPENDS toblob LED.DDS
 )

flogl/Window.hpp

@@ -4,7 +4,7 @@
 #include <glm/glm.hpp>
 #include "Config.hpp"
 
-class GLFWwindow;
+struct GLFWwindow;
 
 namespace flogl {
 

flogl/cmake/Modules/FindFastLED.cmake

@@ -9,4 +9,4 @@ find_package_handle_standard_args(FastLED DEFAULT_MSG FastLED_BASE)
 set(FastLED_SRC     "${FASTLED_DIR}/src")
 set(FastLED_INCLUDE "${FASTLED_DIR}/src")
 
-include_directories("${FastLED_INCLUDE}")
+include_directories(SYSTEM "${FastLED_INCLUDE}")

flogl/flogl.cpp

@@ -42,7 +42,7 @@ const std::string FRAGMENT_SHADER =
 ;
 }
 
-#include "LedTexture.cpp"
+#include "LedTexture.hpp"
 
 class Flogl::Impl
 {

flogl/texture.cpp

@@ -60,12 +60,10 @@ GLuint loadDDS(const unsigned char* binary_image, unsigned size)
 
    unsigned int height      = hdr.dwHeight;
    unsigned int width       = hdr.dwWidth;
-   unsigned int linearSize  = hdr.dwPitchOrLinearSize;
    unsigned int mipMapCount = hdr.dwMipMapCount;
    unsigned int fourCC      = hdr.ddspf.dwFourCC;
 
    const unsigned char *buffer = binary_image + HEADER_SIZE;
-   unsigned int components  = (fourCC == FOURCC_DXT1) ? 3 : 4; 
    unsigned int format;
    switch(fourCC) 
    { 

flogl/util/toblob.cpp

@@ -12,7 +12,7 @@ int main(int argc, char* argv[])
       std::cerr << "usage: " << argv[0] << " <in_file> <out_dir> <blob_name>" << std::endl;
       std::cerr << std::endl;
       std::cerr << "convert <in_file> to source code representing a blob name blobs::<blob_name>" << std::endl;
-      std::cerr << "and write the result to <out_dir>/<blob_name>.cpp" << std::endl;
+      std::cerr << "and write the result to <out_dir>/<blob_name>.hpp" << std::endl;
       return 1;
    }
    const char* in_file_name = argv[1];
@@ -26,7 +26,7 @@ int main(int argc, char* argv[])
       return 1;
    }
 
-   std::string out_file_name = std::string(out_dir_name) + "/" + blob_name + ".cpp";
+   std::string out_file_name = std::string(out_dir_name) + "/" + blob_name + ".hpp";
    std::ofstream out_file(out_file_name.c_str());
    if (not out_file.good())
    {