feat: read user and password from environment variables #98
Conversation
added import of environment variables BLAZECTL_USER and BLAZECTL_USER to avoid visible credentials in process list
|
Looks good, can you please update the usage output in the README? |
added list of used environment variables
Done, I thought that was autogenerated. |
alexanderkiel
left a comment
alexanderkiel
left a comment
There was a problem hiding this comment.
Using Viper is a mid term goal. Especially for config files. But reading the env vars by hand is ok for now.
README.md
Outdated
| --user string user information for basic authentication | ||
| -v, --version version for blazectl | ||
| Environment variables: |
There was a problem hiding this comment.
Please put that Environment variables section after Usage as h3.
For the usage output: That should be the actual output from calling blazectl without any args. Please build and run the new version.
There was a problem hiding this comment.
I've updated the usage output in the README.md
There was a problem hiding this comment.
Please rebase your branch on top of the current main. Your branch should only contain one commit. You have merged the main in your branch.
2 participants
added import of environment variables BLAZECTL_USER and BLAZECTL_USER to avoid visible credentials in process list