From 5dc9d5b1e102b6ce9bfe3dfcb762582a86243cfe Mon Sep 17 00:00:00 2001 From: Ali Ghassemi Date: Tue, 2 Apr 2019 07:52:12 -0700 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20=20amp-ima-video:=20Allow=20othe?= =?UTF-8?q?r=20kinds=20of=20`track`=20than=20just=20`subtitle`=20and=20als?= =?UTF-8?q?o=20support=20`crossorigin`=20(#21591)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * amp-ima-video: Allow track and crossorigin * Update validator-amp-ima-video.protoascii * review changes * fix test * remove A4A, actions from track rule * Update imaVideo.js * review comments * Update imaVideo.js * fix types --- ads/google/imaVideo.js | 3 +++ examples/ima-video.amp.html | 20 ++++++++++++++++++- .../0.1/test/validator-amp-ima-video.html | 14 +++++++++++++ .../0.1/test/validator-amp-ima-video.out | 16 ++++++++++++++- extensions/amp-ima-video/amp-ima-video.md | 6 +++++- validator/validator-main.protoascii | 13 ++++++++++-- 6 files changed, 67 insertions(+), 5 deletions(-) diff --git a/ads/google/imaVideo.js b/ads/google/imaVideo.js index c9835dd692be..2ec9bddd7459 100644 --- a/ads/google/imaVideo.js +++ b/ads/google/imaVideo.js @@ -425,6 +425,9 @@ export function imaVideo(global, data) { 'background-color': 'black', }); videoPlayer.setAttribute('poster', data.poster); + if (data['crossorigin'] != null) { + videoPlayer.setAttribute('crossorigin', data['crossorigin']); + } videoPlayer.setAttribute('playsinline', true); videoPlayer.setAttribute( 'controlsList', 'nodownload nofullscreen noremoteplayback'); diff --git a/examples/ima-video.amp.html b/examples/ima-video.amp.html index c8001dc41dc8..0a3b26750080 100644 --- a/examples/ima-video.amp.html +++ b/examples/ima-video.amp.html @@ -29,6 +29,7 @@ +

amp-ima-video

Resources