Skip to content

Conversation

@jhoglin
Copy link

@jhoglin jhoglin commented Sep 2, 2016

@LongLiveCHIEF
Copy link

LongLiveCHIEF commented Oct 30, 2016

The only thing this is missing is a VOLUME definition in the Dockerfile for the output dir of the cron job. Anything that make a container non-idempotent should ideally have a volume assignments.

Aside from that, I like this one! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants