From 9c7e016c8dcab5297903337aa87a71ad5dfa853e Mon Sep 17 00:00:00 2001
From: Joerg Stoever <joerg.stoever@gmail.com>
Date: Fri, 30 Aug 2024 18:52:12 +0900
Subject: [PATCH] healthcheck: Use IPv4 loopback address instead of localhost

Access to health check resources such as /-/liveness
is restricted to IPs specified in gitlab.monitoring.ip_whitelist
(`GITLAB_MONITORING_IP_WHITELIST`).
The name `localhost` is solved to IPv6 loopback address (::1)
that is not listed in the whitelist by default.

Possible alternate designs:
- Add IPv6 loopback to whitelist
- Disable IPv6 for gitlab container by specifying `net.ipv6.conf.all.disable_ipv6=1`
  in docker-compose.yml for example
  See https://github.com/sameersbn/docker-gitlab/issues/2766#issuecomment-2098030791
---
 assets/runtime/functions | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/assets/runtime/functions b/assets/runtime/functions
index a9a778c53..1262c979e 100644
--- a/assets/runtime/functions
+++ b/assets/runtime/functions
@@ -1860,7 +1860,7 @@ generate_healthcheck_script() {
   fi
 cat > /usr/local/sbin/healthcheck <<EOF
 #!/bin/bash
-url=${HEALTHCHECK_PROTOCOL}://localhost${GITLAB_RELATIVE_URL_ROOT}/-/liveness
+url=${HEALTHCHECK_PROTOCOL}://127.0.0.1${GITLAB_RELATIVE_URL_ROOT}/-/liveness
 options=( '--insecure' '--location' '--silent' )
 curl "\${options[@]}" \$url
 [[ "\$(curl \${options[@]} -o /dev/null -I -w '%{http_code}' \$url)" == "200" ]]