Tags as Map

Author: zzzLobster

builder.go

@@ -45,7 +45,7 @@ func new() OopsErrorBuilder {
 
 		// context
 		domain:  "",
-		tags:    []string{},
+		tags:    make(map[string]struct{}),
 		context: map[string]any{},
 
 		trace: "",
@@ -240,7 +240,9 @@ func (o OopsErrorBuilder) In(domain string) OopsErrorBuilder {
 // Tags adds multiple tags, describing the feature returning an error.
 func (o OopsErrorBuilder) Tags(tags ...string) OopsErrorBuilder {
 	o2 := o.copy()
-	o2.tags = append(o2.tags, tags...)
+	for _, tag := range tags {
+		o2.tags[tag] = struct{}{}
+	}
 	return o2
 }
 

error.go

@@ -30,7 +30,7 @@ type OopsError struct {
 
 	// context
 	domain  string
-	tags    []string
+	tags    map[string]struct{}
 	context map[string]any
 
 	trace string
@@ -118,18 +118,22 @@ func (o OopsError) Domain() string {
 
 // Tags returns the tags of the error.
 func (o OopsError) Tags() []string {
-	tags := []string{}
+	tags := make(map[string]struct{})
 
 	recursive(o, func(e OopsError) {
-		tags = append(tags, e.tags...)
+		for tag := range e.tags {
+			tags[tag] = struct{}{}
+		}
 	})
 
-	return lo.Uniq(tags)
+	return lo.MapToSlice(tags, func(key string, _ struct{}) string {
+		return key
+	})
 }
 
 // HasTag returns true if the tags of the error contain provided value.
 func (o OopsError) HasTag(tag string) bool {
-	if lo.Contains(o.tags, tag) {
+	if _, ok := o.tags[tag]; ok {
 		return true
 	}
 

oops_test.go

@@ -172,10 +172,10 @@ func TestOopsTags(t *testing.T) {
 	is.Len(join.Unwrap(), 2)
 	is.Equal(assert.AnError, join.Unwrap()[0].(OopsError).err)
 	is.Equal(assert.AnError, join.Unwrap()[1].(OopsError).err)
-	is.Equal([]string{"iam", "authz", "iam"}, err.(OopsError).tags) // not deduplicated
-	is.Equal([]string{"iam", "internal"}, join.Unwrap()[0].(OopsError).tags)
-	is.Equal([]string{"not-found"}, join.Unwrap()[1].(OopsError).tags)
-	is.Equal([]string{"iam", "authz", "internal"}, err.(OopsError).Tags()) // deduplicated and recursive
+	is.ElementsMatch([]string{"iam", "authz"}, lo.Keys(err.(OopsError).tags))
+	is.ElementsMatch([]string{"iam", "internal"}, lo.Keys(join.Unwrap()[0].(OopsError).tags))
+	is.ElementsMatch([]string{"not-found"}, lo.Keys(join.Unwrap()[1].(OopsError).tags))
+	is.ElementsMatch([]string{"iam", "authz", "internal"}, err.(OopsError).Tags()) // recursive
 }
 
 func TestOopsHasTag(t *testing.T) {
@@ -660,7 +660,11 @@ func TestOopsLogValuer(t *testing.T) {
 	for i := range got {
 		is.Equal(expectedAttrs[i].Key, got[i].Key)
 		is.Equal(expectedAttrs[i].Value.Kind(), got[i].Value.Kind())
-		is.EqualValues(expectedAttrs[i].Value.Any(), got[i].Value.Any())
+		if "tags" == got[i].Key {
+			is.ElementsMatch(expectedAttrs[i].Value.Any(), got[i].Value.Any())
+		} else {
+			is.EqualValues(expectedAttrs[i].Value.Any(), got[i].Value.Any())
+		}
 	}
 }