integration tests: add a test to verify common config network external

Add a test case that sets up a share referencing a common config that
sets network/publish=external. This performs the standard checks
for share (regression) as well as adding a check that the service is
created with a type=LoadBalancer.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

Author: phlogistonjohn

tests/files/commonconfig1.yaml

@@ -0,0 +1,8 @@
+---
+apiVersion: samba-operator.samba.org/v1alpha1
+kind: SmbCommonConfig
+metadata:
+  name: commonext1
+spec:
+  network:
+    publish: external

tests/files/smbshare4.yaml

@@ -0,0 +1,19 @@
+---
+apiVersion: samba-operator.samba.org/v1alpha1
+kind: SmbShare
+metadata:
+  name: tshare4
+spec:
+  shareName: "Since When"
+  readOnly: false
+  browseable: false
+  securityConfig: sharesec1
+  commonConfig: commonext1
+  storage:
+    pvc:
+      spec:
+        accessModes:
+          - ReadWriteOnce
+        resources:
+          requests:
+            storage: 1Gi

tests/integration/smb_share_test.go

@@ -9,6 +9,7 @@ import (
 	"time"
 
 	"github.com/stretchr/testify/suite"
+	corev1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 	"k8s.io/apimachinery/pkg/types"
@@ -200,6 +201,30 @@ func (s *SmbShareWithDNSSuite) TestPodForDNSContainers() {
 	s.Require().Contains(names, "svc-watch")
 }
 
+type SmbShareWithExternalNetSuite struct {
+	SmbShareSuite
+}
+
+func (s *SmbShareWithExternalNetSuite) TestServiceIsLoadBalancer() {
+	lbl := fmt.Sprintf("samba-operator.samba.org/service=%s", s.smbShareResource.Name)
+	l, err := s.tc.Clientset().CoreV1().Services(testNamespace).List(
+		context.TODO(),
+		metav1.ListOptions{
+			LabelSelector: lbl,
+		},
+	)
+	s.Require().NoError(err)
+	s.Require().Len(l.Items, 1)
+	// our test environment does not require the k8s cluster to actually
+	// support an external load balancer. All this test can do is check
+	// IF LoadBalanacer was set.
+	svc := l.Items[0]
+	s.Require().Equal(
+		corev1.ServiceTypeLoadBalancer,
+		svc.Spec.Type,
+	)
+}
+
 func allSmbShareSuites() map[string]suite.TestingSuite {
 	m := map[string]suite.TestingSuite{}
 	m["users1"] = &SmbShareSuite{
@@ -274,5 +299,32 @@ func allSmbShareSuites() map[string]suite.TestingSuite {
 		}},
 	}
 
+	m["smbSharesExternal"] = &SmbShareWithExternalNetSuite{SmbShareSuite{
+		fileSources: []kube.FileSource{
+			{
+				Path:      path.Join(testFilesDir, "userssecret1.yaml"),
+				Namespace: testNamespace,
+			},
+			{
+				Path:      path.Join(testFilesDir, "commonconfig1.yaml"),
+				Namespace: testNamespace,
+			},
+			{
+				Path:      path.Join(testFilesDir, "smbsecurityconfig1.yaml"),
+				Namespace: testNamespace,
+			},
+			{
+				Path:      path.Join(testFilesDir, "smbshare4.yaml"),
+				Namespace: testNamespace,
+			},
+		},
+		smbShareResource: types.NamespacedName{testNamespace, "tshare4"},
+		shareName:        "Since When",
+		testAuths: []smbclient.Auth{{
+			Username: "sambauser",
+			Password: "1nsecurely",
+		}},
+	}}
+
 	return m
 }