resources: determine Service type from common config

Use the common config's network publish field to determine what type
of Service we will create - either the default of ClusterIP or
LoadBalancer if this share is to be published externally.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

Author: phlogistonjohn

internal/resources/planner.go

@@ -325,5 +325,11 @@ func (sp *sharePlanner) dnsRegisterArgs() []string {
 	}
 	args = append(args, sp.serviceWatchJSONPath())
 	return args
+}
 
+func (sp *sharePlanner) serviceType() string {
+	if sp.CommonConfig != nil && sp.CommonConfig.Spec.Network.Publish == "external" {
+		return "LoadBalancer"
+	}
+	return "ClusterIP"
 }

internal/resources/services.go

@@ -32,7 +32,7 @@ func newServiceForSmb(planner *sharePlanner, ns string) *corev1.Service {
 			Labels:    labels,
 		},
 		Spec: corev1.ServiceSpec{
-			Type: "ClusterIP",
+			Type: toServiceType(planner.serviceType()),
 			Ports: []corev1.ServicePort{{
 				Name:     "smb",
 				Protocol: corev1.ProtocolTCP,
@@ -44,3 +44,15 @@ func newServiceForSmb(planner *sharePlanner, ns string) *corev1.Service {
 		},
 	}
 }
+
+func toServiceType(s string) corev1.ServiceType {
+	svcType := corev1.ServiceType(s)
+	switch svcType {
+	case corev1.ServiceTypeClusterIP:
+	case corev1.ServiceTypeNodePort:
+	case corev1.ServiceTypeLoadBalancer:
+	default:
+		panic("invalid value for service type")
+	}
+	return svcType
+}