Skip to content

Commit 15822a3

Browse files
Upgrade websocket to 0.26
This update contains a security fix (RUSTSEC-2022-0035).
1 parent f50ea8d commit 15822a3

File tree

4 files changed

+7
-15
lines changed

4 files changed

+7
-15
lines changed

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ rmpv = { version = "0.4", features = ["with-serde"] }
3030
serde = { version = "1", features = ["derive"] }
3131
tokio-core = "0.1"
3232
tokio-timer = "0.1"
33-
websocket = { version = "0.21", default-features = false, features = ["async", "async-ssl"] }
33+
websocket = { version = "0.26", default-features = false, features = ["async", "async-ssl"] }
3434
xsalsa20poly1305 = "0.8"
3535

3636
[dev-dependencies]

examples/chat/main.rs

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -279,14 +279,9 @@ fn main() {
279279
let salty_arc = Arc::new(RwLock::new(salty));
280280

281281
// Connect to server
282-
let (connect_future, event_channel) = saltyrtc_client::connect(
283-
"localhost",
284-
8765,
285-
Some(tls_connector),
286-
&core.handle(),
287-
salty_arc.clone(),
288-
)
289-
.unwrap();
282+
let (connect_future, event_channel) =
283+
saltyrtc_client::connect("localhost", 8765, Some(tls_connector), salty_arc.clone())
284+
.unwrap();
290285

291286
// Do handshake
292287
let event_tx = event_channel.clone_tx();

src/lib.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,8 @@ use futures::sync::oneshot;
7676
use futures::{stream, Future, Sink, Stream};
7777
use native_tls::TlsConnector;
7878
use rmpv::Value;
79-
use tokio_core::net::TcpStream;
80-
use tokio_core::reactor::Handle;
8179
use tokio_timer::Timer;
80+
use websocket::r#async::TcpStream;
8281
use websocket::client::builder::Url;
8382
use websocket::client::r#async::{Client, TlsStream};
8483
use websocket::client::ClientBuilder;
@@ -416,7 +415,6 @@ pub fn connect(
416415
host: &str,
417416
port: u16,
418417
tls_config: Option<TlsConnector>,
419-
handle: &Handle,
420418
salty: Arc<RwLock<SaltyClient>>,
421419
) -> SaltyResult<(
422420
impl Future<Item = WsClient, Error = SaltyError>,
@@ -437,7 +435,7 @@ pub fn connect(
437435
let server = format!("{}:{}", host, port);
438436
let future = ClientBuilder::from_url(&ws_url)
439437
.add_protocol(SUBPROTOCOL)
440-
.async_connect_secure(tls_config, handle)
438+
.async_connect_secure(tls_config)
441439
.map_err(move |e: WebSocketError| {
442440
SaltyError::Network(match e.cause() {
443441
Some(cause) => {

tests/integration.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,12 +106,11 @@ fn connect_to(
106106

107107
// Reactor
108108
let mut core = Core::new().unwrap();
109-
let handle = core.handle();
110109

111110
// Connect
112111
let timeout = Duration::from_millis(1000);
113112
let (connect_future, event_channel) =
114-
saltyrtc_client::connect(host, port, tls_connector, &handle, salty.clone()).unwrap();
113+
saltyrtc_client::connect(host, port, tls_connector, salty.clone()).unwrap();
115114
let future = connect_future.and_then(|client| {
116115
saltyrtc_client::do_handshake(client, salty, event_channel.clone_tx(), Some(timeout))
117116
});

0 commit comments

Comments
 (0)