Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some functionality into Peer class #65

Open
dbrgn opened this issue Nov 8, 2016 · 0 comments
Open

Move some functionality into Peer class #65

dbrgn opened this issue Nov 8, 2016 · 0 comments
Labels
improvement
Milestone
1.x Release

Comments

@dbrgn
Copy link
Member

dbrgn commented Nov 8, 2016

Some functionality like this.

  • Signaling.encryptHandshakeDataForServer(...)
  • Signaling.encryptHandshakeDataForPeer(...)

...could be moved into the Peer class. Then polymorphism could replace if-else statements.
@dbrgn dbrgn modified the milestone: 1.x Release Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
1.x Release
Development

No branches or pull requests
1 participant
@dbrgn