Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Inconsistent Method Signatures on transports PublishServer #66941

Open
Sxderp opened this issue Oct 1, 2024 · 0 comments
Open

[BUG] Inconsistent Method Signatures on transports PublishServer #66941

Sxderp opened this issue Oct 1, 2024 · 0 comments
Labels
Bug broken, incorrect, or confusing behavior needs-triage

Comments

@Sxderp
Copy link

Sxderp commented Oct 1, 2024

Description
Ideally all the transports have the same interface so that they can be plugged in and used as desired. I noticed a few instances where the method signatures do not match. Notably the "io_loop" parameter on ZeroMQ def publisher as well as ssl in the __init__.

The missing ssl argument contributes to #66577 although fixing the method definition does not completely fix that issue.

The missing io_loop contributes to being unable to use ZeroMQ as an internal IPC transport. Right now TCP is hardcoded as the only option. See here and here. The io_loop parameter is used by the server to start the service, but fails with ZeroMQ. Once the method is fixed ZeroMQ started to work without issue.

Setup
N/A

Steps to Reproduce the behavior
N/A

Expected behavior
The ability to use any transport.

Screenshots
N/A

Versions Report
N/A

Additional context
PR #66751

Followups should probably be made to normalize RequestServer / RequestClient / PublishClient.

@Sxderp Sxderp added Bug broken, incorrect, or confusing behavior needs-triage labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior needs-triage
Projects
None yet
Development

No branches or pull requests

1 participant