Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [s3fs] files are not deleted #65611

Open
dead10ck opened this issue Nov 24, 2023 · 4 comments · Fixed by #65614
Open

[BUG] [s3fs] files are not deleted #65611

dead10ck opened this issue Nov 24, 2023 · 4 comments · Fixed by #65614
Labels
Bug broken, incorrect, or confusing behavior File Servers info-needed waiting for more info needs-triage

Comments

@dead10ck
Copy link
Contributor

With s3fs, when a file is deleted from the bucket, is does not get deleted from the master or minion when they sync with s3.

This can cause strange and confusing results when files are deleted or moved. For example, if a state file is removed, but you forget to remove its invocation from top.sls, it still exists in the minion's / master's cache and will still apply the old state.

@dead10ck dead10ck added Bug broken, incorrect, or confusing behavior needs-triage labels Nov 24, 2023
@OrangeDog OrangeDog added File Servers info-needed waiting for more info labels Nov 25, 2023
@OrangeDog
Copy link
Contributor

Please provide all the information requested in the Bug template.

Can you confirm you have run salt-run fileserver.update but the deleted states still appear to be present?

@dead10ck
Copy link
Contributor Author

None of the info I left out from the template is relevant. You can see for yourself in s3fs.py that it does not delete any files anywhere. I'm actually already in the process of developing a fix for this.

Can you confirm you have run salt-run fileserver.update but the deleted states still appear to be present?

As I said

is does not get deleted from the master or minion when they sync with s3.

This is exactly the bug I'm reporting.

@OrangeDog
Copy link
Contributor

None of the info I left out from the template is relevant

In your opinion.

You haven't even said what version of Salt you are using.

@dead10ck
Copy link
Contributor Author

Here's the commit history for s3fs.py. You'll notice the last one was two years ago. Tell me some more about the subjectivity of the version's relevance to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior File Servers info-needed waiting for more info needs-triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants