-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Parallel salt.state with ssh fails if same minion is targeted #62612
Comments
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
I can confirm the same issue happens to me. It's super easy to replicate, just run an orchestration SLS with There seems to be a race condition when deploying the salt thin directory and tarball. There are no logs in the target machine indicating problems, nor does the Salt (To start with, the thin directory shouldn't need to be regenerated or redeployed on every execution. This indicates to me that there is a race condition in the way that Salt generates the tarball. Alternatively or complementarily, there must be a file being overwritten in the target machine during execution which is a shared resource and therefore one of the parallel state application processes "wins" and the others die.) |
Good stuff to report. With no thin dir options in my Saltfile, an orchestration run that targets the same machine across different states, doesn't work (only one of the runs "wins" and actually executes something). Watching the temporary directory very clearly indicates that Salt has attempted to deploy the thin dir multiple times. With a fixed thin dir, same result. Even with rand_thin_dir in the Saltfile, same result. At no point does Salt attempt to select a different thin dir based on different parallel salt-ssh runs (which I can see on my process list!) started by salt-run. |
Description
Parallel salt.state with ssh fails if same minion is targeted. The first minion is successful the other minion fail without a clear error.
Setup
Version 3005
parallel-same-minion.sls:
sleep.sls:
Steps to Reproduce the behavior
Added the 2 sls files above and run: sudo salt-run state.orchestrate parallel-same-minion.
See the following output:
Expected behavior
Either both results successful or some sort of error on one of the results.
Now it just shows Total states run: 0 for one of the results
Screenshots
If applicable, add screenshots to help explain your problem.
Versions Report
salt --versions-report
(Provided by running salt --versions-report. Please also mention any differences in master/minion versions.)Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: