-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] salt-ssh AttributeError: 'NoneType' object has no attribute 'count' #62313
Comments
After looking at the code I've found that the error is coming from this line of code salt/salt/client/ssh/__init__.py Line 470 in edd8f78
where the dict entry for From what I understand the reason that salt/salt/client/ssh/__init__.py Lines 533 to 567 in edd8f78
is failing. Although I don't understand why this is failing as the string returned in the This leads me to believe that there is a second bug in the function Lines 28 to 50 in edd8f78
that incorrectly throws a |
This should be fixed in 3007+ by #64542. |
Description of Issue
I'm getting a stack trace when deploying a large spring boot jar file to a target host using salt-ssh. Relevant stack trace
Setup
A salt state forcing the described error has been provided in this GitHub repository https://github.com/xmsk/salt-ssh-stdout-json-parse.
The salt state is deploying a spring boot jar file to a target host using salt-ssh. The given salt state has been crafted in a way that forces the error each time. Usually the error only happens on the first deployment as subsequent deployments with the same jar file do not generate a diff in the
file.managed
state.Setting the option
show_changes: False
on the relevantfile.managed
state fixes the issue as far as I can tell. However, getting to the point where I understood what was causing the issue was quite hard which is why I was hoping that some code changes could be made to make it more obvious how to fix the issue.Steps to Reproduce Issue
Run the provided salt state using the command
Versions Report
I've used the latest salt-ssh version from the master branch running in a virtualenv
The text was updated successfully, but these errors were encountered: