Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ops-Impr] Need to get builddocs generative tests, such as Sphinx PDF generation, into GitHub Actions #59451

Open
ScriptAutomate opened this issue Feb 8, 2021 · 0 comments
Assignees
Labels

Comments

@ScriptAutomate
Copy link
Contributor

ScriptAutomate commented Feb 8, 2021

Description

This is a follow-up to #59446

  • Which was a PR made because of an issue discovered downstream with our builddocs repo on GitLab.

Right now, PDF-breaking changes (or EPUB-breaking changes) won't be caught until the pipelines in builddocs launch against the latest updates to the master branch of this repo.

Suggested Fix

Add another docs test, similar to how we test for building the man pages and HTML. We should, at a minimum, include PDF building tests. EPUB builds seem to be more resilient, and would be an optional add. Especially because I don't know what the long-term value of maintaining the EPUB is.

Since builddocs is a public repo, we'd be able to simply git clone it into an action, and run the necessary commands from there.

@ScriptAutomate ScriptAutomate added Documentation Relates to Salt documentation Tests labels Feb 8, 2021
@sagetherage sagetherage added this to the Silicon milestone Feb 8, 2021
@sagetherage sagetherage removed the Documentation Relates to Salt documentation label Mar 11, 2021
@sagetherage sagetherage added the Documentation Relates to Salt documentation label May 27, 2021
@sagetherage sagetherage modified the milestones: Silicon, Approved Aug 3, 2021
@sagetherage sagetherage added auto-test ops-improve and removed Documentation Relates to Salt documentation Silicon v3004.0 Release code name Tests labels Aug 3, 2021
@sagetherage sagetherage changed the title [DOCS] Need to get builddocs generative tests, such as Sphinx PDF generation, into GitHub Actions [Ops-Impr] Need to get builddocs generative tests, such as Sphinx PDF generation, into GitHub Actions Aug 3, 2021
@sagetherage sagetherage added the Phosphorus v3005.0 Release code name and version label Aug 3, 2021
@sagetherage sagetherage modified the milestones: Approved, Phosphorus Aug 3, 2021
@ScriptAutomate ScriptAutomate removed their assignment Sep 30, 2021
@garethgreenaway garethgreenaway assigned bryceml and unassigned bryceml Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants