Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] tests/integration/netapi/rest_tornado don't pass under pytest #57749

Open
oeuftete opened this issue Jun 22, 2020 · 2 comments
Open

[BUG] tests/integration/netapi/rest_tornado don't pass under pytest #57749

oeuftete opened this issue Jun 22, 2020 · 2 comments
Labels
Bug broken, incorrect, or confusing behavior Phosphorus v3005.0 Release code name and version Salt-API severity-high 2nd top severity, seen by most users, causes major problems Tests

Comments

@oeuftete
Copy link
Contributor

Description

The tests under tests/integration/netapi/rest_tornado that work with runtests (with the workaround in #57748 to allow them to be selected) do not work with pytest.

Steps to Reproduce the behavior

This will cause a couple of tests to fail. If the tests are not limited with -k, they will eventually hang, so maybe the tests are also not as independent as they need to be when run with pytest?

nox -e 'pytest-zeromq-3.6(coverage=False)' -- --log-cli-level=debug -svv --run-slow tests/integration/netapi/rest_tornado/ -k test_get

test_run.log

Expected behavior

Tests pass.

Versions Report

Code as of https://github.com/saltstack/salt/releases/tag/v3001.

@oeuftete oeuftete added Bug broken, incorrect, or confusing behavior Tests labels Jun 22, 2020
@oeuftete oeuftete added this to the Approved milestone Jun 22, 2020
@oeuftete
Copy link
Contributor Author

@s0undt3ch Should I just close this? Everything working under pytest is the eventual goal, right, so an issue about specific tests failing is unnecessary?

@s0undt3ch
Copy link
Collaborator

No leave open, if as you say we're hanging, it's valid, though, the failures seen here are not api related...

@sagetherage sagetherage added severity-high 2nd top severity, seen by most users, causes major problems Phosphorus v3005.0 Release code name and version labels Jun 16, 2021
@sagetherage sagetherage modified the milestones: Approved, Phosphorus Jun 16, 2021
@s0undt3ch s0undt3ch removed their assignment Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior Phosphorus v3005.0 Release code name and version Salt-API severity-high 2nd top severity, seen by most users, causes major problems Tests
Projects
None yet
Development

No branches or pull requests

4 participants