-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logrotate.set fails on CentOS 7's /etc/logrotate.d/syslog #48125
Comments
I too am hitting similar issues with I then hit an issue where it's showing changes every time it executes, even when no changes are required. I worked around that by using an So my state ends up looking like this:
The module seems very buggy in general. |
I just ran into this issue on a Debian 9 running 2018.3.2 (Oxygen). Solution for me was to remove the "conf_file" directive. Since it's been some time since my last PR, I'll see if I can find time to look at this in the coming week. |
just ran into this on ubuntu 18.04, with salt 2019.2.0. since this is a bug that breaks documented behaviour (ie: using |
ZD-6406 |
It's been 2 years since this was reported, any updates from the team on when this might get addressed? |
I'd say this state is broken. It could really use some attention. |
Using salt-3003-1. Made a tiny mod to the 'conf_file' line and it's spitting out a python3 "KeyError: 'include files'" error. |
Here is the content of my
/etc/logrotate.d/syslog
(it was this way out of the box):Here is my SLS file:
First, a minor issue: if I ask Salt to edit
/etc/logrotate.d/syslog
directly usingconf_file
directive, it will fail withKeyError: include files
. The following patch helped:Now, the main issue:
Error: A setting for a dict was declared, but the configuration line given is not a dict
. I dumped the parsed conf, and apparently the parser did not process multiple file syntax correctly:(Edit) Ugly workaround for now:
Versions Report
v2017.7.3
The text was updated successfully, but these errors were encountered: