Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Python 2.7 #183

Open
andy-maier opened this issue Nov 29, 2019 · 1 comment
Open

Support for Python 2.7 #183

andy-maier opened this issue Nov 29, 2019 · 1 comment

Comments

@andy-maier
Copy link
Contributor

  • istr version: 1.0.1
  • Python version: 2.7
  • Operating System: any

Description

Despite the fact that Python 2.7 wil be declared end of life in 1/2020, there are numerous projects out there that still support it. If any of those wants to start using istr, the main inhibitor will be that istr does not support 2.7. My own Python projects are all of that category :-)

I think what it takes to add Python 2.7 support is:

  • using six.text_type instead of str (or because nothing else would be used of six, a simple type definition that mimics that).
  • replacing str.casefold() with str.tolower()
@s0undt3ch
Copy link
Contributor

I'm really not against dropping support down to 2.7.
I guess, as long as we made it clear that the behavior is not the same, ie, .casefold() is not the same as .lower(). As you suggesting we implement tolower() and have it do all the work .casefold() does in Py3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants