Open
Conversation
yankewei
force-pushed
the
feature/psr-20-clock-support
branch
3 times, most recently
from
20f76dd to
fa47564
Compare
yankewei
force-pushed
the
feature/psr-20-clock-support
branch
from
fa47564 to
b4c1744
Compare
Contributor
Author
|
@craigpotter When you have a moment, please review this PR and share any feedback you may have. |
yankewei
force-pushed
the
feature/psr-20-clock-support
branch
from
b4c1744 to
302087a
Compare
Member
|
The code looks good @yankewei - and I quite like the idea of it. If you could give me a couple more weeks I will get round to reviewing properly. |
yankewei
force-pushed
the
feature/psr-20-clock-support
branch
from
2ed94db to
d091497
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #508
Added support for PSR-20 to enhance testability.
Furthermore, we do not rely on specific implementations of PSR-20—any project using this library can adopt any date library that implements the PSR-20 specification, such as Carbon or the Symfony Clock Component. This approach offers greater flexibility.