Feature | Add OAuth 1.0a Authenticator#469
Open
fredbradley wants to merge 2 commits intosaloonphp:v3from
Open
Conversation
Member
|
Thanks @fredbradley I will take a look soon and see if I can potentially refactor this to be trait-style like the other OAuth2 implementations, unless you want to give it a go? |
Member
|
Hey @fredbradley any further thoughts on moving to a trait? |
Author
|
Hi @Sammyjo20, I wasn't sure there was need to make it into a trait. It's a one class Authenticator, just like the other Authenticators. Usage: I don't see the benefit of converting it to be trait like, this syntax is used elsewhere in Saloon. In |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was working on a project that needed authentication with OAuth1.0a.
Here was the solution.