Sm/manifest-api-version (#636)

* fix: mdapi:retrieve respects manifest apiVersion

* test: manually modify nut manifest version to assert

Author: mshanemc

src/commands/force/mdapi/retrieve.ts

@@ -129,7 +129,10 @@ export class Retrieve extends SourceCommand {
     this.ux.setSpinnerStatus(spinnerMessages.getMessage('retrieve.componentSetBuild'));
 
     this.componentSet = await ComponentSetBuilder.build({
-      apiversion: this.getFlag<string>('apiversion') ?? (await this.org.retrieveMaxApiVersion()),
+      // use the apiVersion if provided.
+      // Manifests default to their specified apiVersion(ComponentSetBuilder handles this)
+      // and not specifying the apiVersion will use the max for the org/Connection
+      apiversion: this.getFlag<string>('apiversion'),
       packagenames,
       sourcepath: this.sourceDir ? [this.sourceDir] : undefined,
       manifest: manifest && {

test/nuts/mdapi.nut.ts

@@ -332,6 +332,22 @@ describe('mdapi NUTs', () => {
         expect(result.zipFilePath).to.equal(zipFileLocation);
       });
 
+      it('retrieves content from manifest using manifest api version', async () => {
+        // modify the manifest to use a different api version
+        const targetApiVersion = '54.0';
+        const manifestRelativePath = path.join(session.project.dir, manifestPath);
+
+        const original = await fs.promises.readFile(manifestRelativePath, 'utf8');
+        await fs.promises.writeFile(
+          manifestRelativePath,
+          original.replace(/<version>.*<\/version>/g, `<version>${targetApiVersion}</version>`)
+        );
+        const retrieveTargetDir = 'mdRetrieveFromManifest';
+        const cmd = `force:mdapi:retrieve -w 10 -r ${retrieveTargetDir} -k ${manifestPath}`;
+        const rv = execCmd<RetrieveCommandResult>(cmd, { ensureExitCode: 0 }).shellOutput;
+        expect(rv.stderr).to.include(targetApiVersion);
+      });
+
       it('retrieves single package', () => {
         const retrieveTargetDir = 'mdRetrieveSinglePackage';
         const retrieveTargetDirPath = path.join(session.project.dir, retrieveTargetDir);