fix: address deploy/run PR review feedback

- Remove the datacustomcode binary check so init/scan work with only the SDK
  library installed; the retired console-script is no longer required (was
  throwing BinaryNotFound). Deletes DatacodeBinaryChecker and its dead keys.
- Localize the configNotFound actions and render the real command
  (e.g. 'sf data-code-extension script init') instead of a literal '<type>'.
- Guard htmlUnescape against RangeError on invalid code points, matching
  Python's html.unescape (leave the raw entity intact).
- Reject non-HTTPS presigned upload URLs instead of allowing plaintext http.
- Point the stale 'datacustomcode init' hint in nativeScan at the SF CLI command.
- Keep the intentional COMPUTE_TYPES offset note in nativeDeploy.

Author: jcatt-sf

messages/datacodeBinaryChecker.md

@@ -52,14 +52,6 @@ Checking required Python packages...
 
 Package '%s' version %s found
 
-# info.checkingBinary
-
-Checking datacustomcode binary...
-
-# info.binaryFound
-
-Datacustomcode binary version %s found
-
 # info.authenticating
 
 Authenticating with Salesforce org '%s'...
@@ -212,6 +204,11 @@ Function signature does not match a supported type. Use SearchIndexChunkingV1Req
 
 config.json not found at %s.
 
+# actions.configNotFound
+
+- Run 'sf data-code-extension %s init' to scaffold the package.
+- Run 'sf data-code-extension %s scan' to populate config.json before deploying.
+
 # error.configInvalidJson
 
 config.json at %s is not valid JSON.
@@ -240,6 +237,10 @@ The deployment request returned no file upload URL. Verify the org has Data Clou
 
 Failed to upload the deployment package (HTTP %s): %s
 
+# error.insecureUploadUrl
+
+The deployment upload URL must use HTTPS but a '%s' URL was returned. Refusing to upload the package over an insecure connection.
+
 # error.deploymentTimedOut
 
 Deployment timed out.

messages/deploy.md

@@ -44,14 +44,6 @@ Checking required Python packages...
 
 Package '%s' version %s found
 
-# info.checkingBinary
-
-Checking datacustomcode binary...
-
-# info.binaryFound
-
-Datacustomcode binary version %s found
-
 # info.executingInit
 
 Initializing Data Cloud package...

messages/init.md

@@ -46,14 +46,6 @@ Checking required Python packages...
 
 Package '%s' version %s found
 
-# info.checkingBinary
-
-Checking datacustomcode binary...
-
-# info.binaryFound
-
-Datacustomcode binary version %s found
-
 # info.authenticating
 
 Authenticating with Salesforce org '%s'...

messages/run.md

@@ -101,11 +101,3 @@ Checking required Python packages...
 # info.packageFound
 
 Package '%s' version %s found
-
-# info.checkingBinary
-
-Checking datacustomcode binary...
-
-# info.binaryFound
-
-Datacustomcode binary version %s found

messages/scan.md

@@ -28,14 +28,6 @@ Checking required Python packages...
 
 Package '%s' version %s found
 
-# info.checkingBinary
-
-Checking datacustomcode binary...
-
-# info.binaryFound
-
-Datacustomcode binary version %s found
-
 # info.executingZip
 
 Creating package archive...

messages/zip.md

@@ -40,11 +40,7 @@ export abstract class InitBase<TFlags extends BaseInitFlags = BaseInitFlags> ext
     const additionalFlags = this.getAdditionalFlags(flags);
 
     try {
-      const { pythonInfo, packageInfo, binaryInfo } = await checkEnvironment(
-        this.spinner,
-        this.log.bind(this),
-        messages
-      );
+      const { pythonInfo, packageInfo } = await checkEnvironment(this.spinner, this.log.bind(this), messages);
 
       this.spinner.start(messages.getMessage('info.executingInit'));
       const executionResult = await executeNativeInit({
@@ -66,7 +62,6 @@ export abstract class InitBase<TFlags extends BaseInitFlags = BaseInitFlags> ext
         success: true,
         pythonVersion: pythonInfo,
         packageInfo,
-        binaryInfo,
         codeType,
         packageDir,
         executionResult,

src/base/initBase.ts

@@ -50,11 +50,8 @@ export abstract class RunBase extends SfCommand<RunResult> {
 
     try {
       // `run` invokes the SDK library (datacustomcode.run.run_entrypoint) through
-      // Python, so it needs Python + the salesforce-data-customcode package but NOT
-      // the datacustomcode console-script binary.
-      const { pythonInfo, packageInfo } = await checkEnvironment(this.spinner, this.log.bind(this), messages, {
-        checkBinary: false,
-      });
+      // Python, so it needs Python + the salesforce-data-customcode package.
+      const { pythonInfo, packageInfo } = await checkEnvironment(this.spinner, this.log.bind(this), messages);
 
       let orgUsername: string | undefined;
 

src/base/runBase.ts

@@ -46,11 +46,7 @@ export abstract class ScanBase extends SfCommand<ScanResult> {
     const workingDir = process.cwd();
 
     try {
-      const { pythonInfo, packageInfo, binaryInfo } = await checkEnvironment(
-        this.spinner,
-        this.log.bind(this),
-        messages
-      );
+      const { pythonInfo, packageInfo } = await checkEnvironment(this.spinner, this.log.bind(this), messages);
 
       this.spinner.start(messages.getMessage('info.executingScan'));
       const executionResult = await executeNativeScan({
@@ -85,7 +81,6 @@ export abstract class ScanBase extends SfCommand<ScanResult> {
         success: true,
         pythonInfo,
         packageInfo,
-        binaryInfo,
         codeType,
         workingDirectory: workingDir,
         executionResult,

src/base/scanBase.ts

@@ -15,14 +15,12 @@
  */
 import { type PythonVersionInfo } from '../utils/pythonChecker.js';
 import { type PipPackageInfo } from '../utils/pipChecker.js';
-import { type DatacodeBinaryInfo } from '../utils/datacodeBinaryChecker.js';
 
 export type SharedResultProps = {
   success: boolean;
   /** Populated by commands that run the Python environment check (e.g. `run`); absent for `deploy`. */
   pythonVersion?: PythonVersionInfo;
   packageInfo?: PipPackageInfo;
-  binaryInfo?: DatacodeBinaryInfo;
   codeType: 'script' | 'function';
   packageDir: string;
   message: string;