chore: move types to library

Author: WillieRuemmele

src/commands/agent/preview.ts

@@ -22,7 +22,14 @@ import { AuthInfo, Connection, Lifecycle, Messages, SfError } from '@salesforce/
 import React from 'react';
 import { render } from 'ink';
 import { env } from '@salesforce/kit';
-import { AgentPreview as Preview, AgentSimulate, findAuthoringBundle } from '@salesforce/agents';
+import {
+  AgentPreview as Preview,
+  AgentSimulate,
+  findAuthoringBundle,
+  AgentSource,
+  ScriptAgent,
+  PublishedAgent,
+} from '@salesforce/agents';
 import { select, confirm, input } from '@inquirer/prompts';
 import { AgentPreviewReact } from '../../components/agent-preview-react.js';
 
@@ -45,20 +52,6 @@ type Choice<Value> = {
   disabled?: boolean | string;
 };
 
-enum AgentSource {
-  PUBLISHED = 'published',
-  SCRIPT = 'script',
-}
-
-type ScriptAgent = { DeveloperName: string; source: AgentSource.SCRIPT; path: string };
-type PublishedAgent = {
-  Id: string;
-  DeveloperName: string;
-  source: AgentSource.PUBLISHED;
-};
-
-type AgentValue = ScriptAgent | PublishedAgent;
-
 // https://developer.salesforce.com/docs/einstein/genai/guide/agent-api-get-started.html#prerequisites
 export const UNSUPPORTED_AGENTS = ['Copilot_for_Salesforce'];
 
@@ -116,7 +109,7 @@ export default class AgentPreview extends SfCommand<AgentPreviewResult> {
       )
     ).records;
 
-    let selectedAgent: AgentValue;
+    let selectedAgent: ScriptAgent | PublishedAgent;
 
     if (flags['authoring-bundle']) {
       // user specified --authoring-bundle, we'll find the script and use it
@@ -141,7 +134,7 @@ export default class AgentPreview extends SfCommand<AgentPreviewResult> {
       };
       if (!selectedAgent) throw new Error(`No valid Agents were found with the Api Name ${apiNameFlag}.`);
     } else {
-      selectedAgent = await select({
+      selectedAgent = await select<ScriptAgent | PublishedAgent>({
         message: 'Select an agent',
         choices: this.getAgentChoices(agentsInOrg),
       });
@@ -205,8 +198,8 @@ export default class AgentPreview extends SfCommand<AgentPreviewResult> {
     await instance.waitUntilExit();
   }
 
-  private getAgentChoices(agents: AgentData[]): Array<Choice<AgentValue>> {
-    const choices: Array<Choice<AgentValue>> = [];
+  private getAgentChoices(agents: AgentData[]): Array<Choice<ScriptAgent | PublishedAgent>> {
+    const choices: Array<Choice<ScriptAgent | PublishedAgent>> = [];
 
     // Add org agents
     for (const agent of agents) {

test/commands/agent/preview/index.test.ts

@@ -23,7 +23,6 @@ import {
   agentIsUnsupported,
   agentIsInactive,
   validateAgent,
-  getAgentChoices,
 } from '../../../../src/commands/agent/preview.js';
 
 // TODO - pull in error messages
@@ -140,55 +139,23 @@ describe('Agent Preview', () => {
     });
   });
 
-  describe('gets agent choices', () => {
-    it('returns agent choices', () => {
-      const agents: AgentData[] = [
-        {
-          Id: 'OXx1234567890',
-          DeveloperName: 'some_agent',
-          BotVersions: {
-            records: [{ Status: 'Active' }],
-          },
-        },
-        {
-          Id: 'OXx1234567891',
-          DeveloperName: UNSUPPORTED_AGENTS[0],
-          BotVersions: {
-            records: [{ Status: 'Active' }],
-          },
-        },
-        {
-          Id: 'OXx1234567892',
-          DeveloperName: 'inactive_agent',
-          BotVersions: {
-            records: [{ Status: 'Inactive' }],
-          },
-        },
-      ];
-
-      const choices = getAgentChoices(agents);
-      expect(choices).to.have.lengthOf(3);
+  describe('agent source types', () => {
+    it('should support script agent source type', () => {
+      const scriptAgent = {
+        DeveloperName: 'test-agent',
+        source: 'script' as const,
+        path: '/path/to/agent.agent',
+      };
+      expect(scriptAgent.source).to.equal('script');
+    });
 
-      expect(choices[0].name).to.equal('some_agent');
-      expect(choices[0].value).to.deep.equal({
+    it('should support published agent source type', () => {
+      const publishedAgent = {
         Id: 'OXx1234567890',
-        DeveloperName: 'some_agent',
-      });
-      expect(choices[0].disabled).to.equal(false);
-
-      expect(choices[1].name).to.equal(UNSUPPORTED_AGENTS[0]);
-      expect(choices[1].value).to.deep.equal({
-        Id: 'OXx1234567891',
-        DeveloperName: UNSUPPORTED_AGENTS[0],
-      });
-      expect(choices[1].disabled).to.equal('(Not Supported)');
-
-      expect(choices[2].name).to.equal('inactive_agent');
-      expect(choices[2].value).to.deep.equal({
-        Id: 'OXx1234567892',
-        DeveloperName: 'inactive_agent',
-      });
-      expect(choices[2].disabled).to.equal('(Inactive)');
+        DeveloperName: 'test-agent',
+        source: 'published' as const,
+      };
+      expect(publishedAgent.source).to.equal('published');
     });
   });
 });