Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local alias for toString #409

Merged

Conversation

corvidism
Copy link

Set toString to Object.prototype.toString as the code implicitly expects, to avoid conflicts with mocked globals. (see issue #405).

Copy link

Thanks for the contribution! Before we can merge this, we need @corvidism to sign the Salesforce Inc. Contributor License Agreement.

@corvidism corvidism changed the base branch from master to next April 15, 2024 13:44
Copy link

Thanks for the contribution! Before we can merge this, we need @inikulin @stash-sfdc to sign the Salesforce Inc. Contributor License Agreement.

Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Yevhen Lukomskyi <Y***@3***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated.

@corvidism corvidism changed the base branch from next to master April 15, 2024 13:45
@corvidism corvidism marked this pull request as draft April 15, 2024 13:46
@colincasey
Copy link
Contributor

@corvidism thanks for the PR! Now I just have to figure out how to backport this into the 4.1.x release since that's not something I've had to do with this project before but I'll try to get to it by the end of the week.

@corvidism
Copy link
Author

Great! Thanks for the effort.

@colincasey colincasey changed the base branch from master to backport_fix_for_v4.1 April 23, 2024 19:00
@colincasey
Copy link
Contributor

Closing and reopening to see if it fixes the synk PR checks.

@colincasey colincasey closed this Apr 23, 2024
@colincasey colincasey reopened this Apr 23, 2024
@colincasey colincasey marked this pull request as ready for review April 26, 2024 19:04
@colincasey colincasey merged commit 1253d58 into salesforce:backport_fix_for_v4.1 Apr 26, 2024
3 checks passed
renovate bot referenced this pull request in Unleash/unleash May 8, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [tough-cookie](https://togithub.com/salesforce/tough-cookie) |
[`4.1.3` ->
`4.1.4`](https://renovatebot.com/diffs/npm/tough-cookie/4.1.3/4.1.4) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/tough-cookie/4.1.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/tough-cookie/4.1.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/tough-cookie/4.1.3/4.1.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/tough-cookie/4.1.3/4.1.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>salesforce/tough-cookie (tough-cookie)</summary>

###
[`v4.1.4`](https://togithub.com/salesforce/tough-cookie/releases/tag/v4.1.4)

[Compare
Source](https://togithub.com/salesforce/tough-cookie/compare/v4.1.3...v4.1.4)

https://www.npmjs.com/package/tough-cookie/v/4.1.4

#### What's Changed

- Add local alias for `toString` by
[@&#8203;corvidism](https://togithub.com/corvidism) in
[https://github.com/salesforce/tough-cookie/pull/409](https://togithub.com/salesforce/tough-cookie/pull/409)
- Fix incorrect string validation for URL by
[@&#8203;coditva](https://togithub.com/coditva) in
[https://github.com/salesforce/tough-cookie/pull/261](https://togithub.com/salesforce/tough-cookie/pull/261)

#### New Contributors

- [@&#8203;corvidism](https://togithub.com/corvidism) made their first
contribution in
[https://github.com/salesforce/tough-cookie/pull/409](https://togithub.com/salesforce/tough-cookie/pull/409)
- [@&#8203;coditva](https://togithub.com/coditva) made their first
contribution in
[https://github.com/salesforce/tough-cookie/pull/261](https://togithub.com/salesforce/tough-cookie/pull/261)

**Full Changelog**:
salesforce/tough-cookie@v4.1.3...v4.1.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 7pm every weekday,before 5am
every weekday" in timezone Europe/Madrid, Automerge - At any time (no
schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Unleash/unleash).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants