-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix expiry time not updating when cookie is updated #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `cookie.expiryTime()` method was calculating an `expiry-time` value using `creation-time + max-age` if the `max-age` value was set. This is not correct as RFC6265 does not say anything about `creation-time` having any effect on `max-age`. The main issue is that `max-age` should be stored as a date (see text below), not an offset number as it currently is implemented. > 5.2.2. The Max-Age Attribute > > If the attribute-name case-insensitively matches the string "Max- > Age", the user agent MUST process the cookie-av as follows. > > If the first character of the attribute-value is not a DIGIT or a "-" > character, ignore the cookie-av. > > If the remainder of attribute-value contains a non-DIGIT character, > ignore the cookie-av. > > Let delta-seconds be the attribute-value converted to an integer. > > If delta-seconds is less than or equal to zero (0), let expiry-time > be the earliest representable date and time. Otherwise, let the > expiry-time be the current date and time plus delta-seconds seconds. > > Append an attribute to the cookie-attribute-list with an attribute- > name of Max-Age and an attribute-value of expiry-time. Because `max-age` is an offset, the `expiry-time` now needs to be calculated from "some" point in time and `creation-time` was chosen. In many cases this works fine but, if you have an existing cookie stored with a `max-age` attribute and then update it, the `expiry-time` will be incorrectly report the previous value's `expiry-time`. This is due to the following rule regarding `creation-time` from the spec: > 5.3. Storage Model > > 11. If the cookie store contains a cookie with the same name, > domain, and path as the newly created cookie: > > 1. Let old-cookie be the existing cookie with the same name, > domain, and path as the newly created cookie. (Notice that > this algorithm maintains the invariant that there is at most > one such cookie.) > > 2. If the newly created cookie was received from a "non-HTTP" > API and the old-cookie's http-only-flag is set, abort these > steps and ignore the newly created cookie entirely. > > 3. Update the creation-time of the newly created cookie to > match the creation-time of the old-cookie. > > 4. Remove the old-cookie from the cookie store. This should make it clear that `creation-time` should not be used to calculate the `expiry-time`. Given that we still need to calculate the `expiry-time` due to how `max-age` is stored, the better value to use in this circumstance is the `last-access-time` which is always updated when `setCookie(...)` is called. Fixes #343 Fixes #154
wjhsf
previously approved these changes
Dec 13, 2023
awaterma
previously approved these changes
Jan 12, 2024
wjhsf
approved these changes
Jan 16, 2024
wjhsf
pushed a commit
that referenced
this pull request
Feb 8, 2024
kc13greiner
referenced
this pull request
in elastic/kibana
Sep 18, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [tough-cookie](https://togithub.com/salesforce/tough-cookie) | devDependencies | major | [`^4.1.4` -> `^5.0.0`](https://renovatebot.com/diffs/npm/tough-cookie/4.1.4/5.0.0) | --- ### Release Notes <details> <summary>salesforce/tough-cookie (tough-cookie)</summary> ### [`v5.0.0`](https://togithub.com/salesforce/tough-cookie/releases/tag/v5.0.0) [Compare Source](https://togithub.com/salesforce/tough-cookie/compare/v4.1.4...v5.0.0) #### Summary ##### Breaking Changes - We've migrated the project to TypeScript! First-party types are now available. - The minimum supported version of node is v18. - We no longer provide official support for non-node enviroments. ##### API Changes - We've standardized most of our exposed interfaces to accept both `null` and `undefined` and return only `undefined`. - `getCookie` and `getCookies` now accept a `string` or `URL` as a parameter. - We've removed the `inspect` function in favor of node's `util.inspect.custom` symbol. Cookies may appear different when logged in non-node environments. ##### Other Changes - Fixed the expiry time not updating when a cookie is updating. - Fixed validation errors not getting called in some callbacks. - [New documentation](https://togithub.com/salesforce/tough-cookie/blob/v5.0.0/api/docs/tough-cookie.md) that is always kept up to date! - Performance improvements. #### What's Changed - Typescript support by [@​colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/264](https://togithub.com/salesforce/tough-cookie/pull/264) - \[v5] Update config by [@​wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/269](https://togithub.com/salesforce/tough-cookie/pull/269) - Fix prettier in eslint config by [@​wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/274](https://togithub.com/salesforce/tough-cookie/pull/274) - Updated dev tooling by [@​colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/271](https://togithub.com/salesforce/tough-cookie/pull/271) - Port 283 fix to v5 by [@​colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/287](https://togithub.com/salesforce/tough-cookie/pull/287) - Remove some [@​ts-ignore](https://togithub.com/ts-ignore) directives. by [@​wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/288](https://togithub.com/salesforce/tough-cookie/pull/288) - Clean up validate function. by [@​wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/275](https://togithub.com/salesforce/tough-cookie/pull/275) - Changes to support full eslint rule configurations by [@​colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/289](https://togithub.com/salesforce/tough-cookie/pull/289) - Split giant cookie.ts into multiple files. by [@​wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/296](https://togithub.com/salesforce/tough-cookie/pull/296) - Merge branch 'master' into v5 by [@​wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/300](https://togithub.com/salesforce/tough-cookie/pull/300) - Merge `v5` into `master` by [@​colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/303](https://togithub.com/salesforce/tough-cookie/pull/303) - Preparing for release `5.0.0-rc.0` by [@​colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/304](https://togithub.com/salesforce/tough-cookie/pull/304) - Bump [@​babel/traverse](https://togithub.com/babel/traverse) from 7.21.3 to 7.23.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/305](https://togithub.com/salesforce/tough-cookie/pull/305) - Configure dependabot and codeowners by [@​colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/306](https://togithub.com/salesforce/tough-cookie/pull/306) - Bump [@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) from 5.58.0 to 5.62.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/310](https://togithub.com/salesforce/tough-cookie/pull/310) - Bump eslint-config-prettier from 8.8.0 to 9.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/311](https://togithub.com/salesforce/tough-cookie/pull/311) - Bump async from 2.6.4 to 3.2.4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/313](https://togithub.com/salesforce/tough-cookie/pull/313) - Avoid using `arguments` by [@​wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/316](https://togithub.com/salesforce/tough-cookie/pull/316) - Configure dependabot to ignore [@​types/node](https://togithub.com/types/node). by [@​wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/319](https://togithub.com/salesforce/tough-cookie/pull/319) - Bump dependencies. by [@​wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/323](https://togithub.com/salesforce/tough-cookie/pull/323) - Bump the dev-dependencies group with 6 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/342](https://togithub.com/salesforce/tough-cookie/pull/342) - Bump the dev-dependencies group with 1 update by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/344](https://togithub.com/salesforce/tough-cookie/pull/344) - Bump the dev-dependencies group with 3 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/347](https://togithub.com/salesforce/tough-cookie/pull/347) - docs: use correct memstore file link by [@​alissonsleal](https://togithub.com/alissonsleal) in [https://github.com/salesforce/tough-cookie/pull/349](https://togithub.com/salesforce/tough-cookie/pull/349) - Bump the dev-dependencies group with 3 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/351](https://togithub.com/salesforce/tough-cookie/pull/351) - Bump the dev-dependencies group with 2 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/354](https://togithub.com/salesforce/tough-cookie/pull/354) - Fix expiry time not updating when cookie is updated by [@​colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/345](https://togithub.com/salesforce/tough-cookie/pull/345) - Change dependabot to monthly by [@​wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/355](https://togithub.com/salesforce/tough-cookie/pull/355) - Bump the dev-dependencies group with 5 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/358](https://togithub.com/salesforce/tough-cookie/pull/358) - Avoid `void` by [@​wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/331](https://togithub.com/salesforce/tough-cookie/pull/331) - Replace `psl` with `tldts` by [@​colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/346](https://togithub.com/salesforce/tough-cookie/pull/346) - Bump the production-dependencies group with 1 update by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/362](https://togithub.com/salesforce/tough-cookie/pull/362) - Bump the dev-dependencies group with 4 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/363](https://togithub.com/salesforce/tough-cookie/pull/363) - docs: fix JSON.serialize -> JSON.stringify by [@​zavan](https://togithub.com/zavan) in [https://github.com/salesforce/tough-cookie/pull/361](https://togithub.com/salesforce/tough-cookie/pull/361) - Remove workarounds for `util` in non-node environments by [@​wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/359](https://togithub.com/salesforce/tough-cookie/pull/359) - Accept URL parameter in `getCookies` and `setCookie` by [@​colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/364](https://togithub.com/salesforce/tough-cookie/pull/364) - Remove community cookie store links by [@​colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/367](https://togithub.com/salesforce/tough-cookie/pull/367) - Handle unlikely edge case in unimportant util by [@​wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/366](https://togithub.com/salesforce/tough-cookie/pull/366) - Fix allow listed `files` for what to include in npm package by [@​colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/368](https://togithub.com/salesforce/tough-cookie/pull/368) - fix [#​256](https://togithub.com/salesforce/tough-cookie/issues/256) by [@​hrueger](https://togithub.com/hrueger) in [https://github.com/salesforce/tough-cookie/pull/297](https://togithub.com/salesforce/tough-cookie/pull/297) - Preparing for release 5.0.0-rc.1 by [@​colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/369](https://togithub.com/salesforce/tough-cookie/pull/369) - Bump [@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin) from 6.20.0 to 7.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/373](https://togithub.com/salesforce/tough-cookie/pull/373) - Bump the production-dependencies group with 1 update by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/370](https://togithub.com/salesforce/tough-cookie/pull/370) - Fixes eslint plugin dev upgrades by [@​colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/375](https://togithub.com/salesforce/tough-cookie/pull/375) - restore `parse` export that was accidentally removed by [@​wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/376](https://togithub.com/salesforce/tough-cookie/pull/376) - Clean up cookie creation by [@​wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/381](https://togithub.com/salesforce/tough-cookie/pull/381) - Enforce explicit function return type by [@​wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/383](https://togithub.com/salesforce/tough-cookie/pull/383) - patch removed util methods for vows by [@​wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/389](https://togithub.com/salesforce/tough-cookie/pull/389) - clean up usage of null/undefined by [@​wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/380](https://togithub.com/salesforce/tough-cookie/pull/380) - Bump the dev-dependencies group with 2 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/404](https://togithub.com/salesforce/tough-cookie/pull/404) - Bump the production-dependencies group with 1 update by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/403](https://togithub.com/salesforce/tough-cookie/pull/403) - Remove `@types/psl` from dev dependencies by [@​colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/406](https://togithub.com/salesforce/tough-cookie/pull/406) - Bump tldts from 6.1.16 to 6.1.18 in the production-dependencies group by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/411](https://togithub.com/salesforce/tough-cookie/pull/411) - Bump the dev-dependencies group with 2 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/412](https://togithub.com/salesforce/tough-cookie/pull/412) - Bump ejs from 3.1.9 to 3.1.10 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/413](https://togithub.com/salesforce/tough-cookie/pull/413) - Update v5 docs by [@​colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/384](https://togithub.com/salesforce/tough-cookie/pull/384) - Enable strict type checked rules by [@​wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/392](https://togithub.com/salesforce/tough-cookie/pull/392) - Preparing for release 5.0.0-rc.2 by [@​colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/414](https://togithub.com/salesforce/tough-cookie/pull/414) - Bump the dev-dependencies group with 4 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/417](https://togithub.com/salesforce/tough-cookie/pull/417) - Bump [@​eslint/js](https://togithub.com/eslint/js) from 8.57.0 to 9.4.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/419](https://togithub.com/salesforce/tough-cookie/pull/419) - Bump tldts from 6.1.18 to 6.1.24 in the production-dependencies group across 1 directory by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/420](https://togithub.com/salesforce/tough-cookie/pull/420) - chore: update deps by [@​wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/421](https://togithub.com/salesforce/tough-cookie/pull/421) - Use latest TypeScript version by [@​wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/423](https://togithub.com/salesforce/tough-cookie/pull/423) - Update contributors by [@​colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/425](https://togithub.com/salesforce/tough-cookie/pull/425) - Bump tldts from 6.1.28 to 6.1.30 in the production-dependencies group by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/426](https://togithub.com/salesforce/tough-cookie/pull/426) - Bump the dev-dependencies group with 4 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/427](https://togithub.com/salesforce/tough-cookie/pull/427) - Fix validation errors not calling callbacks by [@​colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/424](https://togithub.com/salesforce/tough-cookie/pull/424) - Preparing for release 5.0.0-rc.3 by [@​colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/430](https://togithub.com/salesforce/tough-cookie/pull/430) - Remove url-parse and punycode by [@​wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/429](https://togithub.com/salesforce/tough-cookie/pull/429) - Checks structure instead of instanceof for URL test by [@​colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/431](https://togithub.com/salesforce/tough-cookie/pull/431) - pre-release cleanup by [@​wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/428](https://togithub.com/salesforce/tough-cookie/pull/428) - Preparing for release 5.0.0-rc.4 by [@​colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/432](https://togithub.com/salesforce/tough-cookie/pull/432) - use `domainToASCII(str)` instead of `new URL(str).hostName` by [@​wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/433](https://togithub.com/salesforce/tough-cookie/pull/433) - Bump tldts from 6.1.32 to 6.1.37 in the production-dependencies group by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/436](https://togithub.com/salesforce/tough-cookie/pull/436) - Bump the dev-dependencies group across 1 directory with 6 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/439](https://togithub.com/salesforce/tough-cookie/pull/439) - Bump tldts from 6.1.37 to 6.1.41 in the production-dependencies group by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/443](https://togithub.com/salesforce/tough-cookie/pull/443) - Bump the dev-dependencies group with 6 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/444](https://togithub.com/salesforce/tough-cookie/pull/444) - upgrade typescript-eslint to 8.0.1 by [@​wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/440](https://togithub.com/salesforce/tough-cookie/pull/440) - Bump the dev-dependencies group with 2 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/448](https://togithub.com/salesforce/tough-cookie/pull/448) - Bump eslint from 8.57.0 to 9.9.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/449](https://togithub.com/salesforce/tough-cookie/pull/449) - Prepare v5 by [@​colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/451](https://togithub.com/salesforce/tough-cookie/pull/451) #### New Contributors - [@​alissonsleal](https://togithub.com/alissonsleal) made their first contribution in [https://github.com/salesforce/tough-cookie/pull/349](https://togithub.com/salesforce/tough-cookie/pull/349) - [@​zavan](https://togithub.com/zavan) made their first contribution in [https://github.com/salesforce/tough-cookie/pull/361](https://togithub.com/salesforce/tough-cookie/pull/361) - [@​hrueger](https://togithub.com/hrueger) made their first contribution in [https://github.com/salesforce/tough-cookie/pull/297](https://togithub.com/salesforce/tough-cookie/pull/297) **Full Changelog**: salesforce/tough-cookie@v4.1.3...v5.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJUZWFtOlNlY3VyaXR5IiwiYmFja3BvcnQ6YWxsLW9wZW4iLCJyZWxlYXNlX25vdGU6c2tpcCJdfQ==--> Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com>
kibanamachine
referenced
this pull request
in kibanamachine/kibana
Sep 18, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [tough-cookie](https://togithub.com/salesforce/tough-cookie) | devDependencies | major | [`^4.1.4` -> `^5.0.0`](https://renovatebot.com/diffs/npm/tough-cookie/4.1.4/5.0.0) | --- ### Release Notes <details> <summary>salesforce/tough-cookie (tough-cookie)</summary> ### [`v5.0.0`](https://togithub.com/salesforce/tough-cookie/releases/tag/v5.0.0) [Compare Source](https://togithub.com/salesforce/tough-cookie/compare/v4.1.4...v5.0.0) #### Summary ##### Breaking Changes - We've migrated the project to TypeScript! First-party types are now available. - The minimum supported version of node is v18. - We no longer provide official support for non-node enviroments. ##### API Changes - We've standardized most of our exposed interfaces to accept both `null` and `undefined` and return only `undefined`. - `getCookie` and `getCookies` now accept a `string` or `URL` as a parameter. - We've removed the `inspect` function in favor of node's `util.inspect.custom` symbol. Cookies may appear different when logged in non-node environments. ##### Other Changes - Fixed the expiry time not updating when a cookie is updating. - Fixed validation errors not getting called in some callbacks. - [New documentation](https://togithub.com/salesforce/tough-cookie/blob/v5.0.0/api/docs/tough-cookie.md) that is always kept up to date! - Performance improvements. #### What's Changed - Typescript support by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/264](https://togithub.com/salesforce/tough-cookie/pull/264) - \[v5] Update config by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/269](https://togithub.com/salesforce/tough-cookie/pull/269) - Fix prettier in eslint config by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/274](https://togithub.com/salesforce/tough-cookie/pull/274) - Updated dev tooling by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/271](https://togithub.com/salesforce/tough-cookie/pull/271) - Port 283 fix to v5 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/287](https://togithub.com/salesforce/tough-cookie/pull/287) - Remove some [@&elastic#8203;ts-ignore](https://togithub.com/ts-ignore) directives. by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/288](https://togithub.com/salesforce/tough-cookie/pull/288) - Clean up validate function. by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/275](https://togithub.com/salesforce/tough-cookie/pull/275) - Changes to support full eslint rule configurations by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/289](https://togithub.com/salesforce/tough-cookie/pull/289) - Split giant cookie.ts into multiple files. by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/296](https://togithub.com/salesforce/tough-cookie/pull/296) - Merge branch 'master' into v5 by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/300](https://togithub.com/salesforce/tough-cookie/pull/300) - Merge `v5` into `master` by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/303](https://togithub.com/salesforce/tough-cookie/pull/303) - Preparing for release `5.0.0-rc.0` by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/304](https://togithub.com/salesforce/tough-cookie/pull/304) - Bump [@&elastic#8203;babel/traverse](https://togithub.com/babel/traverse) from 7.21.3 to 7.23.2 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/305](https://togithub.com/salesforce/tough-cookie/pull/305) - Configure dependabot and codeowners by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/306](https://togithub.com/salesforce/tough-cookie/pull/306) - Bump [@&elastic#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) from 5.58.0 to 5.62.0 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/310](https://togithub.com/salesforce/tough-cookie/pull/310) - Bump eslint-config-prettier from 8.8.0 to 9.0.0 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/311](https://togithub.com/salesforce/tough-cookie/pull/311) - Bump async from 2.6.4 to 3.2.4 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/313](https://togithub.com/salesforce/tough-cookie/pull/313) - Avoid using `arguments` by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/316](https://togithub.com/salesforce/tough-cookie/pull/316) - Configure dependabot to ignore [@&elastic#8203;types/node](https://togithub.com/types/node). by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/319](https://togithub.com/salesforce/tough-cookie/pull/319) - Bump dependencies. by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/323](https://togithub.com/salesforce/tough-cookie/pull/323) - Bump the dev-dependencies group with 6 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/342](https://togithub.com/salesforce/tough-cookie/pull/342) - Bump the dev-dependencies group with 1 update by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/344](https://togithub.com/salesforce/tough-cookie/pull/344) - Bump the dev-dependencies group with 3 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/347](https://togithub.com/salesforce/tough-cookie/pull/347) - docs: use correct memstore file link by [@&elastic#8203;alissonsleal](https://togithub.com/alissonsleal) in [https://github.com/salesforce/tough-cookie/pull/349](https://togithub.com/salesforce/tough-cookie/pull/349) - Bump the dev-dependencies group with 3 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/351](https://togithub.com/salesforce/tough-cookie/pull/351) - Bump the dev-dependencies group with 2 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/354](https://togithub.com/salesforce/tough-cookie/pull/354) - Fix expiry time not updating when cookie is updated by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/345](https://togithub.com/salesforce/tough-cookie/pull/345) - Change dependabot to monthly by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/355](https://togithub.com/salesforce/tough-cookie/pull/355) - Bump the dev-dependencies group with 5 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/358](https://togithub.com/salesforce/tough-cookie/pull/358) - Avoid `void` by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/331](https://togithub.com/salesforce/tough-cookie/pull/331) - Replace `psl` with `tldts` by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/346](https://togithub.com/salesforce/tough-cookie/pull/346) - Bump the production-dependencies group with 1 update by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/362](https://togithub.com/salesforce/tough-cookie/pull/362) - Bump the dev-dependencies group with 4 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/363](https://togithub.com/salesforce/tough-cookie/pull/363) - docs: fix JSON.serialize -> JSON.stringify by [@&elastic#8203;zavan](https://togithub.com/zavan) in [https://github.com/salesforce/tough-cookie/pull/361](https://togithub.com/salesforce/tough-cookie/pull/361) - Remove workarounds for `util` in non-node environments by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/359](https://togithub.com/salesforce/tough-cookie/pull/359) - Accept URL parameter in `getCookies` and `setCookie` by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/364](https://togithub.com/salesforce/tough-cookie/pull/364) - Remove community cookie store links by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/367](https://togithub.com/salesforce/tough-cookie/pull/367) - Handle unlikely edge case in unimportant util by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/366](https://togithub.com/salesforce/tough-cookie/pull/366) - Fix allow listed `files` for what to include in npm package by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/368](https://togithub.com/salesforce/tough-cookie/pull/368) - fix [#&elastic#8203;256](https://togithub.com/salesforce/tough-cookie/issues/256) by [@&elastic#8203;hrueger](https://togithub.com/hrueger) in [https://github.com/salesforce/tough-cookie/pull/297](https://togithub.com/salesforce/tough-cookie/pull/297) - Preparing for release 5.0.0-rc.1 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/369](https://togithub.com/salesforce/tough-cookie/pull/369) - Bump [@&elastic#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin) from 6.20.0 to 7.0.0 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/373](https://togithub.com/salesforce/tough-cookie/pull/373) - Bump the production-dependencies group with 1 update by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/370](https://togithub.com/salesforce/tough-cookie/pull/370) - Fixes eslint plugin dev upgrades by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/375](https://togithub.com/salesforce/tough-cookie/pull/375) - restore `parse` export that was accidentally removed by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/376](https://togithub.com/salesforce/tough-cookie/pull/376) - Clean up cookie creation by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/381](https://togithub.com/salesforce/tough-cookie/pull/381) - Enforce explicit function return type by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/383](https://togithub.com/salesforce/tough-cookie/pull/383) - patch removed util methods for vows by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/389](https://togithub.com/salesforce/tough-cookie/pull/389) - clean up usage of null/undefined by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/380](https://togithub.com/salesforce/tough-cookie/pull/380) - Bump the dev-dependencies group with 2 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/404](https://togithub.com/salesforce/tough-cookie/pull/404) - Bump the production-dependencies group with 1 update by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/403](https://togithub.com/salesforce/tough-cookie/pull/403) - Remove `@types/psl` from dev dependencies by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/406](https://togithub.com/salesforce/tough-cookie/pull/406) - Bump tldts from 6.1.16 to 6.1.18 in the production-dependencies group by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/411](https://togithub.com/salesforce/tough-cookie/pull/411) - Bump the dev-dependencies group with 2 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/412](https://togithub.com/salesforce/tough-cookie/pull/412) - Bump ejs from 3.1.9 to 3.1.10 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/413](https://togithub.com/salesforce/tough-cookie/pull/413) - Update v5 docs by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/384](https://togithub.com/salesforce/tough-cookie/pull/384) - Enable strict type checked rules by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/392](https://togithub.com/salesforce/tough-cookie/pull/392) - Preparing for release 5.0.0-rc.2 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/414](https://togithub.com/salesforce/tough-cookie/pull/414) - Bump the dev-dependencies group with 4 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/417](https://togithub.com/salesforce/tough-cookie/pull/417) - Bump [@&elastic#8203;eslint/js](https://togithub.com/eslint/js) from 8.57.0 to 9.4.0 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/419](https://togithub.com/salesforce/tough-cookie/pull/419) - Bump tldts from 6.1.18 to 6.1.24 in the production-dependencies group across 1 directory by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/420](https://togithub.com/salesforce/tough-cookie/pull/420) - chore: update deps by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/421](https://togithub.com/salesforce/tough-cookie/pull/421) - Use latest TypeScript version by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/423](https://togithub.com/salesforce/tough-cookie/pull/423) - Update contributors by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/425](https://togithub.com/salesforce/tough-cookie/pull/425) - Bump tldts from 6.1.28 to 6.1.30 in the production-dependencies group by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/426](https://togithub.com/salesforce/tough-cookie/pull/426) - Bump the dev-dependencies group with 4 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/427](https://togithub.com/salesforce/tough-cookie/pull/427) - Fix validation errors not calling callbacks by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/424](https://togithub.com/salesforce/tough-cookie/pull/424) - Preparing for release 5.0.0-rc.3 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/430](https://togithub.com/salesforce/tough-cookie/pull/430) - Remove url-parse and punycode by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/429](https://togithub.com/salesforce/tough-cookie/pull/429) - Checks structure instead of instanceof for URL test by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/431](https://togithub.com/salesforce/tough-cookie/pull/431) - pre-release cleanup by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/428](https://togithub.com/salesforce/tough-cookie/pull/428) - Preparing for release 5.0.0-rc.4 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/432](https://togithub.com/salesforce/tough-cookie/pull/432) - use `domainToASCII(str)` instead of `new URL(str).hostName` by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/433](https://togithub.com/salesforce/tough-cookie/pull/433) - Bump tldts from 6.1.32 to 6.1.37 in the production-dependencies group by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/436](https://togithub.com/salesforce/tough-cookie/pull/436) - Bump the dev-dependencies group across 1 directory with 6 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/439](https://togithub.com/salesforce/tough-cookie/pull/439) - Bump tldts from 6.1.37 to 6.1.41 in the production-dependencies group by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/443](https://togithub.com/salesforce/tough-cookie/pull/443) - Bump the dev-dependencies group with 6 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/444](https://togithub.com/salesforce/tough-cookie/pull/444) - upgrade typescript-eslint to 8.0.1 by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/440](https://togithub.com/salesforce/tough-cookie/pull/440) - Bump the dev-dependencies group with 2 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/448](https://togithub.com/salesforce/tough-cookie/pull/448) - Bump eslint from 8.57.0 to 9.9.1 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/449](https://togithub.com/salesforce/tough-cookie/pull/449) - Prepare v5 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/451](https://togithub.com/salesforce/tough-cookie/pull/451) #### New Contributors - [@&elastic#8203;alissonsleal](https://togithub.com/alissonsleal) made their first contribution in [https://github.com/salesforce/tough-cookie/pull/349](https://togithub.com/salesforce/tough-cookie/pull/349) - [@&elastic#8203;zavan](https://togithub.com/zavan) made their first contribution in [https://github.com/salesforce/tough-cookie/pull/361](https://togithub.com/salesforce/tough-cookie/pull/361) - [@&elastic#8203;hrueger](https://togithub.com/hrueger) made their first contribution in [https://github.com/salesforce/tough-cookie/pull/297](https://togithub.com/salesforce/tough-cookie/pull/297) **Full Changelog**: salesforce/tough-cookie@v4.1.3...v5.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJUZWFtOlNlY3VyaXR5IiwiYmFja3BvcnQ6YWxsLW9wZW4iLCJyZWxlYXNlX25vdGU6c2tpcCJdfQ==--> Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com> (cherry picked from commit f712e4a)
kibanamachine
referenced
this pull request
in kibanamachine/kibana
Sep 18, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [tough-cookie](https://togithub.com/salesforce/tough-cookie) | devDependencies | major | [`^4.1.4` -> `^5.0.0`](https://renovatebot.com/diffs/npm/tough-cookie/4.1.4/5.0.0) | --- ### Release Notes <details> <summary>salesforce/tough-cookie (tough-cookie)</summary> ### [`v5.0.0`](https://togithub.com/salesforce/tough-cookie/releases/tag/v5.0.0) [Compare Source](https://togithub.com/salesforce/tough-cookie/compare/v4.1.4...v5.0.0) #### Summary ##### Breaking Changes - We've migrated the project to TypeScript! First-party types are now available. - The minimum supported version of node is v18. - We no longer provide official support for non-node enviroments. ##### API Changes - We've standardized most of our exposed interfaces to accept both `null` and `undefined` and return only `undefined`. - `getCookie` and `getCookies` now accept a `string` or `URL` as a parameter. - We've removed the `inspect` function in favor of node's `util.inspect.custom` symbol. Cookies may appear different when logged in non-node environments. ##### Other Changes - Fixed the expiry time not updating when a cookie is updating. - Fixed validation errors not getting called in some callbacks. - [New documentation](https://togithub.com/salesforce/tough-cookie/blob/v5.0.0/api/docs/tough-cookie.md) that is always kept up to date! - Performance improvements. #### What's Changed - Typescript support by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/264](https://togithub.com/salesforce/tough-cookie/pull/264) - \[v5] Update config by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/269](https://togithub.com/salesforce/tough-cookie/pull/269) - Fix prettier in eslint config by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/274](https://togithub.com/salesforce/tough-cookie/pull/274) - Updated dev tooling by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/271](https://togithub.com/salesforce/tough-cookie/pull/271) - Port 283 fix to v5 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/287](https://togithub.com/salesforce/tough-cookie/pull/287) - Remove some [@&elastic#8203;ts-ignore](https://togithub.com/ts-ignore) directives. by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/288](https://togithub.com/salesforce/tough-cookie/pull/288) - Clean up validate function. by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/275](https://togithub.com/salesforce/tough-cookie/pull/275) - Changes to support full eslint rule configurations by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/289](https://togithub.com/salesforce/tough-cookie/pull/289) - Split giant cookie.ts into multiple files. by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/296](https://togithub.com/salesforce/tough-cookie/pull/296) - Merge branch 'master' into v5 by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/300](https://togithub.com/salesforce/tough-cookie/pull/300) - Merge `v5` into `master` by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/303](https://togithub.com/salesforce/tough-cookie/pull/303) - Preparing for release `5.0.0-rc.0` by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/304](https://togithub.com/salesforce/tough-cookie/pull/304) - Bump [@&elastic#8203;babel/traverse](https://togithub.com/babel/traverse) from 7.21.3 to 7.23.2 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/305](https://togithub.com/salesforce/tough-cookie/pull/305) - Configure dependabot and codeowners by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/306](https://togithub.com/salesforce/tough-cookie/pull/306) - Bump [@&elastic#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) from 5.58.0 to 5.62.0 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/310](https://togithub.com/salesforce/tough-cookie/pull/310) - Bump eslint-config-prettier from 8.8.0 to 9.0.0 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/311](https://togithub.com/salesforce/tough-cookie/pull/311) - Bump async from 2.6.4 to 3.2.4 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/313](https://togithub.com/salesforce/tough-cookie/pull/313) - Avoid using `arguments` by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/316](https://togithub.com/salesforce/tough-cookie/pull/316) - Configure dependabot to ignore [@&elastic#8203;types/node](https://togithub.com/types/node). by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/319](https://togithub.com/salesforce/tough-cookie/pull/319) - Bump dependencies. by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/323](https://togithub.com/salesforce/tough-cookie/pull/323) - Bump the dev-dependencies group with 6 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/342](https://togithub.com/salesforce/tough-cookie/pull/342) - Bump the dev-dependencies group with 1 update by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/344](https://togithub.com/salesforce/tough-cookie/pull/344) - Bump the dev-dependencies group with 3 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/347](https://togithub.com/salesforce/tough-cookie/pull/347) - docs: use correct memstore file link by [@&elastic#8203;alissonsleal](https://togithub.com/alissonsleal) in [https://github.com/salesforce/tough-cookie/pull/349](https://togithub.com/salesforce/tough-cookie/pull/349) - Bump the dev-dependencies group with 3 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/351](https://togithub.com/salesforce/tough-cookie/pull/351) - Bump the dev-dependencies group with 2 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/354](https://togithub.com/salesforce/tough-cookie/pull/354) - Fix expiry time not updating when cookie is updated by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/345](https://togithub.com/salesforce/tough-cookie/pull/345) - Change dependabot to monthly by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/355](https://togithub.com/salesforce/tough-cookie/pull/355) - Bump the dev-dependencies group with 5 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/358](https://togithub.com/salesforce/tough-cookie/pull/358) - Avoid `void` by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/331](https://togithub.com/salesforce/tough-cookie/pull/331) - Replace `psl` with `tldts` by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/346](https://togithub.com/salesforce/tough-cookie/pull/346) - Bump the production-dependencies group with 1 update by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/362](https://togithub.com/salesforce/tough-cookie/pull/362) - Bump the dev-dependencies group with 4 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/363](https://togithub.com/salesforce/tough-cookie/pull/363) - docs: fix JSON.serialize -> JSON.stringify by [@&elastic#8203;zavan](https://togithub.com/zavan) in [https://github.com/salesforce/tough-cookie/pull/361](https://togithub.com/salesforce/tough-cookie/pull/361) - Remove workarounds for `util` in non-node environments by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/359](https://togithub.com/salesforce/tough-cookie/pull/359) - Accept URL parameter in `getCookies` and `setCookie` by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/364](https://togithub.com/salesforce/tough-cookie/pull/364) - Remove community cookie store links by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/367](https://togithub.com/salesforce/tough-cookie/pull/367) - Handle unlikely edge case in unimportant util by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/366](https://togithub.com/salesforce/tough-cookie/pull/366) - Fix allow listed `files` for what to include in npm package by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/368](https://togithub.com/salesforce/tough-cookie/pull/368) - fix [#&elastic#8203;256](https://togithub.com/salesforce/tough-cookie/issues/256) by [@&elastic#8203;hrueger](https://togithub.com/hrueger) in [https://github.com/salesforce/tough-cookie/pull/297](https://togithub.com/salesforce/tough-cookie/pull/297) - Preparing for release 5.0.0-rc.1 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/369](https://togithub.com/salesforce/tough-cookie/pull/369) - Bump [@&elastic#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin) from 6.20.0 to 7.0.0 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/373](https://togithub.com/salesforce/tough-cookie/pull/373) - Bump the production-dependencies group with 1 update by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/370](https://togithub.com/salesforce/tough-cookie/pull/370) - Fixes eslint plugin dev upgrades by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/375](https://togithub.com/salesforce/tough-cookie/pull/375) - restore `parse` export that was accidentally removed by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/376](https://togithub.com/salesforce/tough-cookie/pull/376) - Clean up cookie creation by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/381](https://togithub.com/salesforce/tough-cookie/pull/381) - Enforce explicit function return type by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/383](https://togithub.com/salesforce/tough-cookie/pull/383) - patch removed util methods for vows by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/389](https://togithub.com/salesforce/tough-cookie/pull/389) - clean up usage of null/undefined by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/380](https://togithub.com/salesforce/tough-cookie/pull/380) - Bump the dev-dependencies group with 2 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/404](https://togithub.com/salesforce/tough-cookie/pull/404) - Bump the production-dependencies group with 1 update by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/403](https://togithub.com/salesforce/tough-cookie/pull/403) - Remove `@types/psl` from dev dependencies by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/406](https://togithub.com/salesforce/tough-cookie/pull/406) - Bump tldts from 6.1.16 to 6.1.18 in the production-dependencies group by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/411](https://togithub.com/salesforce/tough-cookie/pull/411) - Bump the dev-dependencies group with 2 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/412](https://togithub.com/salesforce/tough-cookie/pull/412) - Bump ejs from 3.1.9 to 3.1.10 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/413](https://togithub.com/salesforce/tough-cookie/pull/413) - Update v5 docs by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/384](https://togithub.com/salesforce/tough-cookie/pull/384) - Enable strict type checked rules by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/392](https://togithub.com/salesforce/tough-cookie/pull/392) - Preparing for release 5.0.0-rc.2 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/414](https://togithub.com/salesforce/tough-cookie/pull/414) - Bump the dev-dependencies group with 4 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/417](https://togithub.com/salesforce/tough-cookie/pull/417) - Bump [@&elastic#8203;eslint/js](https://togithub.com/eslint/js) from 8.57.0 to 9.4.0 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/419](https://togithub.com/salesforce/tough-cookie/pull/419) - Bump tldts from 6.1.18 to 6.1.24 in the production-dependencies group across 1 directory by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/420](https://togithub.com/salesforce/tough-cookie/pull/420) - chore: update deps by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/421](https://togithub.com/salesforce/tough-cookie/pull/421) - Use latest TypeScript version by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/423](https://togithub.com/salesforce/tough-cookie/pull/423) - Update contributors by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/425](https://togithub.com/salesforce/tough-cookie/pull/425) - Bump tldts from 6.1.28 to 6.1.30 in the production-dependencies group by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/426](https://togithub.com/salesforce/tough-cookie/pull/426) - Bump the dev-dependencies group with 4 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/427](https://togithub.com/salesforce/tough-cookie/pull/427) - Fix validation errors not calling callbacks by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/424](https://togithub.com/salesforce/tough-cookie/pull/424) - Preparing for release 5.0.0-rc.3 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/430](https://togithub.com/salesforce/tough-cookie/pull/430) - Remove url-parse and punycode by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/429](https://togithub.com/salesforce/tough-cookie/pull/429) - Checks structure instead of instanceof for URL test by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/431](https://togithub.com/salesforce/tough-cookie/pull/431) - pre-release cleanup by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/428](https://togithub.com/salesforce/tough-cookie/pull/428) - Preparing for release 5.0.0-rc.4 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/432](https://togithub.com/salesforce/tough-cookie/pull/432) - use `domainToASCII(str)` instead of `new URL(str).hostName` by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/433](https://togithub.com/salesforce/tough-cookie/pull/433) - Bump tldts from 6.1.32 to 6.1.37 in the production-dependencies group by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/436](https://togithub.com/salesforce/tough-cookie/pull/436) - Bump the dev-dependencies group across 1 directory with 6 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/439](https://togithub.com/salesforce/tough-cookie/pull/439) - Bump tldts from 6.1.37 to 6.1.41 in the production-dependencies group by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/443](https://togithub.com/salesforce/tough-cookie/pull/443) - Bump the dev-dependencies group with 6 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/444](https://togithub.com/salesforce/tough-cookie/pull/444) - upgrade typescript-eslint to 8.0.1 by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/440](https://togithub.com/salesforce/tough-cookie/pull/440) - Bump the dev-dependencies group with 2 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/448](https://togithub.com/salesforce/tough-cookie/pull/448) - Bump eslint from 8.57.0 to 9.9.1 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/449](https://togithub.com/salesforce/tough-cookie/pull/449) - Prepare v5 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/451](https://togithub.com/salesforce/tough-cookie/pull/451) #### New Contributors - [@&elastic#8203;alissonsleal](https://togithub.com/alissonsleal) made their first contribution in [https://github.com/salesforce/tough-cookie/pull/349](https://togithub.com/salesforce/tough-cookie/pull/349) - [@&elastic#8203;zavan](https://togithub.com/zavan) made their first contribution in [https://github.com/salesforce/tough-cookie/pull/361](https://togithub.com/salesforce/tough-cookie/pull/361) - [@&elastic#8203;hrueger](https://togithub.com/hrueger) made their first contribution in [https://github.com/salesforce/tough-cookie/pull/297](https://togithub.com/salesforce/tough-cookie/pull/297) **Full Changelog**: salesforce/tough-cookie@v4.1.3...v5.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJUZWFtOlNlY3VyaXR5IiwiYmFja3BvcnQ6YWxsLW9wZW4iLCJyZWxlYXNlX25vdGU6c2tpcCJdfQ==--> Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com> (cherry picked from commit f712e4a)
kc13greiner
referenced
this pull request
in kc13greiner/kibana
Sep 18, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [tough-cookie](https://togithub.com/salesforce/tough-cookie) | devDependencies | major | [`^4.1.4` -> `^5.0.0`](https://renovatebot.com/diffs/npm/tough-cookie/4.1.4/5.0.0) | --- ### Release Notes <details> <summary>salesforce/tough-cookie (tough-cookie)</summary> ### [`v5.0.0`](https://togithub.com/salesforce/tough-cookie/releases/tag/v5.0.0) [Compare Source](https://togithub.com/salesforce/tough-cookie/compare/v4.1.4...v5.0.0) #### Summary ##### Breaking Changes - We've migrated the project to TypeScript! First-party types are now available. - The minimum supported version of node is v18. - We no longer provide official support for non-node enviroments. ##### API Changes - We've standardized most of our exposed interfaces to accept both `null` and `undefined` and return only `undefined`. - `getCookie` and `getCookies` now accept a `string` or `URL` as a parameter. - We've removed the `inspect` function in favor of node's `util.inspect.custom` symbol. Cookies may appear different when logged in non-node environments. ##### Other Changes - Fixed the expiry time not updating when a cookie is updating. - Fixed validation errors not getting called in some callbacks. - [New documentation](https://togithub.com/salesforce/tough-cookie/blob/v5.0.0/api/docs/tough-cookie.md) that is always kept up to date! - Performance improvements. #### What's Changed - Typescript support by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/264](https://togithub.com/salesforce/tough-cookie/pull/264) - \[v5] Update config by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/269](https://togithub.com/salesforce/tough-cookie/pull/269) - Fix prettier in eslint config by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/274](https://togithub.com/salesforce/tough-cookie/pull/274) - Updated dev tooling by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/271](https://togithub.com/salesforce/tough-cookie/pull/271) - Port 283 fix to v5 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/287](https://togithub.com/salesforce/tough-cookie/pull/287) - Remove some [@&elastic#8203;ts-ignore](https://togithub.com/ts-ignore) directives. by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/288](https://togithub.com/salesforce/tough-cookie/pull/288) - Clean up validate function. by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/275](https://togithub.com/salesforce/tough-cookie/pull/275) - Changes to support full eslint rule configurations by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/289](https://togithub.com/salesforce/tough-cookie/pull/289) - Split giant cookie.ts into multiple files. by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/296](https://togithub.com/salesforce/tough-cookie/pull/296) - Merge branch 'master' into v5 by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/300](https://togithub.com/salesforce/tough-cookie/pull/300) - Merge `v5` into `master` by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/303](https://togithub.com/salesforce/tough-cookie/pull/303) - Preparing for release `5.0.0-rc.0` by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/304](https://togithub.com/salesforce/tough-cookie/pull/304) - Bump [@&elastic#8203;babel/traverse](https://togithub.com/babel/traverse) from 7.21.3 to 7.23.2 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/305](https://togithub.com/salesforce/tough-cookie/pull/305) - Configure dependabot and codeowners by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/306](https://togithub.com/salesforce/tough-cookie/pull/306) - Bump [@&elastic#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) from 5.58.0 to 5.62.0 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/310](https://togithub.com/salesforce/tough-cookie/pull/310) - Bump eslint-config-prettier from 8.8.0 to 9.0.0 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/311](https://togithub.com/salesforce/tough-cookie/pull/311) - Bump async from 2.6.4 to 3.2.4 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/313](https://togithub.com/salesforce/tough-cookie/pull/313) - Avoid using `arguments` by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/316](https://togithub.com/salesforce/tough-cookie/pull/316) - Configure dependabot to ignore [@&elastic#8203;types/node](https://togithub.com/types/node). by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/319](https://togithub.com/salesforce/tough-cookie/pull/319) - Bump dependencies. by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/323](https://togithub.com/salesforce/tough-cookie/pull/323) - Bump the dev-dependencies group with 6 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/342](https://togithub.com/salesforce/tough-cookie/pull/342) - Bump the dev-dependencies group with 1 update by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/344](https://togithub.com/salesforce/tough-cookie/pull/344) - Bump the dev-dependencies group with 3 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/347](https://togithub.com/salesforce/tough-cookie/pull/347) - docs: use correct memstore file link by [@&elastic#8203;alissonsleal](https://togithub.com/alissonsleal) in [https://github.com/salesforce/tough-cookie/pull/349](https://togithub.com/salesforce/tough-cookie/pull/349) - Bump the dev-dependencies group with 3 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/351](https://togithub.com/salesforce/tough-cookie/pull/351) - Bump the dev-dependencies group with 2 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/354](https://togithub.com/salesforce/tough-cookie/pull/354) - Fix expiry time not updating when cookie is updated by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/345](https://togithub.com/salesforce/tough-cookie/pull/345) - Change dependabot to monthly by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/355](https://togithub.com/salesforce/tough-cookie/pull/355) - Bump the dev-dependencies group with 5 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/358](https://togithub.com/salesforce/tough-cookie/pull/358) - Avoid `void` by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/331](https://togithub.com/salesforce/tough-cookie/pull/331) - Replace `psl` with `tldts` by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/346](https://togithub.com/salesforce/tough-cookie/pull/346) - Bump the production-dependencies group with 1 update by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/362](https://togithub.com/salesforce/tough-cookie/pull/362) - Bump the dev-dependencies group with 4 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/363](https://togithub.com/salesforce/tough-cookie/pull/363) - docs: fix JSON.serialize -> JSON.stringify by [@&elastic#8203;zavan](https://togithub.com/zavan) in [https://github.com/salesforce/tough-cookie/pull/361](https://togithub.com/salesforce/tough-cookie/pull/361) - Remove workarounds for `util` in non-node environments by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/359](https://togithub.com/salesforce/tough-cookie/pull/359) - Accept URL parameter in `getCookies` and `setCookie` by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/364](https://togithub.com/salesforce/tough-cookie/pull/364) - Remove community cookie store links by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/367](https://togithub.com/salesforce/tough-cookie/pull/367) - Handle unlikely edge case in unimportant util by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/366](https://togithub.com/salesforce/tough-cookie/pull/366) - Fix allow listed `files` for what to include in npm package by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/368](https://togithub.com/salesforce/tough-cookie/pull/368) - fix [#&elastic#8203;256](https://togithub.com/salesforce/tough-cookie/issues/256) by [@&elastic#8203;hrueger](https://togithub.com/hrueger) in [https://github.com/salesforce/tough-cookie/pull/297](https://togithub.com/salesforce/tough-cookie/pull/297) - Preparing for release 5.0.0-rc.1 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/369](https://togithub.com/salesforce/tough-cookie/pull/369) - Bump [@&elastic#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin) from 6.20.0 to 7.0.0 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/373](https://togithub.com/salesforce/tough-cookie/pull/373) - Bump the production-dependencies group with 1 update by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/370](https://togithub.com/salesforce/tough-cookie/pull/370) - Fixes eslint plugin dev upgrades by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/375](https://togithub.com/salesforce/tough-cookie/pull/375) - restore `parse` export that was accidentally removed by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/376](https://togithub.com/salesforce/tough-cookie/pull/376) - Clean up cookie creation by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/381](https://togithub.com/salesforce/tough-cookie/pull/381) - Enforce explicit function return type by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/383](https://togithub.com/salesforce/tough-cookie/pull/383) - patch removed util methods for vows by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/389](https://togithub.com/salesforce/tough-cookie/pull/389) - clean up usage of null/undefined by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/380](https://togithub.com/salesforce/tough-cookie/pull/380) - Bump the dev-dependencies group with 2 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/404](https://togithub.com/salesforce/tough-cookie/pull/404) - Bump the production-dependencies group with 1 update by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/403](https://togithub.com/salesforce/tough-cookie/pull/403) - Remove `@types/psl` from dev dependencies by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/406](https://togithub.com/salesforce/tough-cookie/pull/406) - Bump tldts from 6.1.16 to 6.1.18 in the production-dependencies group by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/411](https://togithub.com/salesforce/tough-cookie/pull/411) - Bump the dev-dependencies group with 2 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/412](https://togithub.com/salesforce/tough-cookie/pull/412) - Bump ejs from 3.1.9 to 3.1.10 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/413](https://togithub.com/salesforce/tough-cookie/pull/413) - Update v5 docs by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/384](https://togithub.com/salesforce/tough-cookie/pull/384) - Enable strict type checked rules by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/392](https://togithub.com/salesforce/tough-cookie/pull/392) - Preparing for release 5.0.0-rc.2 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/414](https://togithub.com/salesforce/tough-cookie/pull/414) - Bump the dev-dependencies group with 4 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/417](https://togithub.com/salesforce/tough-cookie/pull/417) - Bump [@&elastic#8203;eslint/js](https://togithub.com/eslint/js) from 8.57.0 to 9.4.0 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/419](https://togithub.com/salesforce/tough-cookie/pull/419) - Bump tldts from 6.1.18 to 6.1.24 in the production-dependencies group across 1 directory by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/420](https://togithub.com/salesforce/tough-cookie/pull/420) - chore: update deps by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/421](https://togithub.com/salesforce/tough-cookie/pull/421) - Use latest TypeScript version by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/423](https://togithub.com/salesforce/tough-cookie/pull/423) - Update contributors by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/425](https://togithub.com/salesforce/tough-cookie/pull/425) - Bump tldts from 6.1.28 to 6.1.30 in the production-dependencies group by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/426](https://togithub.com/salesforce/tough-cookie/pull/426) - Bump the dev-dependencies group with 4 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/427](https://togithub.com/salesforce/tough-cookie/pull/427) - Fix validation errors not calling callbacks by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/424](https://togithub.com/salesforce/tough-cookie/pull/424) - Preparing for release 5.0.0-rc.3 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/430](https://togithub.com/salesforce/tough-cookie/pull/430) - Remove url-parse and punycode by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/429](https://togithub.com/salesforce/tough-cookie/pull/429) - Checks structure instead of instanceof for URL test by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/431](https://togithub.com/salesforce/tough-cookie/pull/431) - pre-release cleanup by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/428](https://togithub.com/salesforce/tough-cookie/pull/428) - Preparing for release 5.0.0-rc.4 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/432](https://togithub.com/salesforce/tough-cookie/pull/432) - use `domainToASCII(str)` instead of `new URL(str).hostName` by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/433](https://togithub.com/salesforce/tough-cookie/pull/433) - Bump tldts from 6.1.32 to 6.1.37 in the production-dependencies group by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/436](https://togithub.com/salesforce/tough-cookie/pull/436) - Bump the dev-dependencies group across 1 directory with 6 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/439](https://togithub.com/salesforce/tough-cookie/pull/439) - Bump tldts from 6.1.37 to 6.1.41 in the production-dependencies group by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/443](https://togithub.com/salesforce/tough-cookie/pull/443) - Bump the dev-dependencies group with 6 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/444](https://togithub.com/salesforce/tough-cookie/pull/444) - upgrade typescript-eslint to 8.0.1 by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [https://github.com/salesforce/tough-cookie/pull/440](https://togithub.com/salesforce/tough-cookie/pull/440) - Bump the dev-dependencies group with 2 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/448](https://togithub.com/salesforce/tough-cookie/pull/448) - Bump eslint from 8.57.0 to 9.9.1 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/salesforce/tough-cookie/pull/449](https://togithub.com/salesforce/tough-cookie/pull/449) - Prepare v5 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [https://github.com/salesforce/tough-cookie/pull/451](https://togithub.com/salesforce/tough-cookie/pull/451) #### New Contributors - [@&elastic#8203;alissonsleal](https://togithub.com/alissonsleal) made their first contribution in [https://github.com/salesforce/tough-cookie/pull/349](https://togithub.com/salesforce/tough-cookie/pull/349) - [@&elastic#8203;zavan](https://togithub.com/zavan) made their first contribution in [https://github.com/salesforce/tough-cookie/pull/361](https://togithub.com/salesforce/tough-cookie/pull/361) - [@&elastic#8203;hrueger](https://togithub.com/hrueger) made their first contribution in [https://github.com/salesforce/tough-cookie/pull/297](https://togithub.com/salesforce/tough-cookie/pull/297) **Full Changelog**: salesforce/tough-cookie@v4.1.3...v5.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJUZWFtOlNlY3VyaXR5IiwiYmFja3BvcnQ6YWxsLW9wZW4iLCJyZWxlYXNlX25vdGU6c2tpcCJdfQ==--> Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com> (cherry picked from commit f712e4a) # Conflicts: # package.json # yarn.lock
kibanamachine
referenced
this pull request
in elastic/kibana
Sep 18, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Update dependency tough-cookie to v5 (main) (#193107)](https://github.com/elastic/kibana/pull/193107) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"elastic-renovate-prod[bot]","email":"174716857+elastic-renovate-prod[bot]@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-09-18T12:32:42Z","message":"Update dependency tough-cookie to v5 (main) (#193107)\n\nThis PR contains the following updates:\r\n\r\n| Package | Type | Update | Change |\r\n|---|---|---|---|\r\n| [tough-cookie](https://togithub.com/salesforce/tough-cookie) |\r\ndevDependencies | major | [`^4.1.4` ->\r\n`^5.0.0`](https://renovatebot.com/diffs/npm/tough-cookie/4.1.4/5.0.0) |\r\n\r\n---\r\n\r\n### Release Notes\r\n\r\n<details>\r\n<summary>salesforce/tough-cookie (tough-cookie)</summary>\r\n\r\n###\r\n[`v5.0.0`](https://togithub.com/salesforce/tough-cookie/releases/tag/v5.0.0)\r\n\r\n[Compare\r\nSource](https://togithub.com/salesforce/tough-cookie/compare/v4.1.4...v5.0.0)\r\n\r\n#### Summary\r\n\r\n##### Breaking Changes\r\n\r\n- We've migrated the project to TypeScript! First-party types are now\r\navailable.\r\n- The minimum supported version of node is v18.\r\n- We no longer provide official support for non-node enviroments.\r\n\r\n##### API Changes\r\n\r\n- We've standardized most of our exposed interfaces to accept both\r\n`null` and `undefined` and return only `undefined`.\r\n- `getCookie` and `getCookies` now accept a `string` or `URL` as a\r\nparameter.\r\n- We've removed the `inspect` function in favor of node's\r\n`util.inspect.custom` symbol. Cookies may appear different when logged\r\nin non-node environments.\r\n\r\n##### Other Changes\r\n\r\n- Fixed the expiry time not updating when a cookie is updating.\r\n- Fixed validation errors not getting called in some callbacks.\r\n- [New\r\ndocumentation](https://togithub.com/salesforce/tough-cookie/blob/v5.0.0/api/docs/tough-cookie.md)\r\nthat is always kept up to date!\r\n- Performance improvements.\r\n\r\n#### What's Changed\r\n\r\n- Typescript support by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/264](https://togithub.com/salesforce/tough-cookie/pull/264)\r\n- \\[v5] Update config by [@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/269](https://togithub.com/salesforce/tough-cookie/pull/269)\r\n- Fix prettier in eslint config by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/274](https://togithub.com/salesforce/tough-cookie/pull/274)\r\n- Updated dev tooling by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/271](https://togithub.com/salesforce/tough-cookie/pull/271)\r\n- Port 283 fix to v5 by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/287](https://togithub.com/salesforce/tough-cookie/pull/287)\r\n- Remove some [@​ts-ignore](https://togithub.com/ts-ignore)\r\ndirectives. by [@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/288](https://togithub.com/salesforce/tough-cookie/pull/288)\r\n- Clean up validate function. by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/275](https://togithub.com/salesforce/tough-cookie/pull/275)\r\n- Changes to support full eslint rule configurations by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/289](https://togithub.com/salesforce/tough-cookie/pull/289)\r\n- Split giant cookie.ts into multiple files. by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/296](https://togithub.com/salesforce/tough-cookie/pull/296)\r\n- Merge branch 'master' into v5 by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/300](https://togithub.com/salesforce/tough-cookie/pull/300)\r\n- Merge `v5` into `master` by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/303](https://togithub.com/salesforce/tough-cookie/pull/303)\r\n- Preparing for release `5.0.0-rc.0` by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/304](https://togithub.com/salesforce/tough-cookie/pull/304)\r\n- Bump [@​babel/traverse](https://togithub.com/babel/traverse)\r\nfrom 7.21.3 to 7.23.2 by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/305](https://togithub.com/salesforce/tough-cookie/pull/305)\r\n- Configure dependabot and codeowners by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/306](https://togithub.com/salesforce/tough-cookie/pull/306)\r\n- Bump\r\n[@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)\r\nfrom 5.58.0 to 5.62.0 by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/310](https://togithub.com/salesforce/tough-cookie/pull/310)\r\n- Bump eslint-config-prettier from 8.8.0 to 9.0.0 by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/311](https://togithub.com/salesforce/tough-cookie/pull/311)\r\n- Bump async from 2.6.4 to 3.2.4 by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/313](https://togithub.com/salesforce/tough-cookie/pull/313)\r\n- Avoid using `arguments` by [@​wjhsf](https://togithub.com/wjhsf)\r\nin\r\n[https://github.com/salesforce/tough-cookie/pull/316](https://togithub.com/salesforce/tough-cookie/pull/316)\r\n- Configure dependabot to ignore\r\n[@​types/node](https://togithub.com/types/node). by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/319](https://togithub.com/salesforce/tough-cookie/pull/319)\r\n- Bump dependencies. by [@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/323](https://togithub.com/salesforce/tough-cookie/pull/323)\r\n- Bump the dev-dependencies group with 6 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/342](https://togithub.com/salesforce/tough-cookie/pull/342)\r\n- Bump the dev-dependencies group with 1 update by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/344](https://togithub.com/salesforce/tough-cookie/pull/344)\r\n- Bump the dev-dependencies group with 3 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/347](https://togithub.com/salesforce/tough-cookie/pull/347)\r\n- docs: use correct memstore file link by\r\n[@​alissonsleal](https://togithub.com/alissonsleal) in\r\n[https://github.com/salesforce/tough-cookie/pull/349](https://togithub.com/salesforce/tough-cookie/pull/349)\r\n- Bump the dev-dependencies group with 3 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/351](https://togithub.com/salesforce/tough-cookie/pull/351)\r\n- Bump the dev-dependencies group with 2 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/354](https://togithub.com/salesforce/tough-cookie/pull/354)\r\n- Fix expiry time not updating when cookie is updated by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/345](https://togithub.com/salesforce/tough-cookie/pull/345)\r\n- Change dependabot to monthly by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/355](https://togithub.com/salesforce/tough-cookie/pull/355)\r\n- Bump the dev-dependencies group with 5 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/358](https://togithub.com/salesforce/tough-cookie/pull/358)\r\n- Avoid `void` by [@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/331](https://togithub.com/salesforce/tough-cookie/pull/331)\r\n- Replace `psl` with `tldts` by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/346](https://togithub.com/salesforce/tough-cookie/pull/346)\r\n- Bump the production-dependencies group with 1 update by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/362](https://togithub.com/salesforce/tough-cookie/pull/362)\r\n- Bump the dev-dependencies group with 4 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/363](https://togithub.com/salesforce/tough-cookie/pull/363)\r\n- docs: fix JSON.serialize -> JSON.stringify by\r\n[@​zavan](https://togithub.com/zavan) in\r\n[https://github.com/salesforce/tough-cookie/pull/361](https://togithub.com/salesforce/tough-cookie/pull/361)\r\n- Remove workarounds for `util` in non-node environments by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/359](https://togithub.com/salesforce/tough-cookie/pull/359)\r\n- Accept URL parameter in `getCookies` and `setCookie` by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/364](https://togithub.com/salesforce/tough-cookie/pull/364)\r\n- Remove community cookie store links by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/367](https://togithub.com/salesforce/tough-cookie/pull/367)\r\n- Handle unlikely edge case in unimportant util by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/366](https://togithub.com/salesforce/tough-cookie/pull/366)\r\n- Fix allow listed `files` for what to include in npm package by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/368](https://togithub.com/salesforce/tough-cookie/pull/368)\r\n- fix\r\n[#​256](https://togithub.com/salesforce/tough-cookie/issues/256)\r\nby [@​hrueger](https://togithub.com/hrueger) in\r\n[https://github.com/salesforce/tough-cookie/pull/297](https://togithub.com/salesforce/tough-cookie/pull/297)\r\n- Preparing for release 5.0.0-rc.1 by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/369](https://togithub.com/salesforce/tough-cookie/pull/369)\r\n- Bump\r\n[@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)\r\nfrom 6.20.0 to 7.0.0 by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/373](https://togithub.com/salesforce/tough-cookie/pull/373)\r\n- Bump the production-dependencies group with 1 update by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/370](https://togithub.com/salesforce/tough-cookie/pull/370)\r\n- Fixes eslint plugin dev upgrades by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/375](https://togithub.com/salesforce/tough-cookie/pull/375)\r\n- restore `parse` export that was accidentally removed by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/376](https://togithub.com/salesforce/tough-cookie/pull/376)\r\n- Clean up cookie creation by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/381](https://togithub.com/salesforce/tough-cookie/pull/381)\r\n- Enforce explicit function return type by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/383](https://togithub.com/salesforce/tough-cookie/pull/383)\r\n- patch removed util methods for vows by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/389](https://togithub.com/salesforce/tough-cookie/pull/389)\r\n- clean up usage of null/undefined by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/380](https://togithub.com/salesforce/tough-cookie/pull/380)\r\n- Bump the dev-dependencies group with 2 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/404](https://togithub.com/salesforce/tough-cookie/pull/404)\r\n- Bump the production-dependencies group with 1 update by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/403](https://togithub.com/salesforce/tough-cookie/pull/403)\r\n- Remove `@types/psl` from dev dependencies by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/406](https://togithub.com/salesforce/tough-cookie/pull/406)\r\n- Bump tldts from 6.1.16 to 6.1.18 in the production-dependencies group\r\nby [@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/411](https://togithub.com/salesforce/tough-cookie/pull/411)\r\n- Bump the dev-dependencies group with 2 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/412](https://togithub.com/salesforce/tough-cookie/pull/412)\r\n- Bump ejs from 3.1.9 to 3.1.10 by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/413](https://togithub.com/salesforce/tough-cookie/pull/413)\r\n- Update v5 docs by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/384](https://togithub.com/salesforce/tough-cookie/pull/384)\r\n- Enable strict type checked rules by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/392](https://togithub.com/salesforce/tough-cookie/pull/392)\r\n- Preparing for release 5.0.0-rc.2 by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/414](https://togithub.com/salesforce/tough-cookie/pull/414)\r\n- Bump the dev-dependencies group with 4 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/417](https://togithub.com/salesforce/tough-cookie/pull/417)\r\n- Bump [@​eslint/js](https://togithub.com/eslint/js) from 8.57.0\r\nto 9.4.0 by [@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/419](https://togithub.com/salesforce/tough-cookie/pull/419)\r\n- Bump tldts from 6.1.18 to 6.1.24 in the production-dependencies group\r\nacross 1 directory by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/420](https://togithub.com/salesforce/tough-cookie/pull/420)\r\n- chore: update deps by [@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/421](https://togithub.com/salesforce/tough-cookie/pull/421)\r\n- Use latest TypeScript version by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/423](https://togithub.com/salesforce/tough-cookie/pull/423)\r\n- Update contributors by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/425](https://togithub.com/salesforce/tough-cookie/pull/425)\r\n- Bump tldts from 6.1.28 to 6.1.30 in the production-dependencies group\r\nby [@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/426](https://togithub.com/salesforce/tough-cookie/pull/426)\r\n- Bump the dev-dependencies group with 4 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/427](https://togithub.com/salesforce/tough-cookie/pull/427)\r\n- Fix validation errors not calling callbacks by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/424](https://togithub.com/salesforce/tough-cookie/pull/424)\r\n- Preparing for release 5.0.0-rc.3 by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/430](https://togithub.com/salesforce/tough-cookie/pull/430)\r\n- Remove url-parse and punycode by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/429](https://togithub.com/salesforce/tough-cookie/pull/429)\r\n- Checks structure instead of instanceof for URL test by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/431](https://togithub.com/salesforce/tough-cookie/pull/431)\r\n- pre-release cleanup by [@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/428](https://togithub.com/salesforce/tough-cookie/pull/428)\r\n- Preparing for release 5.0.0-rc.4 by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/432](https://togithub.com/salesforce/tough-cookie/pull/432)\r\n- use `domainToASCII(str)` instead of `new URL(str).hostName` by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/433](https://togithub.com/salesforce/tough-cookie/pull/433)\r\n- Bump tldts from 6.1.32 to 6.1.37 in the production-dependencies group\r\nby [@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/436](https://togithub.com/salesforce/tough-cookie/pull/436)\r\n- Bump the dev-dependencies group across 1 directory with 6 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/439](https://togithub.com/salesforce/tough-cookie/pull/439)\r\n- Bump tldts from 6.1.37 to 6.1.41 in the production-dependencies group\r\nby [@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/443](https://togithub.com/salesforce/tough-cookie/pull/443)\r\n- Bump the dev-dependencies group with 6 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/444](https://togithub.com/salesforce/tough-cookie/pull/444)\r\n- upgrade typescript-eslint to 8.0.1 by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/440](https://togithub.com/salesforce/tough-cookie/pull/440)\r\n- Bump the dev-dependencies group with 2 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/448](https://togithub.com/salesforce/tough-cookie/pull/448)\r\n- Bump eslint from 8.57.0 to 9.9.1 by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/449](https://togithub.com/salesforce/tough-cookie/pull/449)\r\n- Prepare v5 by [@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/451](https://togithub.com/salesforce/tough-cookie/pull/451)\r\n\r\n#### New Contributors\r\n\r\n- [@​alissonsleal](https://togithub.com/alissonsleal) made their\r\nfirst contribution in\r\n[https://github.com/salesforce/tough-cookie/pull/349](https://togithub.com/salesforce/tough-cookie/pull/349)\r\n- [@​zavan](https://togithub.com/zavan) made their first\r\ncontribution in\r\n[https://github.com/salesforce/tough-cookie/pull/361](https://togithub.com/salesforce/tough-cookie/pull/361)\r\n- [@​hrueger](https://togithub.com/hrueger) made their first\r\ncontribution in\r\n[https://github.com/salesforce/tough-cookie/pull/297](https://togithub.com/salesforce/tough-cookie/pull/297)\r\n\r\n**Full Changelog**:\r\nhttps://github.com/salesforce/tough-cookie/compare/v4.1.3...v5.0.0\r\n\r\n</details>\r\n\r\n---\r\n\r\n### Configuration\r\n\r\n📅 **Schedule**: Branch creation - At any time (no schedule defined),\r\nAutomerge - At any time (no schedule defined).\r\n\r\n🚦 **Automerge**: Disabled by config. Please merge this manually once you\r\nare satisfied.\r\n\r\n♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the\r\nrebase/retry checkbox.\r\n\r\n🔕 **Ignore**: Close this PR and you won't be reminded about this update\r\nagain.\r\n\r\n---\r\n\r\n- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check\r\nthis box\r\n\r\n---\r\n\r\nThis PR has been generated by [Renovate\r\nBot](https://togithub.com/renovatebot/renovate).\r\n\r\n<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJUZWFtOlNlY3VyaXR5IiwiYmFja3BvcnQ6YWxsLW9wZW4iLCJyZWxlYXNlX25vdGU6c2tpcCJdfQ==-->\r\n\r\nCo-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com>","sha":"f712e4a47bb653136cc8ceefca08d3524dc00a4b","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","💝community","v9.0.0","backport:all-open"],"title":"Update dependency tough-cookie to v5 (main)","number":193107,"url":"https://github.com/elastic/kibana/pull/193107","mergeCommit":{"message":"Update dependency tough-cookie to v5 (main) (#193107)\n\nThis PR contains the following updates:\r\n\r\n| Package | Type | Update | Change |\r\n|---|---|---|---|\r\n| [tough-cookie](https://togithub.com/salesforce/tough-cookie) |\r\ndevDependencies | major | [`^4.1.4` ->\r\n`^5.0.0`](https://renovatebot.com/diffs/npm/tough-cookie/4.1.4/5.0.0) |\r\n\r\n---\r\n\r\n### Release Notes\r\n\r\n<details>\r\n<summary>salesforce/tough-cookie (tough-cookie)</summary>\r\n\r\n###\r\n[`v5.0.0`](https://togithub.com/salesforce/tough-cookie/releases/tag/v5.0.0)\r\n\r\n[Compare\r\nSource](https://togithub.com/salesforce/tough-cookie/compare/v4.1.4...v5.0.0)\r\n\r\n#### Summary\r\n\r\n##### Breaking Changes\r\n\r\n- We've migrated the project to TypeScript! First-party types are now\r\navailable.\r\n- The minimum supported version of node is v18.\r\n- We no longer provide official support for non-node enviroments.\r\n\r\n##### API Changes\r\n\r\n- We've standardized most of our exposed interfaces to accept both\r\n`null` and `undefined` and return only `undefined`.\r\n- `getCookie` and `getCookies` now accept a `string` or `URL` as a\r\nparameter.\r\n- We've removed the `inspect` function in favor of node's\r\n`util.inspect.custom` symbol. Cookies may appear different when logged\r\nin non-node environments.\r\n\r\n##### Other Changes\r\n\r\n- Fixed the expiry time not updating when a cookie is updating.\r\n- Fixed validation errors not getting called in some callbacks.\r\n- [New\r\ndocumentation](https://togithub.com/salesforce/tough-cookie/blob/v5.0.0/api/docs/tough-cookie.md)\r\nthat is always kept up to date!\r\n- Performance improvements.\r\n\r\n#### What's Changed\r\n\r\n- Typescript support by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/264](https://togithub.com/salesforce/tough-cookie/pull/264)\r\n- \\[v5] Update config by [@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/269](https://togithub.com/salesforce/tough-cookie/pull/269)\r\n- Fix prettier in eslint config by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/274](https://togithub.com/salesforce/tough-cookie/pull/274)\r\n- Updated dev tooling by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/271](https://togithub.com/salesforce/tough-cookie/pull/271)\r\n- Port 283 fix to v5 by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/287](https://togithub.com/salesforce/tough-cookie/pull/287)\r\n- Remove some [@​ts-ignore](https://togithub.com/ts-ignore)\r\ndirectives. by [@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/288](https://togithub.com/salesforce/tough-cookie/pull/288)\r\n- Clean up validate function. by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/275](https://togithub.com/salesforce/tough-cookie/pull/275)\r\n- Changes to support full eslint rule configurations by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/289](https://togithub.com/salesforce/tough-cookie/pull/289)\r\n- Split giant cookie.ts into multiple files. by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/296](https://togithub.com/salesforce/tough-cookie/pull/296)\r\n- Merge branch 'master' into v5 by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/300](https://togithub.com/salesforce/tough-cookie/pull/300)\r\n- Merge `v5` into `master` by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/303](https://togithub.com/salesforce/tough-cookie/pull/303)\r\n- Preparing for release `5.0.0-rc.0` by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/304](https://togithub.com/salesforce/tough-cookie/pull/304)\r\n- Bump [@​babel/traverse](https://togithub.com/babel/traverse)\r\nfrom 7.21.3 to 7.23.2 by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/305](https://togithub.com/salesforce/tough-cookie/pull/305)\r\n- Configure dependabot and codeowners by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/306](https://togithub.com/salesforce/tough-cookie/pull/306)\r\n- Bump\r\n[@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)\r\nfrom 5.58.0 to 5.62.0 by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/310](https://togithub.com/salesforce/tough-cookie/pull/310)\r\n- Bump eslint-config-prettier from 8.8.0 to 9.0.0 by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/311](https://togithub.com/salesforce/tough-cookie/pull/311)\r\n- Bump async from 2.6.4 to 3.2.4 by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/313](https://togithub.com/salesforce/tough-cookie/pull/313)\r\n- Avoid using `arguments` by [@​wjhsf](https://togithub.com/wjhsf)\r\nin\r\n[https://github.com/salesforce/tough-cookie/pull/316](https://togithub.com/salesforce/tough-cookie/pull/316)\r\n- Configure dependabot to ignore\r\n[@​types/node](https://togithub.com/types/node). by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/319](https://togithub.com/salesforce/tough-cookie/pull/319)\r\n- Bump dependencies. by [@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/323](https://togithub.com/salesforce/tough-cookie/pull/323)\r\n- Bump the dev-dependencies group with 6 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/342](https://togithub.com/salesforce/tough-cookie/pull/342)\r\n- Bump the dev-dependencies group with 1 update by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/344](https://togithub.com/salesforce/tough-cookie/pull/344)\r\n- Bump the dev-dependencies group with 3 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/347](https://togithub.com/salesforce/tough-cookie/pull/347)\r\n- docs: use correct memstore file link by\r\n[@​alissonsleal](https://togithub.com/alissonsleal) in\r\n[https://github.com/salesforce/tough-cookie/pull/349](https://togithub.com/salesforce/tough-cookie/pull/349)\r\n- Bump the dev-dependencies group with 3 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/351](https://togithub.com/salesforce/tough-cookie/pull/351)\r\n- Bump the dev-dependencies group with 2 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/354](https://togithub.com/salesforce/tough-cookie/pull/354)\r\n- Fix expiry time not updating when cookie is updated by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/345](https://togithub.com/salesforce/tough-cookie/pull/345)\r\n- Change dependabot to monthly by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/355](https://togithub.com/salesforce/tough-cookie/pull/355)\r\n- Bump the dev-dependencies group with 5 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/358](https://togithub.com/salesforce/tough-cookie/pull/358)\r\n- Avoid `void` by [@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/331](https://togithub.com/salesforce/tough-cookie/pull/331)\r\n- Replace `psl` with `tldts` by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/346](https://togithub.com/salesforce/tough-cookie/pull/346)\r\n- Bump the production-dependencies group with 1 update by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/362](https://togithub.com/salesforce/tough-cookie/pull/362)\r\n- Bump the dev-dependencies group with 4 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/363](https://togithub.com/salesforce/tough-cookie/pull/363)\r\n- docs: fix JSON.serialize -> JSON.stringify by\r\n[@​zavan](https://togithub.com/zavan) in\r\n[https://github.com/salesforce/tough-cookie/pull/361](https://togithub.com/salesforce/tough-cookie/pull/361)\r\n- Remove workarounds for `util` in non-node environments by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/359](https://togithub.com/salesforce/tough-cookie/pull/359)\r\n- Accept URL parameter in `getCookies` and `setCookie` by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/364](https://togithub.com/salesforce/tough-cookie/pull/364)\r\n- Remove community cookie store links by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/367](https://togithub.com/salesforce/tough-cookie/pull/367)\r\n- Handle unlikely edge case in unimportant util by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/366](https://togithub.com/salesforce/tough-cookie/pull/366)\r\n- Fix allow listed `files` for what to include in npm package by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/368](https://togithub.com/salesforce/tough-cookie/pull/368)\r\n- fix\r\n[#​256](https://togithub.com/salesforce/tough-cookie/issues/256)\r\nby [@​hrueger](https://togithub.com/hrueger) in\r\n[https://github.com/salesforce/tough-cookie/pull/297](https://togithub.com/salesforce/tough-cookie/pull/297)\r\n- Preparing for release 5.0.0-rc.1 by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/369](https://togithub.com/salesforce/tough-cookie/pull/369)\r\n- Bump\r\n[@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)\r\nfrom 6.20.0 to 7.0.0 by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/373](https://togithub.com/salesforce/tough-cookie/pull/373)\r\n- Bump the production-dependencies group with 1 update by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/370](https://togithub.com/salesforce/tough-cookie/pull/370)\r\n- Fixes eslint plugin dev upgrades by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/375](https://togithub.com/salesforce/tough-cookie/pull/375)\r\n- restore `parse` export that was accidentally removed by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/376](https://togithub.com/salesforce/tough-cookie/pull/376)\r\n- Clean up cookie creation by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/381](https://togithub.com/salesforce/tough-cookie/pull/381)\r\n- Enforce explicit function return type by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/383](https://togithub.com/salesforce/tough-cookie/pull/383)\r\n- patch removed util methods for vows by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/389](https://togithub.com/salesforce/tough-cookie/pull/389)\r\n- clean up usage of null/undefined by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/380](https://togithub.com/salesforce/tough-cookie/pull/380)\r\n- Bump the dev-dependencies group with 2 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/404](https://togithub.com/salesforce/tough-cookie/pull/404)\r\n- Bump the production-dependencies group with 1 update by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/403](https://togithub.com/salesforce/tough-cookie/pull/403)\r\n- Remove `@types/psl` from dev dependencies by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/406](https://togithub.com/salesforce/tough-cookie/pull/406)\r\n- Bump tldts from 6.1.16 to 6.1.18 in the production-dependencies group\r\nby [@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/411](https://togithub.com/salesforce/tough-cookie/pull/411)\r\n- Bump the dev-dependencies group with 2 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/412](https://togithub.com/salesforce/tough-cookie/pull/412)\r\n- Bump ejs from 3.1.9 to 3.1.10 by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/413](https://togithub.com/salesforce/tough-cookie/pull/413)\r\n- Update v5 docs by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/384](https://togithub.com/salesforce/tough-cookie/pull/384)\r\n- Enable strict type checked rules by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/392](https://togithub.com/salesforce/tough-cookie/pull/392)\r\n- Preparing for release 5.0.0-rc.2 by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/414](https://togithub.com/salesforce/tough-cookie/pull/414)\r\n- Bump the dev-dependencies group with 4 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/417](https://togithub.com/salesforce/tough-cookie/pull/417)\r\n- Bump [@​eslint/js](https://togithub.com/eslint/js) from 8.57.0\r\nto 9.4.0 by [@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/419](https://togithub.com/salesforce/tough-cookie/pull/419)\r\n- Bump tldts from 6.1.18 to 6.1.24 in the production-dependencies group\r\nacross 1 directory by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/420](https://togithub.com/salesforce/tough-cookie/pull/420)\r\n- chore: update deps by [@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/421](https://togithub.com/salesforce/tough-cookie/pull/421)\r\n- Use latest TypeScript version by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/423](https://togithub.com/salesforce/tough-cookie/pull/423)\r\n- Update contributors by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/425](https://togithub.com/salesforce/tough-cookie/pull/425)\r\n- Bump tldts from 6.1.28 to 6.1.30 in the production-dependencies group\r\nby [@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/426](https://togithub.com/salesforce/tough-cookie/pull/426)\r\n- Bump the dev-dependencies group with 4 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/427](https://togithub.com/salesforce/tough-cookie/pull/427)\r\n- Fix validation errors not calling callbacks by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/424](https://togithub.com/salesforce/tough-cookie/pull/424)\r\n- Preparing for release 5.0.0-rc.3 by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/430](https://togithub.com/salesforce/tough-cookie/pull/430)\r\n- Remove url-parse and punycode by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/429](https://togithub.com/salesforce/tough-cookie/pull/429)\r\n- Checks structure instead of instanceof for URL test by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/431](https://togithub.com/salesforce/tough-cookie/pull/431)\r\n- pre-release cleanup by [@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/428](https://togithub.com/salesforce/tough-cookie/pull/428)\r\n- Preparing for release 5.0.0-rc.4 by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/432](https://togithub.com/salesforce/tough-cookie/pull/432)\r\n- use `domainToASCII(str)` instead of `new URL(str).hostName` by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/433](https://togithub.com/salesforce/tough-cookie/pull/433)\r\n- Bump tldts from 6.1.32 to 6.1.37 in the production-dependencies group\r\nby [@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/436](https://togithub.com/salesforce/tough-cookie/pull/436)\r\n- Bump the dev-dependencies group across 1 directory with 6 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/439](https://togithub.com/salesforce/tough-cookie/pull/439)\r\n- Bump tldts from 6.1.37 to 6.1.41 in the production-dependencies group\r\nby [@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/443](https://togithub.com/salesforce/tough-cookie/pull/443)\r\n- Bump the dev-dependencies group with 6 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/444](https://togithub.com/salesforce/tough-cookie/pull/444)\r\n- upgrade typescript-eslint to 8.0.1 by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/440](https://togithub.com/salesforce/tough-cookie/pull/440)\r\n- Bump the dev-dependencies group with 2 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/448](https://togithub.com/salesforce/tough-cookie/pull/448)\r\n- Bump eslint from 8.57.0 to 9.9.1 by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/449](https://togithub.com/salesforce/tough-cookie/pull/449)\r\n- Prepare v5 by [@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/451](https://togithub.com/salesforce/tough-cookie/pull/451)\r\n\r\n#### New Contributors\r\n\r\n- [@​alissonsleal](https://togithub.com/alissonsleal) made their\r\nfirst contribution in\r\n[https://github.com/salesforce/tough-cookie/pull/349](https://togithub.com/salesforce/tough-cookie/pull/349)\r\n- [@​zavan](https://togithub.com/zavan) made their first\r\ncontribution in\r\n[https://github.com/salesforce/tough-cookie/pull/361](https://togithub.com/salesforce/tough-cookie/pull/361)\r\n- [@​hrueger](https://togithub.com/hrueger) made their first\r\ncontribution in\r\n[https://github.com/salesforce/tough-cookie/pull/297](https://togithub.com/salesforce/tough-cookie/pull/297)\r\n\r\n**Full Changelog**:\r\nhttps://github.com/salesforce/tough-cookie/compare/v4.1.3...v5.0.0\r\n\r\n</details>\r\n\r\n---\r\n\r\n### Configuration\r\n\r\n📅 **Schedule**: Branch creation - At any time (no schedule defined),\r\nAutomerge - At any time (no schedule defined).\r\n\r\n🚦 **Automerge**: Disabled by config. Please merge this manually once you\r\nare satisfied.\r\n\r\n♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the\r\nrebase/retry checkbox.\r\n\r\n🔕 **Ignore**: Close this PR and you won't be reminded about this update\r\nagain.\r\n\r\n---\r\n\r\n- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check\r\nthis box\r\n\r\n---\r\n\r\nThis PR has been generated by [Renovate\r\nBot](https://togithub.com/renovatebot/renovate).\r\n\r\n<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJUZWFtOlNlY3VyaXR5IiwiYmFja3BvcnQ6YWxsLW9wZW4iLCJyZWxlYXNlX25vdGU6c2tpcCJdfQ==-->\r\n\r\nCo-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com>","sha":"f712e4a47bb653136cc8ceefca08d3524dc00a4b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193107","number":193107,"mergeCommit":{"message":"Update dependency tough-cookie to v5 (main) (#193107)\n\nThis PR contains the following updates:\r\n\r\n| Package | Type | Update | Change |\r\n|---|---|---|---|\r\n| [tough-cookie](https://togithub.com/salesforce/tough-cookie) |\r\ndevDependencies | major | [`^4.1.4` ->\r\n`^5.0.0`](https://renovatebot.com/diffs/npm/tough-cookie/4.1.4/5.0.0) |\r\n\r\n---\r\n\r\n### Release Notes\r\n\r\n<details>\r\n<summary>salesforce/tough-cookie (tough-cookie)</summary>\r\n\r\n###\r\n[`v5.0.0`](https://togithub.com/salesforce/tough-cookie/releases/tag/v5.0.0)\r\n\r\n[Compare\r\nSource](https://togithub.com/salesforce/tough-cookie/compare/v4.1.4...v5.0.0)\r\n\r\n#### Summary\r\n\r\n##### Breaking Changes\r\n\r\n- We've migrated the project to TypeScript! First-party types are now\r\navailable.\r\n- The minimum supported version of node is v18.\r\n- We no longer provide official support for non-node enviroments.\r\n\r\n##### API Changes\r\n\r\n- We've standardized most of our exposed interfaces to accept both\r\n`null` and `undefined` and return only `undefined`.\r\n- `getCookie` and `getCookies` now accept a `string` or `URL` as a\r\nparameter.\r\n- We've removed the `inspect` function in favor of node's\r\n`util.inspect.custom` symbol. Cookies may appear different when logged\r\nin non-node environments.\r\n\r\n##### Other Changes\r\n\r\n- Fixed the expiry time not updating when a cookie is updating.\r\n- Fixed validation errors not getting called in some callbacks.\r\n- [New\r\ndocumentation](https://togithub.com/salesforce/tough-cookie/blob/v5.0.0/api/docs/tough-cookie.md)\r\nthat is always kept up to date!\r\n- Performance improvements.\r\n\r\n#### What's Changed\r\n\r\n- Typescript support by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/264](https://togithub.com/salesforce/tough-cookie/pull/264)\r\n- \\[v5] Update config by [@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/269](https://togithub.com/salesforce/tough-cookie/pull/269)\r\n- Fix prettier in eslint config by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/274](https://togithub.com/salesforce/tough-cookie/pull/274)\r\n- Updated dev tooling by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/271](https://togithub.com/salesforce/tough-cookie/pull/271)\r\n- Port 283 fix to v5 by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/287](https://togithub.com/salesforce/tough-cookie/pull/287)\r\n- Remove some [@​ts-ignore](https://togithub.com/ts-ignore)\r\ndirectives. by [@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/288](https://togithub.com/salesforce/tough-cookie/pull/288)\r\n- Clean up validate function. by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/275](https://togithub.com/salesforce/tough-cookie/pull/275)\r\n- Changes to support full eslint rule configurations by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/289](https://togithub.com/salesforce/tough-cookie/pull/289)\r\n- Split giant cookie.ts into multiple files. by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/296](https://togithub.com/salesforce/tough-cookie/pull/296)\r\n- Merge branch 'master' into v5 by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/300](https://togithub.com/salesforce/tough-cookie/pull/300)\r\n- Merge `v5` into `master` by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/303](https://togithub.com/salesforce/tough-cookie/pull/303)\r\n- Preparing for release `5.0.0-rc.0` by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/304](https://togithub.com/salesforce/tough-cookie/pull/304)\r\n- Bump [@​babel/traverse](https://togithub.com/babel/traverse)\r\nfrom 7.21.3 to 7.23.2 by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/305](https://togithub.com/salesforce/tough-cookie/pull/305)\r\n- Configure dependabot and codeowners by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/306](https://togithub.com/salesforce/tough-cookie/pull/306)\r\n- Bump\r\n[@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)\r\nfrom 5.58.0 to 5.62.0 by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/310](https://togithub.com/salesforce/tough-cookie/pull/310)\r\n- Bump eslint-config-prettier from 8.8.0 to 9.0.0 by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/311](https://togithub.com/salesforce/tough-cookie/pull/311)\r\n- Bump async from 2.6.4 to 3.2.4 by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/313](https://togithub.com/salesforce/tough-cookie/pull/313)\r\n- Avoid using `arguments` by [@​wjhsf](https://togithub.com/wjhsf)\r\nin\r\n[https://github.com/salesforce/tough-cookie/pull/316](https://togithub.com/salesforce/tough-cookie/pull/316)\r\n- Configure dependabot to ignore\r\n[@​types/node](https://togithub.com/types/node). by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/319](https://togithub.com/salesforce/tough-cookie/pull/319)\r\n- Bump dependencies. by [@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/323](https://togithub.com/salesforce/tough-cookie/pull/323)\r\n- Bump the dev-dependencies group with 6 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/342](https://togithub.com/salesforce/tough-cookie/pull/342)\r\n- Bump the dev-dependencies group with 1 update by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/344](https://togithub.com/salesforce/tough-cookie/pull/344)\r\n- Bump the dev-dependencies group with 3 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/347](https://togithub.com/salesforce/tough-cookie/pull/347)\r\n- docs: use correct memstore file link by\r\n[@​alissonsleal](https://togithub.com/alissonsleal) in\r\n[https://github.com/salesforce/tough-cookie/pull/349](https://togithub.com/salesforce/tough-cookie/pull/349)\r\n- Bump the dev-dependencies group with 3 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/351](https://togithub.com/salesforce/tough-cookie/pull/351)\r\n- Bump the dev-dependencies group with 2 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/354](https://togithub.com/salesforce/tough-cookie/pull/354)\r\n- Fix expiry time not updating when cookie is updated by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/345](https://togithub.com/salesforce/tough-cookie/pull/345)\r\n- Change dependabot to monthly by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/355](https://togithub.com/salesforce/tough-cookie/pull/355)\r\n- Bump the dev-dependencies group with 5 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/358](https://togithub.com/salesforce/tough-cookie/pull/358)\r\n- Avoid `void` by [@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/331](https://togithub.com/salesforce/tough-cookie/pull/331)\r\n- Replace `psl` with `tldts` by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/346](https://togithub.com/salesforce/tough-cookie/pull/346)\r\n- Bump the production-dependencies group with 1 update by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/362](https://togithub.com/salesforce/tough-cookie/pull/362)\r\n- Bump the dev-dependencies group with 4 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/363](https://togithub.com/salesforce/tough-cookie/pull/363)\r\n- docs: fix JSON.serialize -> JSON.stringify by\r\n[@​zavan](https://togithub.com/zavan) in\r\n[https://github.com/salesforce/tough-cookie/pull/361](https://togithub.com/salesforce/tough-cookie/pull/361)\r\n- Remove workarounds for `util` in non-node environments by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/359](https://togithub.com/salesforce/tough-cookie/pull/359)\r\n- Accept URL parameter in `getCookies` and `setCookie` by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/364](https://togithub.com/salesforce/tough-cookie/pull/364)\r\n- Remove community cookie store links by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/367](https://togithub.com/salesforce/tough-cookie/pull/367)\r\n- Handle unlikely edge case in unimportant util by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/366](https://togithub.com/salesforce/tough-cookie/pull/366)\r\n- Fix allow listed `files` for what to include in npm package by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/368](https://togithub.com/salesforce/tough-cookie/pull/368)\r\n- fix\r\n[#​256](https://togithub.com/salesforce/tough-cookie/issues/256)\r\nby [@​hrueger](https://togithub.com/hrueger) in\r\n[https://github.com/salesforce/tough-cookie/pull/297](https://togithub.com/salesforce/tough-cookie/pull/297)\r\n- Preparing for release 5.0.0-rc.1 by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/369](https://togithub.com/salesforce/tough-cookie/pull/369)\r\n- Bump\r\n[@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)\r\nfrom 6.20.0 to 7.0.0 by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/373](https://togithub.com/salesforce/tough-cookie/pull/373)\r\n- Bump the production-dependencies group with 1 update by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/370](https://togithub.com/salesforce/tough-cookie/pull/370)\r\n- Fixes eslint plugin dev upgrades by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/375](https://togithub.com/salesforce/tough-cookie/pull/375)\r\n- restore `parse` export that was accidentally removed by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/376](https://togithub.com/salesforce/tough-cookie/pull/376)\r\n- Clean up cookie creation by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/381](https://togithub.com/salesforce/tough-cookie/pull/381)\r\n- Enforce explicit function return type by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/383](https://togithub.com/salesforce/tough-cookie/pull/383)\r\n- patch removed util methods for vows by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/389](https://togithub.com/salesforce/tough-cookie/pull/389)\r\n- clean up usage of null/undefined by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/380](https://togithub.com/salesforce/tough-cookie/pull/380)\r\n- Bump the dev-dependencies group with 2 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/404](https://togithub.com/salesforce/tough-cookie/pull/404)\r\n- Bump the production-dependencies group with 1 update by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/403](https://togithub.com/salesforce/tough-cookie/pull/403)\r\n- Remove `@types/psl` from dev dependencies by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/406](https://togithub.com/salesforce/tough-cookie/pull/406)\r\n- Bump tldts from 6.1.16 to 6.1.18 in the production-dependencies group\r\nby [@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/411](https://togithub.com/salesforce/tough-cookie/pull/411)\r\n- Bump the dev-dependencies group with 2 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/412](https://togithub.com/salesforce/tough-cookie/pull/412)\r\n- Bump ejs from 3.1.9 to 3.1.10 by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/413](https://togithub.com/salesforce/tough-cookie/pull/413)\r\n- Update v5 docs by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/384](https://togithub.com/salesforce/tough-cookie/pull/384)\r\n- Enable strict type checked rules by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/392](https://togithub.com/salesforce/tough-cookie/pull/392)\r\n- Preparing for release 5.0.0-rc.2 by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/414](https://togithub.com/salesforce/tough-cookie/pull/414)\r\n- Bump the dev-dependencies group with 4 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/417](https://togithub.com/salesforce/tough-cookie/pull/417)\r\n- Bump [@​eslint/js](https://togithub.com/eslint/js) from 8.57.0\r\nto 9.4.0 by [@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/419](https://togithub.com/salesforce/tough-cookie/pull/419)\r\n- Bump tldts from 6.1.18 to 6.1.24 in the production-dependencies group\r\nacross 1 directory by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/420](https://togithub.com/salesforce/tough-cookie/pull/420)\r\n- chore: update deps by [@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/421](https://togithub.com/salesforce/tough-cookie/pull/421)\r\n- Use latest TypeScript version by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/423](https://togithub.com/salesforce/tough-cookie/pull/423)\r\n- Update contributors by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/425](https://togithub.com/salesforce/tough-cookie/pull/425)\r\n- Bump tldts from 6.1.28 to 6.1.30 in the production-dependencies group\r\nby [@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/426](https://togithub.com/salesforce/tough-cookie/pull/426)\r\n- Bump the dev-dependencies group with 4 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/427](https://togithub.com/salesforce/tough-cookie/pull/427)\r\n- Fix validation errors not calling callbacks by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/424](https://togithub.com/salesforce/tough-cookie/pull/424)\r\n- Preparing for release 5.0.0-rc.3 by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/430](https://togithub.com/salesforce/tough-cookie/pull/430)\r\n- Remove url-parse and punycode by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/429](https://togithub.com/salesforce/tough-cookie/pull/429)\r\n- Checks structure instead of instanceof for URL test by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/431](https://togithub.com/salesforce/tough-cookie/pull/431)\r\n- pre-release cleanup by [@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/428](https://togithub.com/salesforce/tough-cookie/pull/428)\r\n- Preparing for release 5.0.0-rc.4 by\r\n[@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/432](https://togithub.com/salesforce/tough-cookie/pull/432)\r\n- use `domainToASCII(str)` instead of `new URL(str).hostName` by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/433](https://togithub.com/salesforce/tough-cookie/pull/433)\r\n- Bump tldts from 6.1.32 to 6.1.37 in the production-dependencies group\r\nby [@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/436](https://togithub.com/salesforce/tough-cookie/pull/436)\r\n- Bump the dev-dependencies group across 1 directory with 6 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/439](https://togithub.com/salesforce/tough-cookie/pull/439)\r\n- Bump tldts from 6.1.37 to 6.1.41 in the production-dependencies group\r\nby [@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/443](https://togithub.com/salesforce/tough-cookie/pull/443)\r\n- Bump the dev-dependencies group with 6 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/444](https://togithub.com/salesforce/tough-cookie/pull/444)\r\n- upgrade typescript-eslint to 8.0.1 by\r\n[@​wjhsf](https://togithub.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/440](https://togithub.com/salesforce/tough-cookie/pull/440)\r\n- Bump the dev-dependencies group with 2 updates by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/448](https://togithub.com/salesforce/tough-cookie/pull/448)\r\n- Bump eslint from 8.57.0 to 9.9.1 by\r\n[@​dependabot](https://togithub.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/449](https://togithub.com/salesforce/tough-cookie/pull/449)\r\n- Prepare v5 by [@​colincasey](https://togithub.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/451](https://togithub.com/salesforce/tough-cookie/pull/451)\r\n\r\n#### New Contributors\r\n\r\n- [@​alissonsleal](https://togithub.com/alissonsleal) made their\r\nfirst contribution in\r\n[https://github.com/salesforce/tough-cookie/pull/349](https://togithub.com/salesforce/tough-cookie/pull/349)\r\n- [@​zavan](https://togithub.com/zavan) made their first\r\ncontribution in\r\n[https://github.com/salesforce/tough-cookie/pull/361](https://togithub.com/salesforce/tough-cookie/pull/361)\r\n- [@​hrueger](https://togithub.com/hrueger) made their first\r\ncontribution in\r\n[https://github.com/salesforce/tough-cookie/pull/297](https://togithub.com/salesforce/tough-cookie/pull/297)\r\n\r\n**Full Changelog**:\r\nhttps://github.com/salesforce/tough-cookie/compare/v4.1.3...v5.0.0\r\n\r\n</details>\r\n\r\n---\r\n\r\n### Configuration\r\n\r\n📅 **Schedule**: Branch creation - At any time (no schedule defined),\r\nAutomerge - At any time (no schedule defined).\r\n\r\n🚦 **Automerge**: Disabled by config. Please merge this manually once you\r\nare satisfied.\r\n\r\n♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the\r\nrebase/retry checkbox.\r\n\r\n🔕 **Ignore**: Close this PR and you won't be reminded about this update\r\nagain.\r\n\r\n---\r\n\r\n- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check\r\nthis box\r\n\r\n---\r\n\r\nThis PR has been generated by [Renovate\r\nBot](https://togithub.com/renovatebot/renovate).\r\n\r\n<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJUZWFtOlNlY3VyaXR5IiwiYmFja3BvcnQ6YWxsLW9wZW4iLCJyZWxlYXNlX25vdGU6c2tpcCJdfQ==-->\r\n\r\nCo-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com>","sha":"f712e4a47bb653136cc8ceefca08d3524dc00a4b"}}]}] BACKPORT--> Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.no…
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cookie.expiryTime()
method was calculating anexpiry-time
value usingcreation-time + max-age
if themax-age
value was set. This is not correct as RFC6265 does not say anything aboutcreation-time
having any effect onmax-age
.The main issue is that
max-age
should be stored as a date (see text below), not an offset number as it currently is implemented.Because
max-age
is an offset, theexpiry-time
now needs to be calculated from "some" point in time andcreation-time
was chosen. In many cases this works fine but, if you have an existing cookie stored with amax-age
attribute and then update it, theexpiry-time
will be incorrectly report the previous value'sexpiry-time
. This is due to the following rule regardingcreation-time
from the spec:This should make it clear that
creation-time
should not be used to calculate theexpiry-time
. Given that we still need to calculate theexpiry-time
due to howmax-age
is stored, the better value to use in this circumstance is thelast-access-time
which is always updated whensetCookie(...)
is called.Fixes #343
Fixes #154