Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow set cookies with localhost #253

Merged
merged 5 commits into from
Aug 25, 2022
Merged

fix: allow set cookies with localhost #253

merged 5 commits into from
Aug 25, 2022

Conversation

colincasey
Copy link
Contributor

Adding more tests to cover the breaking use cases noted in #246. e.g.; new CookieJar().setCookieSync("settingThisShouldPass=true; Domain=localhost; Path=/;", "http://localhost")

Also:

@colincasey
fix: allow set cookies with localhost
8b06ee7 
Adding more tests to cover the breaking use cases noted in #246.

e.g.;.
* `new CookieJar().setCookieSync("settingThisShouldPass=true; Domain=localhost; Path=/;", "http://localhost")`

Also modifies the assertion for a test introduced in #221 that may be incorrect.
@colincasey
fix: allow set cookies with localhost
ea0ea0c 
Adding more tests to cover the breaking use cases noted in #246.

e.g.;.
* `new CookieJar().setCookieSync("settingThisShouldPass=true; Domain=localhost; Path=/;", "http://localhost")`

Also modifies the assertion for a test introduced in #221 that may be incorrect.
@colincasey
fix: allow set cookies with localhost
7ae6c00 
Adding more tests to cover the breaking use cases noted in #246.

e.g.;.
* `new CookieJar().setCookieSync("settingThisShouldPass=true; Domain=localhost; Path=/;", "http://localhost")`

Also modifies the assertion for a test introduced in #221 that may be incorrect.
@awaterma
Copy link
Member

Thanks! I'm happy with this approach! Let's discuss a bit and merge, and then generate another patch release for our week of excitement. :)

awaterma
awaterma previously approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@awaterma awaterma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved; will merge after discussion.

@sheilf-synapse sheilf-synapse mentioned this pull request Aug 25, 2022
Closed
@colincasey
fix: allow set cookies with localhost
bd7a391 
updated CHANGELOG.md to point to the releases page since changelogs are auto-generated now.
@colincasey
Release v4.1.2
0c7917f
awaterma
awaterma approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@awaterma awaterma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@awaterma awaterma merged commit b1a8898 into master Aug 25, 2022
@estruyf estruyf mentioned this pull request Mar 16, 2023
Closed
@Silverium Silverium mentioned this pull request Aug 26, 2023
Open
@botanical botanical mentioned this pull request May 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaterma awaterma awaterma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colincasey @awaterma