Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: salesforce/tough-cookie
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.3.2
Choose a base ref
...
head repository: salesforce/tough-cookie
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.3.4
Choose a head ref
  • 18 commits
  • 13 files changed
  • 7 contributors

Commits on Oct 25, 2016

  1. CookieJar.deserialize does not modify its input 

    Fix #59
    @dotchev @stash-sfdc
    dotchev authored and stash-sfdc committed Oct 25, 2016
    Configuration menu
    Copy the full SHA
    ee60643 View commit details
    Browse the repository at this point in the history

  2. Dockerized project. Added .npmignore for docker files.

    @awaterma @stash-sfdc
    awaterma authored and stash-sfdc committed Oct 25, 2016
    Configuration menu
    Copy the full SHA
    92d5448 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2016

  1. Updates to public suffix list.

    @awaterma
    awaterma committed Nov 18, 2016
    Configuration menu
    Copy the full SHA
    ed31ba4 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2016

  1. Merge pull request #83 from awaterma/public-suffix 

    Updates to public suffix list.
    @stash-sfdc
    stash-sfdc authored Nov 28, 2016
    Configuration menu
    Copy the full SHA
    a928b54 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2017

  1. fix test

    Yevhen Lukomskyi authored and Yevhen Lukomskyi committed Sep 21, 2017
    Configuration menu
    Copy the full SHA
    1002fb4 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #96 from YevhenLukomskyi/fix-test 

    fix test
    @inikulin
    inikulin authored Sep 21, 2017
    Configuration menu
    Copy the full SHA
    fcc8abf View commit details
    Browse the repository at this point in the history

  3. Constrain spaces before = to 256 

    Side-steps ReDoS in Issue #92
    @stash-sfdc
    stash-sfdc committed Sep 21, 2017
    Configuration menu
    Copy the full SHA
    f1ed420 View commit details
    Browse the repository at this point in the history

  4. Document the 256 spaces limit

    @stash-sfdc
    stash-sfdc committed Sep 21, 2017
    Configuration menu
    Copy the full SHA
    4e2fb0b View commit details
    Browse the repository at this point in the history

  5. Merge pull request #97 from salesforce/spaces-ReDoS 

    Constrain spaces before = to 256
    @stash-sfdc
    stash-sfdc authored Sep 21, 2017
    Configuration menu
    Copy the full SHA
    98e0916 View commit details
    Browse the repository at this point in the history

  6. 2.3.3

    @stash-sfdc
    stash-sfdc committed Sep 21, 2017
    Configuration menu
    Copy the full SHA
    12d4266 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2017

  1. Parse cookie-pair part without regexp 

    Specifically to avoid any more hidden ReDoS in those regexes.

Seems to run tests in 6.9s vs 7.0s so might be a bit of a speed bonus on
some platforms!
    @stash-sfdc
    stash-sfdc committed Sep 22, 2017
    Configuration menu
    Copy the full SHA
    c9bd79d View commit details
    Browse the repository at this point in the history

  2. Avoid unbounded Regexp parts in date parsing 

    Replaces a bunch of `[^\d]*$` with bounded `(?:[^\d]|$)`

Double checked the RFC6265 spec: time cannot have non-digits beside the
colons.
    @stash-sfdc
    stash-sfdc committed Sep 22, 2017
    Configuration menu
    Copy the full SHA
    2a4775c View commit details
    Browse the repository at this point in the history

  3. More String#repeat polyfill

    @stash-sfdc
    stash-sfdc committed Sep 22, 2017
    Configuration menu
    Copy the full SHA
    8614dbf View commit details
    Browse the repository at this point in the history

  4. Convert date-time parser from regexp, expand tests 

    None of the regexps (at least, when they were removed) are vulnerable to
ReDoS. However, took this opportunity to check that the RFC is being
closer and more clearly documented where in the code.

Another way to put this: "regexps are magic and hinder code analysis"

Introduced some equivalence tests to ensure that certain "weird" dates
are indeed parsing the same as their "canonical" RFC6265 counterpart.
    @stash-sfdc
    stash-sfdc committed Sep 22, 2017
    Configuration menu
    Copy the full SHA
    8452ccd View commit details
    Browse the repository at this point in the history

  5. Document removal of 256 space limit

    @stash-sfdc
    stash-sfdc committed Sep 22, 2017
    Configuration menu
    Copy the full SHA
    751da6d View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2018

  1. Merge pull request #100 from salesforce/no-re-parser 

    No-RegExp parser.

Integration tested with latest `jsdom` and `request`
    @stash
    stash authored Feb 24, 2018
    Configuration menu
    Copy the full SHA
    7564c06 View commit details
    Browse the repository at this point in the history

  2. Update public suffix list

    @stash
    stash committed Feb 24, 2018
    Configuration menu
    Copy the full SHA
    7d66ffd View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2018

  1. 2.3.4

    @stash
    stash committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    e4dfb0a View commit details
    Browse the repository at this point in the history
Loading