feat(config): add better support for TypeScript #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjhsf
commented
May 22, 2024
Comment on lines
+32
to
+41
| moduleFileExtensions: jestPreset.moduleFileExtensions || ['ts', 'js', 'html'], | ||
| testEnvironment: jestPreset.testEnvironment || 'jsdom', | ||
| transform: { | ||
| '^.+\\.(js|html|css)$': require.resolve('@lwc/jest-transformer'), | ||
| ...jestPreset.transform, | ||
| '^.+\\.(js|ts|html|css)$': require.resolve('@lwc/jest-transformer'), | ||
| }, | ||
| setupFilesAfterEnv: jestPreset.setupFilesAfterEnv || [], | ||
| snapshotSerializers: jestPreset.snapshotSerializers || [ | ||
| require.resolve('@lwc/jest-serializer'), | ||
| ], |
There was a problem hiding this comment.
I'm not sure why we have the pattern of jestPreset.prop || 'hard-coded value matching jestPreset' when we depend on a version of jestPreset where it's always defined, but I kept the pattern.
I also considered changing this section to just ...jestPreset, but that would add in testMatch and coveragePathIgnorePatterns, and I don't know whether we want to do that.
jmsjtu
approved these changes
May 28, 2024
This was referenced Aug 28, 2024
Merged
Merged
This was referenced Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript is supported by
@lwc/jest-preset, but not bysfdx-lwc-jest, even thoughsfdx-lwc-jestbuilds on@lwc/jest-preset.sfdx-lwc-jest/src/config.js
Lines 32 to 36 in c3ace89
This PR updates the config provided by
sfdx-lwc-jestto support TypeScript by using more of@lwc/jest-preset.