feat: add uiGraphQLApi module #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| export class graphql extends createTestWireAdapter() { | ||
| static emit(value, filterFn) { | ||
| super.emit({ data: value, errors: undefined }, filterFn); |
There was a problem hiding this comment.
Is this required? errors: undefined. The default value for unset object keys is undefined
There was a problem hiding this comment.
I'm not really sure - but it's what our stub in lightning-components has
Co-authored-by: Ravi Jayaramappa <ravi.jayaramappa@salesforce.com>
ravijayaramappa
approved these changes
Apr 24, 2023
scarrawaySF
added a commit
that referenced
this pull request
Apr 24, 2023
* feat: add uiGraphQLApi module * fix format * Update src/lightning-stubs/uiGraphQLApi/uiGraphQLApi.js Co-authored-by: Ravi Jayaramappa <ravi.jayaramappa@salesforce.com> --------- Co-authored-by: Ravi Jayaramappa <ravi.jayaramappa@salesforce.com>
ravijayaramappa
added a commit
that referenced
this pull request
Apr 24, 2023
mburr-salesforce
pushed a commit
to mburr-salesforce/sfdx-lwc-jest
that referenced
this pull request
May 30, 2023
* feat: add uiGraphQLApi module * fix format * Update src/lightning-stubs/uiGraphQLApi/uiGraphQLApi.js Co-authored-by: Ravi Jayaramappa <ravi.jayaramappa@salesforce.com> --------- Co-authored-by: Ravi Jayaramappa <ravi.jayaramappa@salesforce.com>
jye-sf
pushed a commit
that referenced
this pull request
May 30, 2023
* feat: add uiGraphQLApi module (#310) * feat: add uiGraphQLApi module * fix format * Update src/lightning-stubs/uiGraphQLApi/uiGraphQLApi.js Co-authored-by: Ravi Jayaramappa <ravi.jayaramappa@salesforce.com> --------- Co-authored-by: Ravi Jayaramappa <ravi.jayaramappa@salesforce.com> * fix: fix initial emit for GraphQL adapters (#315) --------- Co-authored-by: Stephen Carraway <57263085+scarrawaySF@users.noreply.github.com> Co-authored-by: Ravi Jayaramappa <ravi.jayaramappa@salesforce.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-exporting the uiGraphQLApi module for testing.