Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stub. modalBody, modalHeader, modalFooter #303

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

noblejasper
Copy link
Contributor

@noblejasper noblejasper commented Feb 2, 2023

test fails when using modal-body, modal-header, modal-footer components
Added stub to prevent test from failing

@crysislinux
Copy link

Is the lightning/modal also needed?

@noblejasper
Copy link
Contributor Author

@crysislinux No, the component lightning/modal does not exist and is therefore not needed.

@noblejasper noblejasper marked this pull request as ready for review February 21, 2023 05:20
@CollinHerber
Copy link

Can we get some traction on this please, it is rather cumbersome to add these stubs to every repo to test against LightningModal related components.

@Templarian Templarian merged commit e00dd29 into salesforce:master Jul 10, 2023
@Templarian
Copy link
Collaborator

@CollinHerber Latest NPM has it published.

@CollinHerber
Copy link

@CollinHerber Latest NPM has it published.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants