fix(ssr): more fixes for light DOM slots #4695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aka every!
…ob/more-light-dom-slots
nolanlawson
commented
Oct 24, 2024
packages/@lwc/ssr-compiler/src/compile-template/transformers/component.ts
Show resolved
Hide resolved
wjhsf
approved these changes
Oct 24, 2024
Comment on lines
+34
to
+49
| const slottedContent = { | ||
| light: Object.create(null), | ||
| shadow: async function* () { | ||
| ${/* shadow slot content */ is.statement} | ||
| } | ||
| }; | ||
| yield* ${is.identifier}(${is.literal}, childProps, childAttrs, childSlottedContentGenerator); | ||
| function addContent(name, fn) { | ||
| let contentList = slottedContent.light[name] | ||
| if (contentList) { | ||
| contentList.push(fn) | ||
| } else { | ||
| slottedContent.light[name] = [fn] | ||
| } | ||
| } | ||
| ${/* addContent statements */ is.callExpression} | ||
| yield* ${is.identifier}(${is.literal}, childProps, childAttrs, slottedContent); |
There was a problem hiding this comment.
Future optimization: dedupe content by changing slottedContent.shadow to be an array and add slottedContent.shadow.push(fn) in addContent. This will require updating the content of the generated functions to conditionally render the slot attribute.
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Mostly implements light DOM slots. We are down to 26 test failures.
We still need to handle light DOM slots not at the top level, but that can wait: #4689.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?