Validate if work is needed for closed TODO issues

[wjhsf]

Currently, we have 33 // TODO^* comments in the codebase that reference 21 issues that have been closed. We should re-visit those comments to assess whether the work has been done, or, if not, whether it is unblocked and/or still something we want to do.

To generate the list of closed issues:

# List all files tracked by git on the master branch
git ls-tree --name-only master -r |\
# Find all TODO [#0000] comments
xargs grep -o 'TODO \[#.*\]' |\
# Extract the issue number from the grep result
sed 's/.*TODO \[#\(.*\)\]/\1/' |\
# Get unique issue numbers
sort | uniq |\
# Query GitHub and print the issue number if the issue is closed
xargs -I% gh issue view --json number,closed -q 'select(.closed)|.number' % |\
# Print to console and save to file
tee closed-todo-issues.txt

^* Technically one is a /* TODO, so keep an eye out for that if you're wielding the regex hammer! Also, issue #1234 is a false positive.

[wjhsf]

I've pushed a branch, todone, which adds a comment // TODO: Is this TODOne? before all of the TODO comments with currently closed issues.

If you don't want to search the codebase yourself, you can run yarn lint and eslint will tell you exactly where those comments are.

[shiladityab24]

@wjhsf

yarn run v1.22.19
$ eslint packages/ scripts/ --ext=js,mjs,ts,only,skip

<--- Last few GCs --->

[9373:0x6aa8000]   409387 ms: Scavenge 2028.4 (2078.6) -> 2022.9 (2080.1) MB, 5.39 / 0.01 ms  (average mu = 0.785, current mu = 0.452) allocation failure;
[9373:0x6aa8000]   409828 ms: Mark-Compact 2032.4 (2087.8) -> 2008.1 (2080.2) MB, 403.45 / 0.01 ms  (average mu = 0.667, current mu = 0.379) allocation failure; scavenge might not succeed
[9373:0x6aa8000]   409930 ms: Scavenge 2019.4 (2083.3) -> 2012.1 (2098.1) MB, 7.06 / 0.00 ms  (average mu = 0.667, current mu = 0.379) allocation failure;


<--- JS stacktrace --->

FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory
----- Native stack trace -----

 1: 0xca5580 node::Abort() [/home/shiladitya/.nvm/versions/node/v20.11.1/bin/node]
 2: 0xb781f9  [/home/shiladitya/.nvm/versions/node/v20.11.1/bin/node]
 3: 0xeca4d0 v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, v8::OOMDetails const&) [/home/shiladitya/.nvm/versions/node/v20.11.1/bin/node]
 4: 0xeca7b7 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, v8::OOMDetails const&) [/home/shiladitya/.nvm/versions/node/v20.11.1/bin/node]
 5: 0x10dc505  [/home/shiladitya/.nvm/versions/node/v20.11.1/bin/node]
 6: 0x10f4388 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/home/shiladitya/.nvm/versions/node/v20.11.1/bin/node]
 7: 0x10ca4a1 v8::internal::HeapAllocator::AllocateRawWithLightRetrySlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/home/shiladitya/.nvm/versions/node/v20.11.1/bin/node]
 8: 0x10cb635 v8::internal::HeapAllocator::AllocateRawWithRetryOrFailSlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/home/shiladitya/.nvm/versions/node/v20.11.1/bin/node]
 9: 0x10a8c86 v8::internal::Factory::NewFillerObject(int, v8::internal::AllocationAlignment, v8::internal::AllocationType, v8::internal::AllocationOrigin) [/home/shiladitya/.nvm/versions/node/v20.11.1/bin/node]
10: 0x1503a16 v8::internal::Runtime_AllocateInYoungGeneration(int, unsigned long*, v8::internal::Isolate*) [/home/shiladitya/.nvm/versions/node/v20.11.1/bin/node]
11: 0x7f2a3f699ef6
Aborted
error Command failed with exit code 134.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

This list was generated from the todone branch using yarn lint command , is this the end of the list or there are more , please correct If I am wrong.

[wjhsf]

That's an error output; running eslint caused the node process to crash. I'm not sure why that would happen; you may want to re-install your dependencies and try again: yarn install && yarn run lint.

In any case, it turns out that I had not actually committed the "TODOne" comments before, but now I have! 🚀

[wjhsf]

Here's a list of all the current TODOs in published packages.

• Make template compiler emit element namespace #1136

  • lwc/packages/@lwc/template-compiler/src/parser/index.ts

    Lines 1716 to 1722 in cab5e41

    	}
    	}
    	// TODO [#1136]: once the template compiler emits the element namespace information to the engine we should
    	// restrict the validation of the "srcdoc" attribute on the "iframe" element only if this element is
    	// part of the HTML namespace.
    	if (tag === 'iframe' && attrName === 'srcdoc') {

• Always mangle frag-id href attribute values #1150

  • lwc/packages/@lwc/template-compiler/src/codegen/codegen.ts

    Lines 129 to 135 in cab5e41

    	* This flag indicates if the generated code should scope the template fragment id. It is set to
    	* true if the template also contains ids.
    	*
    	* TODO [#1150]: Remove this code once we can figure out how to do this in a deterministic
    	* fashion.
    	*/
    	readonly scopeFragmentId: boolean;

• synthetic shadow polyfill #1164

  • lwc/packages/@lwc/engine-core/src/framework/rendering.ts

    Lines 521 to 527 in cab5e41

    	function linkNodeToShadow(elm: Node, owner: VM, renderer: RendererAPI) {
    	const { renderRoot, renderMode, shadowMode } = owner;
    	const { isSyntheticShadowDefined } = renderer;
    	// TODO [#1164]: this should eventually be done by the polyfill directly
    	if (isSyntheticShadowDefined) {
    	if (shadowMode === ShadowMode.Synthetic || renderMode === RenderMode.Light) {
    	(elm as any)[KEY__SHADOW_RESOLVER] = renderRoot[KEY__SHADOW_RESOLVER];

  • lwc/packages/@lwc/synthetic-shadow/src/faux-shadow/shadow-root.ts

    Lines 85 to 91 in cab5e41

    	set(this: Node, fn: ShadowRootResolver | undefined) {
    	if (isUndefined(fn)) return;
    	(this as any)[KEY__SHADOW_RESOLVER_PRIVATE] = fn;
    	// TODO [#1164]: temporary propagation of the key
    	setNodeOwnerKey(this, (fn as any).nodeKey);
    	},
    	get(this: Node): ShadowRootResolver | undefined {

• remove isNodeFromTemplate hacks to expose elements without an ownerKey #1252

  • lwc/packages/@lwc/engine-dom/src/apis/is-node-from-template.ts

    Lines 47 to 53 in cab5e41

    	return true;
    	}
    	// TODO [#1252]: Old behavior that is still used by some pieces of the platform. Manually
    	// inserted nodes without the `lwc:dom=manual` directive will be considered as global elements.
    	return renderer.isSyntheticShadowDefined && !isUndefined((node as any)[KEY__SHADOW_RESOLVER]);
    	}

• refactor lwc:dom="manual" directive to act synchronously #1253

  • lwc/packages/@lwc/synthetic-shadow/src/faux-shadow/portal.ts

    Lines 117 to 123 in cab5e41

    	}
    	// install mutation observer for portals
    	MutationObserverObserve.call(portalObserver, elm, portalObserverConfig);
    	// TODO [#1253]: optimization to synchronously adopt new child nodes added
    	// to this elm, we can do that by patching the most common operations
    	// on the node itself
    	}

• Compiler should provide an indicator to describe whether a vnode is dynamic #1276

  • lwc/packages/@lwc/engine-core/src/framework/api.ts

    Lines 301 to 307 in cab5e41

    	}
    	}
    	if (shadowMode === ShadowMode.Synthetic) {
    	// TODO [#1276]: compiler should give us some sort of indicator when a vnodes collection is dynamic
    	sc(children);
    	}
    	return h('slot', data, children);

  • lwc/packages/@lwc/engine-core/src/framework/api.ts

    Lines 381 to 387 in cab5e41

    	factory: (value: any, index: number, first: boolean, last: boolean) => VNodes | VNode
    	): VNodes {
    	const list: MutableVNodes = [];
    	// TODO [#1276]: compiler should give us some sort of indicator when a vnodes collection is dynamic
    	sc(list);
    	const vmBeingRendered = getVMBeingRendered()!;
    	if (isUndefined(iterable) || iterable === null) {

  • lwc/packages/@lwc/engine-core/src/framework/api.ts

    Lines 478 to 484 in cab5e41

    	}
    	const len = items.length;
    	const flattened: MutableVNodes = [];
    	// TODO [#1276]: compiler should give us some sort of indicator when a vnodes collection is dynamic
    	sc(flattened);
    	for (let j = 0; j < len; j += 1) {
    	const item = items[j];

• [errors] add more context to compiler error messages #1289

  • lwc/packages/@lwc/errors/src/compiler/errors.ts

    Lines 19 to 25 in cab5e41

    	export * from './error-info';
    	// TODO [#1289]: Can be flattened now that we're down to only 2 properties
    	export interface ErrorConfig {
    	messageArgs?: any[];
    	origin?: CompilerDiagnosticOrigin;

  • lwc/packages/@lwc/errors/src/compiler/errors.ts

    Lines 37 to 43 in cab5e41

    	: errorInfo.message;
    	if (errorInfo.url && errorInfo.url !== '') {
    	// TODO [#1289]: Add url info into message
    	}
    	return `LWC${errorInfo.code}: ${message}`;

  • https://github.com/salesforce/lwc/blob/cab5e419494975657246f0543005f4ed521cc139/packages/@lwc/errors/src/compiler/errors.ts#L177-L183

• [engine] move readonly out of the decorators directory #1292

  • lwc/packages/@lwc/engine-core/src/framework/readonly.ts

    Lines 15 to 21 in cab5e41

    	*/
    	export function readonly(obj: any): any {
    	if (process.env.NODE_ENV !== 'production') {
    	// TODO [#1292]: Remove the readonly decorator
    	if (arguments.length !== 1) {
    	logError(
    	'@readonly cannot be used as a decorator just yet, use it as a function with one argument to produce a readonly version of the provided value.'

• [engine] mode should be defined in the Ctor instead of in the vnode function #1294

  • lwc/packages/@lwc/engine-core/src/framework/api.ts

    Lines 366 to 372 in cab5e41

    	ctor: Ctor,
    	owner: vmBeingRendered,
    	mode: 'open', // TODO [#1294]: this should be defined in Ctor
    	aChildren,
    	vm,
    	};

• Make the type property of PropDef an enum #1301

  • lwc/packages/@lwc/engine-core/src/framework/decorators/register.ts

    Lines 43 to 49 in cab5e41

    	interface PropCompilerDef {
    	config: PropType; // 0 m
    	type: string; // TODO [#1301]: make this an enum
    	}
    	interface WireCompilerDef {
    	method?: number;

• [engine] rename $domManual$ to $observerConnection$ #1306

  • lwc/packages/@lwc/synthetic-shadow/src/faux-shadow/portal.ts

    Lines 132 to 138 in cab5e41

    	* - at the moment, there is no way to undo this operation, once the element is
    	* marked as $domManual$, setting it to false does nothing.
    	*/
    	// TODO [#1306]: rename this to $observerConnection$
    	defineProperty(Element.prototype, '$domManual$', {
    	set(this: Element, v: boolean) {
    	(this as any)[DomManualPrivateKey] = v;

• [wire-service] Remove experimental WireContextEvent event name #1357

  • lwc/packages/@lwc/wire-service/src/index.ts

    Lines 191 to 197 in cab5e41

    	const value = evt.value;
    	this.callback(value);
    	} else if (evt.type === 'wirecontextevent') {
    	// TODO [#1357]: remove this branch
    	return this.wiredElementHost.dispatchEvent(evt);
    	} else {
    	throw new Error(`Invalid event type ${(evt as any).type}.`);

• event target is not patched when accessed async and original target is manually injected #1511

  • lwc/packages/@lwc/synthetic-shadow/src/polyfills/event/polyfill.ts

    Lines 48 to 54 in cab5e41

    	// Handle cases where the currentTarget is null (for async events), and when an event has been
    	// added to Window
    	if (!(originalCurrentTarget instanceof Node)) {
    	// TODO [#1511]: Special escape hatch to support legacy behavior. Should be fixed.
    	// If the event's target is being accessed async and originalTarget is not a keyed element, do not retarget
    	if (isNull(originalCurrentTarget) && isUndefined(getNodeOwnerKey(originalTarget))) {
    	return originalTarget;

• Implement lwc:dom="synthetic-portal" #1530

  • lwc/packages/@lwc/synthetic-shadow/src/polyfills/event/polyfill.ts

    Lines 55 to 61 in cab5e41

    	}
    	return retarget(doc, composedPath);
    	} else if (originalCurrentTarget === doc || originalCurrentTarget === doc.body) {
    	// TODO [#1530]: If currentTarget is document or document.body (Third party libraries that have global event listeners)
    	// and the originalTarget is not a keyed element, do not retarget
    	if (isUndefined(getNodeOwnerKey(originalTarget))) {
    	return originalTarget;

• Optimize parentNode and parentElement getters #1635

  • lwc/packages/@lwc/synthetic-shadow/src/faux-shadow/node.ts

    Lines 110 to 116 in cab5e41

    	if (isNull(value)) {
    	return value;
    	}
    	// TODO [#1635]: this needs optimization, maybe implementing it based on this.assignedSlot
    	return getShadowParent(this, value);
    	}

  • lwc/packages/@lwc/synthetic-shadow/src/faux-shadow/node.ts

    Lines 122 to 128 in cab5e41

    	const parentNode = getShadowParent(this, value);
    	// it could be that the parentNode is the shadowRoot, in which case
    	// we need to return null.
    	// TODO [#1635]: this needs optimization, maybe implementing it based on this.assignedSlot
    	return parentNode instanceof Element ? parentNode : null;
    	}

• Remove ambiguity with HTMLSlotElement in childNode getter #1636

  • lwc/packages/@lwc/synthetic-shadow/src/faux-shadow/node.ts

    Lines 181 to 187 in cab5e41

    	return createStaticNodeList(childNodes);
    	}
    	// nothing to do here since this does not have a synthetic shadow attached to it
    	// TODO [#1636]: what about slot elements?
    	return childNodesGetter.call(this);
    	}

• Optimize createKeyToOldIdx #1637

  • lwc/packages/@lwc/engine-core/src/framework/rendering.ts

    Lines 862 to 868 in cab5e41

    	): Record<Key, number> {
    	const map: Record<Key, number> = {};
    	// TODO [#1637]: simplify this by assuming that all vnodes has keys
    	for (let j = beginIdx; j <= endIdx; ++j) {
    	const ch = children[j];
    	if (isVNode(ch)) {

• Unify getComponentStack and getErrorComponentStack #1695

  • lwc/packages/@lwc/engine-core/src/shared/format.ts

    Lines 12 to 18 in cab5e41

    	return `<${StringToLowerCase.call(vm.tagName)}>`;
    	}
    	// TODO [#1695]: Unify getComponentStack and getErrorComponentStack
    	export function getComponentStack(vm: VM): string {
    	const stack: string[] = [];
    	let prefix = '';

• (engine-restrictions) Lift restrictions on addEventListener's options param for host element #1824

  • lwc/packages/@lwc/engine-core/src/framework/restrictions.ts

    Lines 186 to 192 in cab5e41

    	listener: EventListener,
    	options?: boolean | AddEventListenerOptions
    	) {
    	// TODO [#1824]: Potentially relax this restriction
    	if (!isUndefined(options)) {
    	logError(
    	'The `addEventListener` method on ShadowRoot does not support any options.',

  • lwc/packages/@lwc/engine-core/src/framework/restrictions.ts

    Lines 247 to 253 in cab5e41

    	listener: EventListener,
    	options?: boolean | AddEventListenerOptions
    	) {
    	// TODO [#1824]: Potentially relax this restriction
    	if (!isUndefined(options)) {
    	logError(
    	'The `addEventListener` method in `LightningElement` does not support any options.',

  • lwc/packages/@lwc/synthetic-shadow/src/faux-shadow/events.ts

    Lines 204 to 210 in cab5e41

    	listeners = listenerMap[type] = [];
    	}
    	// Prevent identical listeners from subscribing to the same event type.
    	// TODO [#1824]: Options will also play a factor in deduping if we introduce options support
    	if (indexOfManagedListener(listeners, managedListener) !== -1) {
    	return;
    	}

• [HMR] CSS: Provide a mechanism to register stylesheets  #1887

  • lwc/packages/@lwc/engine-core/src/framework/hot-swaps.ts

    Lines 209 to 215 in cab5e41

    	export function swapStyle(oldStyle: StylesheetFactory, newStyle: StylesheetFactory): boolean {
    	if (process.env.NODE_ENV !== 'production') {
    	// TODO [#1887]: once the support for registering styles is implemented
    	// we can add the validation of both styles around this block.
    	swappedStyleMap.set(oldStyle, newStyle);
    	return rehydrateHotStyle(oldStyle);

• Normalize global boolean attrs values passed to custom elements as props #2012

  • lwc/packages/@lwc/template-compiler/src/codegen/expression.ts

    Lines 199 to 205 in cab5e41

    	const expression = codeGen.bindExpression(attrValue);
    	// TODO [#2012]: Normalize global boolean attrs values passed to custom elements as props
    	if (isUsedAsAttribute && isBooleanAttribute(attrName, elmName)) {
    	// We need to do some manipulation to allow the diffing algorithm add/remove the attribute
    	// without handling special cases at runtime.

• Remove cached references to Node constructor #2472

  • lwc/packages/@lwc/engine-dom/src/apis/create-element.ts

    Lines 26 to 32 in cab5e41

    	} from '@lwc/engine-core';
    	import { renderer } from '../renderer';
    	// TODO [#2472]: Remove this workaround when appropriate.
    	// eslint-disable-next-line @lwc/lwc-internal/no-global-node
    	const _Node = Node;

  • lwc/packages/@lwc/engine-dom/src/apis/is-node-from-template.ts

    Lines 14 to 20 in cab5e41

    	} from '@lwc/shared';
    	import { renderer } from '../renderer';
    	// TODO [#2472]: Remove this workaround when appropriate.
    	// eslint-disable-next-line @lwc/lwc-internal/no-global-node
    	const _Node = Node;

  • lwc/packages/@lwc/synthetic-shadow/src/env/node.ts

    Lines 6 to 12 in cab5e41

    	*/
    	import { getOwnPropertyDescriptor, hasOwnProperty } from '@lwc/shared';
    	// TODO [#2472]: Remove this workaround when appropriate.
    	// eslint-disable-next-line @lwc/lwc-internal/no-global-node
    	const _Node = Node;
    	const nodePrototype = _Node.prototype;

• Better system for handling unexpected parse5 errors #2650

  • lwc/packages/@lwc/template-compiler/src/parser/html.ts

    Lines 29 to 35 in cab5e41

    	} else {
    	// It should be impossible to reach here; we have a test in parser.spec.ts to ensure
    	// all error codes are accounted for. But just to be safe, make it a warning.
    	// TODO [#2650]: better system for handling unexpected parse5 errors
    	// eslint-disable-next-line no-console
    	console.warn('Found a Parse5 error that we do not know how to handle:', code);
    	return ParserDiagnostics.INVALID_HTML_SYNTAX_WARNING;

• ARIA reflection polyfill contains non-standard props #2733

  • lwc/packages/@lwc/shared/src/__tests__/html-attributes.spec.ts

    Lines 62 to 68 in cab5e41

    	['role', 'role'],
    	] as StringPair[];
    	// TODO [#2733]: remove non-standard ARIA reflection
    	const nonStandardAriaMapping = [
    	['ariaActiveDescendant', 'aria-activedescendant'],
    	['ariaControls', 'aria-controls'],

• Refactor renderer.getClassList() into renderer.addClass(), renderer.removeClass() #2762

  • lwc/packages/@lwc/engine-core/src/framework/rendering.ts

    Lines 607 to 613 in cab5e41

    	// Set the class name for `*.scoped.css` style scoping.
    	const scopeToken = getScopeTokenClass(owner, /* legacy */ false);
    	if (!isNull(scopeToken)) {
    	// TODO [#2762]: this dot notation with add is probably problematic
    	// probably we should have a renderer api for just the add operation
    	getClassList(elm).add(scopeToken);
    	}

  • lwc/packages/@lwc/engine-core/src/framework/rendering.ts

    Lines 616 to 622 in cab5e41

    	if (lwcRuntimeFlags.ENABLE_LEGACY_SCOPE_TOKENS) {
    	const legacyScopeToken = getScopeTokenClass(owner, /* legacy */ true);
    	if (!isNull(legacyScopeToken)) {
    	// TODO [#2762]: this dot notation with add is probably problematic
    	// probably we should have a renderer api for just the add operation
    	getClassList(elm).add(legacyScopeToken);
    	}

• Freeze the template object #2782

  • lwc/packages/@lwc/engine-core/src/framework/freeze-template.ts

    Lines 242 to 248 in cab5e41

    	}
    	export function freezeTemplate(tmpl: Template) {
    	// TODO [#2782]: remove this flag and delete the legacy behavior
    	if (lwcRuntimeFlags.ENABLE_FROZEN_TEMPLATE) {
    	// Deep freeze the template
    	freeze(tmpl);

• Insert global stylesheets into document.adoptedStyleSheets #2922

  • lwc/packages/@lwc/engine-dom/src/styles.ts

    Lines 163 to 169 in cab5e41

    	}
    	cacheData.global = true; // mark inserted
    	// TODO [#2922]: use document.adoptedStyleSheets in supported browsers. Currently we can't, due to backwards compat.
    	insertStyleElement(content, document.head, cacheData as StyleElementCacheData, signal);
    	}

• Component constructors cannot be new-ed #2970

  • lwc/packages/@lwc/engine-dom/src/custom-elements/create-custom-element.ts

    Lines 48 to 54 in cab5e41

    	if (elementBeingUpgradedByLWC) {
    	upgradeCallback(this);
    	}
    	// TODO [#2970]: LWC elements cannot be upgraded via new Ctor()
    	// Do we want to support this? Throw an error? Currently for backwards compat it's a no-op.
    	}

• Components do not respect observedAttributes/attributeChangedCallback #2972

  • lwc/packages/@lwc/engine-dom/src/custom-elements/create-custom-element.ts

    Lines 31 to 37 in cab5e41

    	// Another benefit is that only LWC can create components that actually do anything – if you do
    	// `customElements.define('x-foo')`, then you don't have access to the upgradeCallback, so it's a dummy custom element.
    	// This class should be created once per tag name.
    	// TODO [#2972]: this class should expose observedAttributes as necessary
    	BaseUpgradableConstructor = class TheBaseUpgradableConstructor extends HTMLElement {
    	constructor(upgradeCallback: LifecycleCallback, useNativeLifecycle: boolean) {
    	super();

• Use html-element-attributes and svg-element-attributes #3019

  • lwc/packages/@lwc/template-compiler/src/parser/utils/html-element-attributes.ts

    Lines 32 to 38 in cab5e41

    	import { hasOwnProperty } from '@lwc/shared';
    	// This mapping is based on https://github.com/wooorm/html-element-attributes/blob/270d8ce/index.js
    	// TODO [#3019]: use the package directly instead of vendor'ing it
    	const HTML_ELEMENT_ATTRIBUTE_MAP = {
    	'*': [
    	'accesskey',

• [Scoped Slots][Doc] Update error message about directives usage restriction to point to external documentation. #3100

  • lwc/packages/@lwc/errors/src/compiler/error-info/template-transform.ts

    Lines 377 to 383 in cab5e41

    	url: '',
    	},
    	// TODO [#3100]: Update message to point to external documentation once available.
    	SLOT_TAG_CANNOT_HAVE_DIRECTIVES: {
    	code: 1082,
    	message: "<slot> tag can't be associated with {0} template directives.",

• [Breaking Change] Remove support for CSS custom property transformation #3266

  • lwc/packages/@lwc/compiler/src/options.ts

    Lines 54 to 60 in cab5e41

    	/**
    	* @deprecated Custom property transforms are deprecated because IE11 and other legacy browsers are no longer supported.
    	*/
    	// TODO [#3266]: Remove StylesheetConfig as part of breaking change wishlist
    	export interface StylesheetConfig {
    	customProperties?: {
    	resolution?: CustomPropertiesResolution;

  • lwc/packages/@lwc/style-compiler/src/transform.ts

    Lines 16 to 22 in cab5e41

    	* CSS custom properties configuration
    	* @deprecated Custom property transforms are deprecated because IE11 and other legacy browsers are no longer supported.
    	*/
    	// TODO [#3266]: Remove StylesheetConfig as part of breaking change wishlist
    	customProperties?: {
    	/** Name of the module to resolve custom properties lookup */
    	resolverModule?: string;

• ARIA reflection polyfill should treat setting undefined the same as null #3284

  • lwc/packages/@lwc/engine-core/src/libs/aria-reflection/aria-reflection.ts

    Lines 29 to 35 in cab5e41

    	return this.getAttribute(attrName);
    	},
    	set(this: HTMLElement, newValue: any) {
    	// TODO [#3284]: there is disagreement between browsers and the spec on how to treat undefined
    	// Our historical behavior is to only treat null as removing the attribute
    	// See also https://github.com/w3c/aria/issues/1858
    	if (isNull(newValue)) {

• Remove usage of lwc:dynamic #3331

  • lwc/packages/@lwc/compiler/src/options.ts

    Lines 91 to 97 in cab5e41

    	namespace?: string;
    	/** @deprecated Ignored by compiler. */
    	stylesheetConfig?: StylesheetConfig;
    	// TODO [#3331]: deprecate / rename this compiler option in 246
    	/** Config applied in usage of dynamic import statements in javascript */
    	experimentalDynamicComponent?: DynamicImportConfig;
    	/** Flag to enable usage of dynamic component(lwc:dynamic) directive in HTML template */

  • lwc/packages/@lwc/engine-core/src/framework/api.ts

    Lines 602 to 608 in cab5e41

    	/**
    	* [ddc] - create a (deprecated) dynamic component via `<x-foo lwc:dynamic={Ctor}>`
    	*
    	* TODO [#3331]: remove usage of lwc:dynamic in 246
    	* @param sel
    	* @param Ctor
    	* @param data

  • lwc/packages/@lwc/engine-core/src/framework/component.ts

    Lines 51 to 57 in cab5e41

    	// on code comments which are stripped out in production by minifiers
    	checkVersionMismatch(Ctor, 'component');
    	}
    	// TODO [#3331]: add validation to check the value of metadata.sel is not an empty string.
    	registeredComponentMap.set(Ctor, metadata);
    	}
    	// chaining this method as a way to wrap existing assignment of component constructor easily,

  • lwc/packages/@lwc/engine-core/src/framework/rendering.ts

    Lines 383 to 389 in cab5e41

    	parent: ParentNode,
    	renderer: RendererAPI
    	) {
    	// TODO [#3331]: This if branch should be removed in 246 with lwc:dynamic
    	if (n1.ctor !== n2.ctor) {
    	// If the constructor differs, unmount the current component and mount a new one using the new
    	// constructor.

  • lwc/packages/@lwc/engine-server/src/__tests__/fixtures.spec.ts

    Lines 26 to 32 in cab5e41

    	async function compileFixture({ input, dirname }: { input: string; dirname: string }) {
    	const modulesDir = path.resolve(dirname, './modules');
    	const outputFile = path.resolve(dirname, './dist/compiled.js');
    	// TODO [#3331]: this is only needed to silence warnings on lwc:dynamic, remove in 246.
    	const warnings: RollupLog[] = [];
    	const bundle = await rollup({

  • lwc/packages/@lwc/engine-server/src/__tests__/fixtures.spec.ts

    Lines 44 to 50 in cab5e41

    	],
    	onwarn(warning, warn) {
    	if (warning.message.includes('LWC1187')) {
    	// TODO [#3331]: The existing lwc:dynamic fixture test will generate warnings that can be safely suppressed.
    	// The warning message is expected and appears when the compiler detects usage of the directive.
    	// We plan to remove the directive in a future release, see #3331 for details.
    	warnings.push(warning);

  • lwc/packages/@lwc/ssr-compiler/src/__tests__/fixtures.spec.ts

    Lines 28 to 34 in cab5e41

    	async function compileFixture({ input, dirname }: { input: string; dirname: string }) {
    	const modulesDir = path.resolve(dirname, './modules');
    	const outputFile = path.resolve(dirname, './dist/compiled-experimental-ssr.js');
    	// TODO [#3331]: this is only needed to silence warnings on lwc:dynamic, remove in 246.
    	const warnings: RollupLog[] = [];
    	const bundle = await rollup({

  • lwc/packages/@lwc/template-compiler/src/config.ts

    Lines 45 to 51 in cab5e41

    	experimentalComplexExpressions?: boolean;
    	/**
    	* TODO [#3331]: remove usage of lwc:dynamic in 246
    	*
    	* Enable lwc:dynamic directive - Deprecated
    	*

  • lwc/packages/@lwc/template-compiler/src/codegen/codegen.ts

    Lines 90 to 96 in cab5e41

    	bind: { name: 'b', alias: 'api_bind' },
    	comment: { name: 'co', alias: 'api_comment' },
    	customElement: { name: 'c', alias: 'api_custom_element' },
    	// TODO [#3331]: remove usage of lwc:dynamic in 246
    	deprecatedDynamicCtor: { name: 'ddc', alias: 'api_deprecated_dynamic_component' },
    	dynamicCtor: { name: 'dc', alias: 'api_dynamic_component' },
    	dynamicText: { name: 'd', alias: 'api_dynamic_text' },

  • lwc/packages/@lwc/template-compiler/src/shared/types.ts

    Lines 329 to 335 in cab5e41

    	export enum ElementDirectiveName {
    	Dom = 'lwc:dom',
    	// TODO [#3331]: remove usage of lwc:dynamic in 246
    	Dynamic = 'lwc:dynamic',
    	Is = 'lwc:is',
    	External = 'lwc:external',

• Remove flag: experimentalComplexExpressions #3370

  • lwc/packages/@lwc/compiler/src/options.ts

    Lines 27 to 33 in cab5e41

    	isExplicitImport: false,
    	preserveHtmlComments: false,
    	enableStaticContentOptimization: true,
    	// TODO [#3370]: remove experimental template expression flag
    	experimentalComplexExpressions: false,
    	disableSyntheticShadowSupport: false,
    	enableLightningWebSecurityTransforms: false,

  • lwc/packages/@lwc/compiler/src/options.ts

    Lines 98 to 104 in cab5e41

    	experimentalDynamicDirective?: boolean;
    	/** Flag to enable usage of dynamic component(lwc:is) directive in HTML template */
    	enableDynamicComponents?: boolean;
    	// TODO [#3370]: remove experimental template expression flag
    	/** Flag to enable use of (a subset of) JavaScript expressions in place of template bindings. Passed to `@lwc/template-compiler`. */
    	experimentalComplexExpressions?: boolean;
    	/** Options to control what output gets generated. */

  • lwc/packages/@lwc/compiler/src/transformers/template.ts

    Lines 35 to 41 in cab5e41

    	): TransformResult {
    	const {
    	experimentalDynamicComponent,
    	// TODO [#3370]: remove experimental template expression flag
    	experimentalComplexExpressions,
    	preserveHtmlComments,
    	enableStaticContentOptimization,

  • lwc/packages/@lwc/compiler/src/transformers/template.ts

    Lines 54 to 60 in cab5e41

    	try {
    	result = compile(src, {
    	experimentalDynamicDirective,
    	// TODO [#3370]: remove experimental template expression flag
    	experimentalComplexExpressions,
    	preserveHtmlComments,
    	enableStaticContentOptimization,

  • lwc/packages/@lwc/errors/src/compiler/error-info/template-transform.ts

    Lines 868 to 874 in cab5e41

    	url: '',
    	},
    	// TODO [#3370]: remove this error if template expressions is removed
    	INVALID_EXPR_ARROW_FN_PARAM: {
    	code: 1189,
    	message: "Template expression doesn't allow {0} in arrow function params.",

  • lwc/packages/@lwc/errors/src/compiler/error-info/template-transform.ts

    Lines 876 to 882 in cab5e41

    	url: '',
    	},
    	// TODO [#3370]: remove this error if template expressions is removed
    	INVALID_EXPR_STATEMENTS_PROHIBITED: {
    	code: 1190,
    	message: 'Statements are disallowed in template expressions.',

  • lwc/packages/@lwc/errors/src/compiler/error-info/template-transform.ts

    Lines 884 to 890 in cab5e41

    	url: '',
    	},
    	// TODO [#3370]: remove this error if template expressions is removed
    	INVALID_EXPR_MUTATION_OUTSIDE_ARROW: {
    	code: 1191,
    	message: 'Field mutations are only permitted within arrow functions.',

  • lwc/packages/@lwc/errors/src/compiler/error-info/template-transform.ts

    Lines 892 to 898 in cab5e41

    	url: '',
    	},
    	// TODO [#3370]: remove this error if template expressions is removed
    	INVALID_EXPR_DELETE_OP: {
    	code: 1192,
    	message: 'Use of the delete operator is prohibited within template expressions.',

  • lwc/packages/@lwc/errors/src/compiler/error-info/template-transform.ts

    Lines 900 to 906 in cab5e41

    	url: '',
    	},
    	// TODO [#3370]: remove this error if template expressions is removed
    	INVALID_EXPR_ARROW_FN_BODY: {
    	code: 1193,
    	message: 'The body of arrow functions in template expressions must be an expression.',

  • lwc/packages/@lwc/errors/src/compiler/error-info/template-transform.ts

    Lines 908 to 914 in cab5e41

    	url: '',
    	},
    	// TODO [#3370]: remove this error if template expressions is removed
    	INVALID_EXPR_ARROW_FN_KIND: {
    	code: 1194,
    	message: 'Arrow functions in template expressions cannot be {0}.',

  • lwc/packages/@lwc/errors/src/compiler/error-info/template-transform.ts

    Lines 916 to 922 in cab5e41

    	url: '',
    	},
    	// TODO [#3370]: remove this error if template expressions is removed
    	INVALID_EXPR_EARLY_STAGE_FEATURE: {
    	code: 1195,
    	message: 'Early-stage JS features are disallowed in template expressions.',

  • lwc/packages/@lwc/errors/src/compiler/error-info/template-transform.ts

    Lines 924 to 930 in cab5e41

    	url: '',
    	},
    	// TODO [#3370]: remove this error if template expressions is removed
    	INVALID_EXPR_PROHIBITED_NODE_TYPE: {
    	code: 1196,
    	message: 'Use of {0} is disallowed within template expressions.',

  • lwc/packages/@lwc/errors/src/compiler/error-info/template-transform.ts

    Lines 932 to 938 in cab5e41

    	url: '',
    	},
    	// TODO [#3370]: remove this error if template expressions is removed
    	INVALID_EXPR_COMMENTS_DISALLOWED: {
    	code: 1197,
    	message: 'Use of comments is disallowed within template expressions.',

  • lwc/packages/@lwc/rollup-plugin/src/index.ts

    Lines 40 to 46 in cab5e41

    	enableDynamicComponents?: boolean;
    	/** The configuration to pass to `@lwc/compiler`. */
    	enableLightningWebSecurityTransforms?: boolean;
    	// TODO [#3370]: remove experimental template expression flag
    	/** The configuration to pass to `@lwc/template-compiler`. */
    	experimentalComplexExpressions?: boolean;
    	/** @deprecated Spread operator is now always enabled. */

  • lwc/packages/@lwc/rollup-plugin/src/index.ts

    Lines 164 to 170 in cab5e41

    	experimentalDynamicDirective,
    	enableDynamicComponents,
    	enableLightningWebSecurityTransforms,
    	// TODO [#3370]: remove experimental template expression flag
    	experimentalComplexExpressions,
    	disableSyntheticShadowSupport,
    	apiVersion,

  • lwc/packages/@lwc/rollup-plugin/src/index.ts

    Lines 329 to 335 in cab5e41

    	experimentalDynamicDirective,
    	enableDynamicComponents,
    	enableLightningWebSecurityTransforms,
    	// TODO [#3370]: remove experimental template expression flag
    	experimentalComplexExpressions,
    	preserveHtmlComments,
    	scopedStyles: scoped,

  • lwc/packages/@lwc/template-compiler/src/config.ts

    Lines 29 to 35 in cab5e41

    	*/
    	experimentalComputedMemberExpression?: boolean;
    	// TODO [#3370]: remove experimental template expression flag
    	/**
    	* Enable use of (a subset of) JavaScript expressions in place of template bindings.
    	* @example

  • lwc/packages/@lwc/template-compiler/src/config.ts

    Lines 94 to 100 in cab5e41

    	'customRendererConfig',
    	'enableLwcSpread',
    	'enableStaticContentOptimization',
    	// TODO [#3370]: remove experimental template expression flag
    	'experimentalComplexExpressions',
    	'experimentalComputedMemberExpression',
    	'experimentalDynamicDirective',

  • lwc/packages/@lwc/template-compiler/src/config.ts

    Lines 161 to 167 in cab5e41

    	return {
    	preserveHtmlComments: false,
    	experimentalComputedMemberExpression: false,
    	// TODO [#3370]: remove experimental template expression flag
    	experimentalComplexExpressions: false,
    	experimentalDynamicDirective: false,
    	enableDynamicComponents: false,

  • lwc/packages/@lwc/template-compiler/src/codegen/codegen.ts

    Lines 534 to 540 in cab5e41

    	}
    	}
    	// TODO [#3370]: remove experimental template expression flag
    	if (this.state.config.experimentalComplexExpressions) {
    	// Cloning here is necessary because `this.replace()` is destructive, and we might use the
    	// node later during static content optimization

  • lwc/packages/@lwc/template-compiler/src/codegen/codegen.ts

    Lines 549 to 555 in cab5e41

    	// Cloning here is necessary because `this.replace()` is destructive, and we might use the
    	// node later during static content optimization
    	expression = doStructuredClone(expression);
    	// TODO [#3370]: when the template expression flag is removed, the
    	// ComplexExpression type should be redefined as an ESTree Node. Doing
    	// so when the flag is still in place results in a cascade of required
    	// type changes across the codebase.

  • lwc/packages/@lwc/template-compiler/src/codegen/expression.ts

    Lines 51 to 57 in cab5e41

    	codeGen: CodeGen
    	): t.Expression {
    	const expressionScopes = new ExpressionScopes();
    	// TODO [#3370]: when the template expression flag is removed, the
    	// ComplexExpression type should be redefined as an ESTree Node. Doing
    	// so when the flag is still in place results in a cascade of required
    	// type changes across the codebase.

  • https://github.com/salesforce/lwc/blob/cab5e419494975657246f0543005f4ed521cc139/packages/@lwc/template-compiler/src/parser/constants.ts#L157-L163

  • lwc/packages/@lwc/template-compiler/src/parser/expression.ts

    Lines 35 to 41 in cab5e41

    	node: t.BaseNode,
    	config: NormalizedConfig
    	): asserts node is Expression {
    	// TODO [#3370]: remove experimental template expression flag
    	if (config.experimentalComplexExpressions) {
    	return validateExpressionAst(node);
    	}

  • lwc/packages/@lwc/template-compiler/src/parser/expression.ts

    Lines 132 to 138 in cab5e41

    	() => {
    	const parsed = parseExpressionAt(source, 1, {
    	ecmaVersion,
    	// TODO [#3370]: remove experimental template expression flag
    	allowAwaitOutsideFunction: ctx.config.experimentalComplexExpressions,
    	});

  • lwc/packages/@lwc/template-compiler/src/parser/html.ts

    Lines 44 to 50 in cab5e41

    	ctx.warnAtLocation(lwcError, sourceLocation(location), [code]);
    	};
    	// TODO [#3370]: remove experimental template expression flag
    	if (ctx.config.experimentalComplexExpressions) {
    	return parseFragment(source, {
    	ctx,

  • lwc/packages/@lwc/template-compiler/src/parser/index.ts

    Lines 493 to 499 in cab5e41

    	return parsedTextNodes;
    	}
    	// TODO [#3370]: remove experimental template expression flag
    	if (ctx.config.experimentalComplexExpressions && isExpression(rawText)) {
    	// Implementation of the lexer ensures that each text-node template expression
    	// will be contained in its own text node. Adjacent static text will be in

  • lwc/packages/@lwc/template-compiler/src/parser/index.ts

    Lines 1800 to 1806 in cab5e41

    	let attrValue: Literal | Expression;
    	// TODO [#3370]: If complex template expressions are adopted, `preparsedJsExpressions`
    	// should be checked. However, to avoid significant complications in the internal types,
    	// arising from supporting both implementations simultaneously, we will re-parse the
    	// expression here when `ctx.config.experimentalComplexExpressions` is true.

  • lwc/packages/@lwc/template-compiler/src/parser/parser.ts

    Lines 95 to 101 in cab5e41

    	*/
    	readonly seenScopedSlots: Set<string> = new Set();
    	// TODO [#3370]: remove experimental template expression flag
    	readonly ecmaVersion: EcmaVersion;
    	// TODO [#3370]: remove experimental template expression flag

  • lwc/packages/@lwc/template-compiler/src/parser/parser.ts

    Lines 98 to 104 in cab5e41

    	// TODO [#3370]: remove experimental template expression flag
    	readonly ecmaVersion: EcmaVersion;
    	// TODO [#3370]: remove experimental template expression flag
    	/**
    	* Parsing of template expressions is deferred to acorn, in order to ensure that JavaScript expressions
    	* are parsed correctly. As such, we should cache the ESTree AST for each expression, so that the

  • lwc/packages/@lwc/template-compiler/src/parser/parser.ts

    Lines 134 to 140 in cab5e41

    	this.config = config;
    	this.renderMode = LWCDirectiveRenderMode.shadow;
    	this.preserveComments = config.preserveHtmlComments;
    	// TODO [#3370]: remove experimental template expression flag
    	if (config.experimentalComplexExpressions) {
    	this.preparsedJsExpressions = new Map();
    	}

  • lwc/packages/@lwc/template-compiler/src/shared/ast.ts

    Lines 149 to 155 in cab5e41

    	export function text(
    	raw: string,
    	// TODO [#3370]: remove experimental template expression flag
    	value: Literal | Expression | ComplexExpression,
    	parse5Location: parse5TokenInfo.Location
    	): Text {

  • lwc/packages/@lwc/template-compiler/src/shared/types.ts

    Lines 62 to 68 in cab5e41

    	export type Expression = Identifier | MemberExpression;
    	// TODO [#3370]: when the template expression flag is removed, the
    	// ComplexExpression type should be redefined as an ESTree Node. Doing
    	// so when the flag is still in place results in a cascade of required
    	// type changes across the codebase.

  • lwc/packages/@lwc/template-compiler/src/shared/types.ts

    Lines 154 to 160 in cab5e41

    	export interface Text extends BaseNode {
    	type: 'Text';
    	// TODO [#3370]: remove experimental template expression flag
    	value: Literal | Expression | ComplexExpression;
    	raw: string;
    	}

  • lwc/packages/@lwc/template-compiler/src/parser/expression-complex/validate.ts

    Lines 126 to 132 in cab5e41

    	export function validateExpressionAst(rootNode: BaseNode) {
    	let arrowFnScopeDepth = 0;
    	// TODO [#3370]: when the template expression flag is removed, the
    	// ComplexExpression type should be redefined as an ESTree Node. Doing
    	// so when the flag is still in place results in a cascade of required
    	// type changes across the codebase.

• Throw error on invalid @track/@api fields #3408

  • lwc/packages/@lwc/engine-core/src/framework/decorators/register.ts

    Lines 85 to 91 in cab5e41

    	const type = getClassDescriptorType(descriptor);
    	const message = `Invalid observed ${fieldName} field. Found a duplicate ${type} with the same name.`;
    	// TODO [#3408]: this should throw, not log
    	logError(message);
    	}
    	}

  • lwc/packages/@lwc/engine-core/src/framework/decorators/register.ts

    Lines 98 to 104 in cab5e41

    	assertNotProd(); // this method should never leak to prod
    	if (!isUndefined(descriptor)) {
    	const type = getClassDescriptorType(descriptor);
    	// TODO [#3408]: this should throw, not log
    	logError(
    	`Invalid @track ${fieldName} field. Found a duplicate ${type} with the same name.`
    	);

  • lwc/packages/@lwc/engine-core/src/framework/decorators/register.ts

    Lines 113 to 119 in cab5e41

    	assertNotProd(); // this method should never leak to prod
    	if (!isUndefined(descriptor)) {
    	const type = getClassDescriptorType(descriptor);
    	// TODO [#3408]: this should throw, not log
    	logError(`Invalid @wire ${fieldName} field. Found a duplicate ${type} with the same name.`);
    	}
    	}

  • lwc/packages/@lwc/engine-core/src/framework/decorators/register.ts

    Lines 142 to 148 in cab5e41

    	const type = getClassDescriptorType(descriptor);
    	const message = `Invalid @api ${fieldName} field. Found a duplicate ${type} with the same name.`;
    	// TODO [#3408]: this should throw, not log
    	logError(message);
    	}
    	}

  • lwc/packages/@lwc/engine-core/src/framework/decorators/register.ts

    Lines 256 to 262 in cab5e41

    	if (method === 1) {
    	if (process.env.NODE_ENV !== 'production') {
    	if (!adapter) {
    	// TODO [#3408]: this should throw, not log
    	logError(
    	`@wire on method "${fieldOrMethodName}": adapter id must be truthy.`
    	);

  • lwc/packages/@lwc/engine-core/src/framework/decorators/register.ts

    Lines 271 to 277 in cab5e41

    	} else {
    	if (process.env.NODE_ENV !== 'production') {
    	if (!adapter) {
    	// TODO [#3408]: this should throw, not log
    	logError(
    	`@wire on field "${fieldOrMethodName}": adapter id must be truthy.`
    	);

• Engine contains decorator assertions that are not reachable #3441

  • lwc/packages/@lwc/engine-core/src/framework/decorators/register.ts

    Lines 125 to 131 in cab5e41

    	) {
    	assertNotProd(); // this method should never leak to prod
    	if (isUndefined(descriptor) || !isFunction(descriptor.value) || isFalse(descriptor.writable)) {
    	// TODO [#3441]: This line of code does not seem possible to reach.
    	logError(
    	`Invalid @wire ${methodName} field. The field should have a valid writable descriptor.`
    	);

  • lwc/packages/@lwc/engine-core/src/framework/decorators/register.ts

    Lines 155 to 161 in cab5e41

    	assertNotProd(); // this method should never leak to prod
    	if (isFunction(descriptor.set)) {
    	if (!isFunction(descriptor.get)) {
    	// TODO [#3441]: This line of code does not seem possible to reach.
    	logError(
    	`Missing getter for property ${fieldName} decorated with @api in ${Ctor}. You cannot have a setter without the corresponding getter.`
    	);

  • lwc/packages/@lwc/engine-core/src/framework/decorators/register.ts

    Lines 161 to 167 in cab5e41

    	);
    	}
    	} else if (!isFunction(descriptor.get)) {
    	// TODO [#3441]: This line of code does not seem possible to reach.
    	logError(`Missing @api get ${fieldName} accessor.`);
    	}
    	}

  • lwc/packages/@lwc/engine-core/src/framework/decorators/register.ts

    Lines 173 to 179 in cab5e41

    	) {
    	assertNotProd(); // this method should never leak to prod
    	if (isUndefined(descriptor) || !isFunction(descriptor.value) || isFalse(descriptor.writable)) {
    	// TODO [#3441]: This line of code does not seem possible to reach.
    	logError(`Invalid @api ${methodName} method.`);
    	}
    	}

  • lwc/packages/@lwc/engine-core/src/framework/decorators/register.ts

    Lines 205 to 211 in cab5e41

    	descriptor = getOwnPropertyDescriptor(proto, fieldName);
    	if (propConfig.config > 0) {
    	if (isUndefined(descriptor)) {
    	// TODO [#3441]: This line of code does not seem possible to reach.
    	throw new Error();
    	}
    	// accessor declaration

• Clean up post-migration TypeScript in @lwc/babel-plugin-component #3444

  • lwc/packages/@lwc/babel-plugin-component/src/dynamic-imports.ts

    Lines 45 to 51 in cab5e41

    	}
    	function addDynamicImportDependency(dependency: string, state: LwcBabelPluginPass) {
    	// TODO [#3444]: state.dynamicImports seems unused and can probably be deleted
    	if (!state.dynamicImports) {
    	state.dynamicImports = [];
    	}

  • lwc/packages/@lwc/babel-plugin-component/src/decorators/wire/validate.ts

    Lines 48 to 54 in cab5e41

    	);
    	}
    	// TODO [#3444]: improve member expression computed typechecking
    	// @ts-expect-error type narrowing incorrectly reduces id to `never`
    	if (isMemberExpression && !id.get('object').isIdentifier()) {
    	throw generateError(

  • lwc/packages/@lwc/babel-plugin-component/src/decorators/wire/validate.ts

    Lines 60 to 66 in cab5e41

    	);
    	}
    	// TODO [#3444]: improve member expression computed typechecking
    	// Ensure wire adapter is imported (check for member expression or identifier)
    	// @ts-expect-error type narrowing incorrectly reduces id to `never`
    	const wireBinding = isMemberExpression ? id.node.object.name : id.node.name;

• Move validation of <style> contents to compilation #3454

  • lwc/packages/@lwc/engine-server/src/serializer.ts

    Lines 108 to 114 in cab5e41

    	if (tagName === 'style') {
    	// Special validation for <style> tags since their content must be served unescaped, and we need to validate
    	// that the contents are safe to serialize unescaped.
    	// TODO [#3454]: move this validation to compilation
    	validateStyleTextContents(contents);
    	// If we haven't thrown an error during validation, then the content is safe to serialize unescaped
    	return contents;

• [Perf] Fine-grained reactivity #3624

  • lwc/packages/@lwc/engine-core/src/framework/template.ts

    Lines 314 to 320 in cab5e41

    	// This is why in the browser we provide the entire class attribute and in SSR we only provide the class token.
    	const exprClassToken = process.env.IS_BROWSER ? classAttrToken : classToken;
    	// TODO [#3624]: The implementation of this function should be specific to @lwc/engine-dom and @lwc/engine-server.
    	// Find a way to split this in a future refactor.
    	const serializeExpression = buildSerializeExpressionFn(parts);

  • lwc/packages/@lwc/template-compiler/src/codegen/static-element.ts

    Lines 88 to 94 in cab5e41

    	const isStaticSafeExpression =
    	isExpression(value) &&
    	name !== 'slot' &&
    	// TODO [#3624]: Revisit whether svgs can be included in static content optimization
    	// svg href needs sanitization.
    	!isSvgUseHref(nodeName, name, namespace);
    	return isStaticSafeLiteral || isStaticSafeExpression;

• Remove support for legacy stylesheet scope tokens #3733

  • lwc/packages/@lwc/compiler/src/transformers/template.ts

    Lines 76 to 82 in cab5e41

    	// thrown above. As for "Log" and "Fatal", they are currently unused.
    	const warnings = result.warnings.filter((_) => _.level === DiagnosticLevel.Warning);
    	// TODO [#3733]: remove support for legacy scope tokens
    	const { scopeToken, legacyScopeToken } = generateScopeTokens(filename, namespace, name);
    	// Rollup only cares about the mappings property on the map. Since producing a source map for

  • lwc/packages/@lwc/engine-core/src/framework/rendering.ts

    Lines 612 to 618 in cab5e41

    	getClassList(elm).add(scopeToken);
    	}
    	// TODO [#3733]: remove support for legacy scope tokens
    	if (lwcRuntimeFlags.ENABLE_LEGACY_SCOPE_TOKENS) {
    	const legacyScopeToken = getScopeTokenClass(owner, /* legacy */ true);
    	if (!isNull(legacyScopeToken)) {

  • lwc/packages/@lwc/engine-core/src/framework/stylesheet.ts

    Lines 96 to 102 in cab5e41

    	);
    	}
    	// TODO [#3733]: remove support for legacy scope tokens
    	export function updateStylesheetToken(vm: VM, template: Template, legacy: boolean) {
    	const {
    	elm,

  • lwc/packages/@lwc/engine-core/src/framework/stylesheet.ts

    Lines 288 to 294 in cab5e41

    	* @param owner
    	* @param legacy
    	*/
    	// TODO [#3733]: remove support for legacy scope tokens
    	export function getScopeTokenClass(owner: VM, legacy: boolean): string | null {
    	const { cmpTemplate, context } = owner;
    	return (

  • lwc/packages/@lwc/engine-core/src/framework/template.ts

    Lines 58 to 64 in cab5e41

    	/** The string used for synthetic shadow style scoping and light DOM style scoping. */
    	stylesheetToken?: string;
    	/** Same as the above, but for legacy use cases (pre-LWC v3.0.0) */
    	// TODO [#3733]: remove support for legacy scope tokens
    	legacyStylesheetToken?: string;
    	/** Render mode for the template. Could be light or undefined (which means it's shadow) */
    	renderMode?: 'light';

  • lwc/packages/@lwc/engine-core/src/framework/vm.ts

    Lines 112 to 118 in cab5e41

    	/** True if a stylesheetToken was added to the host attributes */
    	hasTokenInAttribute: boolean | undefined;
    	/** The legacy string used for synthetic shadow DOM and light DOM style scoping. */
    	// TODO [#3733]: remove support for legacy scope tokens
    	legacyStylesheetToken: string | undefined;
    	/** True if a legacyStylesheetToken was added to the host class */
    	hasLegacyTokenInClass: boolean | undefined;

  • lwc/packages/@lwc/features/src/types.ts

    Lines 57 to 63 in cab5e41

    	* If true, render legacy CSS scope tokens in addition to the modern CSS scope tokens. This is designed
    	* for cases where backwards compat is required (e.g. global stylesheets using these tokens in their selectors).
    	*/
    	// TODO [#3733]: remove support for legacy scope tokens
    	ENABLE_LEGACY_SCOPE_TOKENS: FeatureFlagValue;
    	/**
    	* If true, enable experimental shadow DOM migration mode globally.

  • lwc/packages/@lwc/shared/src/keys.ts

    Lines 11 to 17 in cab5e41

    	export const KEY__SHADOW_STATIC_PRIVATE = '$shadowStaticNodeKey$';
    	export const KEY__SHADOW_TOKEN = '$shadowToken$';
    	export const KEY__SHADOW_TOKEN_PRIVATE = '$$ShadowTokenKey$$';
    	// TODO [#3733]: remove support for legacy scope tokens
    	export const KEY__LEGACY_SHADOW_TOKEN = '$legacyShadowToken$';
    	export const KEY__LEGACY_SHADOW_TOKEN_PRIVATE = '$$LegacyShadowTokenKey$$';
    	export const KEY__SYNTHETIC_MODE = '$$lwc-synthetic-mode';

  • lwc/packages/@lwc/synthetic-shadow/src/faux-shadow/legacy-shadow-token.ts

    Lines 4 to 10 in cab5e41

    	* SPDX-License-Identifier: MIT
    	* For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
    	*/
    	// TODO [#3733]: remove this entire file when we can remove legacy scope tokens
    	import {
    	defineProperty,
    	isUndefined,

  • lwc/packages/@lwc/synthetic-shadow/src/faux-shadow/portal.ts

    Lines 31 to 37 in cab5e41

    	childList: true,
    	};
    	// TODO [#3733]: remove support for legacy scope tokens
    	function adoptChildNode(
    	node: Node,
    	fn: ShadowRootResolver,

• Components that do not extend LightningElement should get dev warnings for missing @api #3761

  • lwc/packages/@lwc/engine-core/src/framework/base-bridge-element.ts

    Lines 151 to 157 in cab5e41

    	// present a hint message so that developers are aware that they have not decorated property with @api
    	if (process.env.NODE_ENV !== 'production') {
    	// TODO [#3761]: enable for components that don't extend from LightningElement
    	if (!isUndefined(proto) && !isNull(proto) && !hasCustomSuperClass) {
    	const nonPublicPropertiesToWarnOn = new Set(
    	[

• @wire computed properties should be restricted to values that cannot change #3956

  • lwc/packages/@lwc/babel-plugin-component/src/decorators/wire/validate.ts

    Lines 111 to 117 in cab5e41

    	if (key.isIdentifier()) {
    	// Only allow identifiers that originated from a `const` declaration
    	const binding = key.scope.getBinding(key.node.name);
    	// TODO [#3956]: Investigate allowing imported constants
    	if (binding?.kind === 'const') continue;
    	// By default, the identifier `undefined` has no binding (when it's actually undefined),
    	// but has a binding if it's used as a variable (e.g. `let undefined = "don't do this"`)

  • lwc/packages/@lwc/babel-plugin-component/src/decorators/wire/validate.ts

    Lines 121 to 127 in cab5e41

    	if (key.isTemplateLiteral()) {
    	// A template literal is not guaranteed to always result in the same value
    	// (e.g. `${Math.random()}`), so we disallow them entirely.
    	// TODO [#3956]: Investigate allowing template literals
    	throw generateError(
    	key,
    	{

  • lwc/packages/@lwc/babel-plugin-component/src/__tests__/fixtures/wire-decorator/transforms-computed-properties-const-from-obj/actual.js

    Lines 9 to 15 in cab5e41

    	const { baz } = obj
    	const quux = obj.quux
    	// TODO [#3956]: Investigate whether we really want to support this
    	export default class Test extends LightningElement {
    	@wire(getFoo, {
    	[foo]: '$foo',

  • lwc/packages/@lwc/babel-plugin-component/src/__tests__/fixtures/wire-decorator/transforms-computed-properties-const-from-obj/expected.js

    Lines 15 to 21 in cab5e41

    	} = obj;
    	const quux = obj.quux;
    	// TODO [#3956]: Investigate whether we really want to support this
    	class Test extends LightningElement {
    	wiredIdentifier;
    	/*LWC compiler vX.X.X*/

• Completely remove support for shadowSupportMode="any" #3971

  • lwc/packages/@lwc/engine-core/src/framework/def.ts

    Lines 132 to 138 in cab5e41

    	);
    	}
    	// TODO [#3971]: Completely remove shadowSupportMode "any"
    	if (ctorShadowSupportMode === ShadowSupportMode.Any) {
    	logWarn(
    	`Invalid value 'any' for static property shadowSupportMode. 'any' is deprecated and will be removed in a future release--use 'native' instead.`

• Evaluate how to handle invalid unsubscribe functions produced by signal.subscribe #3978

  • lwc/packages/@lwc/engine-core/src/libs/signal-tracker/index.ts

    Lines 61 to 67 in cab5e41

    	try {
    	const unsubscribe = signal.subscribe(update);
    	if (isFunction(unsubscribe)) {
    	// TODO [#3978]: Evaluate how we should handle the case when unsubscribe is not a function.
    	// Long term we should throw an error or log a warning.
    	this.signalToUnsubscribeMap.set(signal, unsubscribe);
    	}

• Add a 'name' field to the ShadowSupportModePayload #3981

  • lwc/packages/@lwc/engine-core/src/framework/reporting.ts

    Lines 52 to 58 in cab5e41

    	mode: ShadowMode;
    	}
    	// TODO [#3981]: Add schema to o11y schema repo so that we can use 'ctorName' or 'name'
    	// instead of overloading 'tagName'.
    	export interface ShadowSupportModeUsagePayload extends BasePayload {
    	mode: ShadowSupportMode;

• Move databag parsing after gathering static elements. #4077

  • lwc/packages/@lwc/template-compiler/src/codegen/index.ts

    Lines 80 to 86 in cab5e41

    	function transform(codeGen: CodeGen): t.Expression {
    	const instrumentation = codeGen.state.config.instrumentation;
    	function transformElement(element: BaseElement, slotParentName?: string): t.Expression {
    	// TODO [#4077]: Move databag gathering to after static element check as it doesn't seem to be used by static
    	// content optimization.
    	const databag = elementDataBag(element, slotParentName);

• Discrepancy between @lwc/engine-dom and @lwc/engine-server static parts application #4078

  • lwc/packages/@lwc/engine-core/src/framework/template.ts

    Lines 134 to 140 in cab5e41

    	};
    	// This function serializes the expressions generated by static content optimization.
    	// Currently this is only needed for SSR.
    	// TODO [#4078]: Split the implementation between @lwc/engine-dom and @lwc/engine-server
    	function buildSerializeExpressionFn(parts?: VStaticPart[]) {
    	if (process.env.IS_BROWSER) {
    	return browserExpressionSerializer;

• [HMR] swap* APIs show stale content when swapping back and forth multiple times #4154

  • lwc/packages/@lwc/engine-core/src/framework/hot-swaps.ts

    Lines 101 to 107 in cab5e41

    	export function getTemplateOrSwappedTemplate(tpl: Template): Template {
    	assertNotProd(); // this method should never leak to prod
    	// TODO [#4154]: shows stale content when swapping content back and forth multiple times
    	const visited: Set<Template> = new Set();
    	while (swappedTemplateMap.has(tpl) && !visited.has(tpl)) {
    	visited.add(tpl);

  • lwc/packages/@lwc/engine-core/src/framework/hot-swaps.ts

    Lines 116 to 122 in cab5e41

    	): LightningElementConstructor {
    	assertNotProd(); // this method should never leak to prod
    	// TODO [#4154]: shows stale content when swapping content back and forth multiple times
    	const visited: Set<LightningElementConstructor> = new Set();
    	while (swappedComponentMap.has(Ctor) && !visited.has(Ctor)) {
    	visited.add(Ctor);

  • lwc/packages/@lwc/engine-core/src/framework/hot-swaps.ts

    Lines 129 to 135 in cab5e41

    	export function getStyleOrSwappedStyle(style: StylesheetFactory): StylesheetFactory {
    	assertNotProd(); // this method should never leak to prod
    	// TODO [#4154]: shows stale content when swapping content back and forth multiple times
    	const visited: Set<StylesheetFactory> = new Set();
    	while (swappedStyleMap.has(style) && !visited.has(style)) {
    	visited.add(style);

• [HMR] swapStyle() API does not account for stylesheet collisions #4155

  • lwc/packages/@lwc/engine-dom/src/styles.ts

    Lines 102 to 108 in cab5e41

    	if (isUndefined(signal)) {
    	throw new Error('Expected AbortSignal to be defined in dev mode');
    	}
    	// TODO [#4155]: unrendering should account for stylesheet content collisions
    	signal.addEventListener('abort', () => {
    	adoptedStyleSheets.splice(adoptedStyleSheets.indexOf(stylesheet), 1);
    	stylesheetCache.delete(content);

  • lwc/packages/@lwc/engine-dom/src/styles.ts

    Lines 124 to 130 in cab5e41

    	if (isUndefined(signal)) {
    	throw new Error('Expected AbortSignal to be defined in dev mode');
    	}
    	// TODO [#4155]: unrendering should account for stylesheet content collisions
    	signal.addEventListener('abort', () => {
    	target.removeChild(elm);
    	stylesheetCache.delete(content);