Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[template-compiler] Normalize parse5.Element's sourceCodeLocation field and update it inline #3108

Open
ravijayaramappa opened this issue Oct 13, 2022 · 0 comments
Labels
Up for grabs Issues that are relatively small, self-contained, and ready for implementation

Comments

@ravijayaramappa
Copy link
Contributor

Description

The template-compiler's parseElement routine normalizes the parse5 element's sourceCodeLocation and creates a new parse5.ElementLocation which is then reused in the rest of the routine.

This bug to update the sourceCodeLocation of the original element and look up the location from that. This will avoid passing both the parse5ElmLocation and parse5Elm

const parse5ElmLocation = parseElementLocation(ctx, parse5Elm, parse5ParentLocation);

@nolanlawson nolanlawson added the Up for grabs Issues that are relatively small, self-contained, and ready for implementation label Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Up for grabs Issues that are relatively small, self-contained, and ready for implementation
Projects
None yet
Development

No branches or pull requests

2 participants