Skip to content

Commit f0a3746

Browse files
committed
fix: move createCustomElement out of the renderer factory
1 parent a54d697 commit f0a3746

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

packages/@lwc/engine-dom/src/renderer-factory.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,10 @@ import type { RendererAPI } from '@lwc/engine-core';
2222
// are omitted here
2323
export type SandboxableRendererAPI = Omit<
2424
RendererAPI,
25-
'insertStylesheet' | 'isNativeShadowDefined' | 'isSyntheticShadowDefined'
25+
| 'createCustomElement'
26+
| 'insertStylesheet'
27+
| 'isNativeShadowDefined'
28+
| 'isSyntheticShadowDefined'
2629
>;
2730

2831
export type RendererAPIType<Type> = Type extends RendererAPI ? RendererAPI : SandboxableRendererAPI;

packages/@lwc/engine-dom/src/renderer.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import {
1313
KEY__SHADOW_TOKEN,
1414
} from '@lwc/shared';
1515
import { insertStylesheet } from './styles';
16+
import { createCustomElement } from './custom-elements/create-custom-element';
1617
import { rendererFactory } from './renderer-factory';
1718

1819
import type { RendererAPI } from '@lwc/engine-core';
@@ -29,6 +30,8 @@ export const renderer: RendererAPI = assign(
2930
{
3031
// insertStyleSheet implementation shares a global cache of stylesheet data
3132
insertStylesheet,
33+
// relies on a shared global cache
34+
createCustomElement,
3235
isNativeShadowDefined: globalThis[KEY__IS_NATIVE_SHADOW_ROOT_DEFINED],
3336
isSyntheticShadowDefined: hasOwnProperty.call(Element.prototype, KEY__SHADOW_TOKEN),
3437
}

packages/@lwc/engine-dom/src/renderer/index.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
*/
77

88
import { assert, isNull, isUndefined } from '@lwc/shared';
9-
import { createCustomElement } from '../custom-elements/create-custom-element';
109

1110
function cloneNode(node: Node, deep: boolean): Node {
1211
return node.cloneNode(deep);
@@ -276,5 +275,4 @@ export {
276275
getLastElementChild,
277276
isConnected,
278277
assertInstanceOfHTMLElement,
279-
createCustomElement,
280278
};

0 commit comments

Comments
 (0)