Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new salesforce site scoped module for default language (@W-12984619) #181

Merged
merged 1 commit into from
May 12, 2023

Conversation

nolanlawson
Copy link
Contributor

Same as #180, but with just the non-stylistic changes.

@Fatema-Saifee Could you please take a look at this PR and +1?

If you'd like to make the stylistic changes, we can do them in a separate PR, ideally with ESLint/Prettier so that the styling is applied automatically.

@salesforce-cla
Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Fatema Saifee <f***@f***.i***.s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated.

…12984619)

Co-authored-by: Fatema Saifee <fatema.saifee@fatemas-ltmrjdw.internal.salesforce.com>
@nolanlawson
Copy link
Contributor Author

I made myself the main author and Fatema the co-author so that the cla-bot would stop complaining. Let me know @Fatema-Saifee if you'd like to change the author name/email.

@nolanlawson
Copy link
Contributor Author

Fatema OK'd this in Slack

@nolanlawson nolanlawson merged commit 7f510f7 into master May 12, 2023
@nolanlawson nolanlawson deleted the nolan/site-scoped-just-changes branch May 12, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants