feat: add new salesforce site scoped module for default language (@W-12984619) #180
Conversation
|
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Fatema Saifee <f***@f***.i***.s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated. |
|
Thanks for the PR! Could you please separate the stylistic changes from the functional changes? |
| @@ -139,3 +139,28 @@ describe('@salesforce/site/activeLanguages import', () => { | |||
| 'Invalid import from @salesforce/site/activeLanguages' | |||
| ); | |||
| }); | |||
|
|
|||
| describe('@salesforce/site/defaultLanguage import', () => { | |||
There was a problem hiding this comment.
@nolanlawson This is where the tests for defaultLanguage test are added!
| @@ -20,6 +20,27 @@ const siteActiveLanguagesTemplate = babelTemplate(` | |||
| } | |||
| `); | |||
|
|
|||
| const siteDefaultLanguagesTemplate = babelTemplate(` | |||
There was a problem hiding this comment.
@nolanlawson here are the changes for adding it to the import config!
@nolanlawson I have commented on the 2 files where the functional changes are added. Rest all files have stylistic changes. I hope this is a bit clearer now! |
|
Closing in favor of #181 |
Adding the site/defaultLanguage scoped module.
Awaits the corresponding PRs to lwc repos.
✅ Request:
✅ Spec: https://salesforce.quip.com/1v2yASgA0Lyf