Skip to content

Commit

Permalink
Warn about facebook#871 until it's actually fixed.
Browse files Browse the repository at this point in the history
facebook#871 is still an issue on the latest version of react-scripts (1.1.4 at time of writing).

Rather than having people eventually find this issue and waste time, be more helpful and provide a note in the readme so people are aware this is an issue and don't waste time.

create-react-app is great for people that are learning react and this issue affects them negatively.

This note can be removed once the issue is fixed.
  • Loading branch information
saimonmoore authored May 21, 2018
1 parent 0dfc6f6 commit d581f0a
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions packages/react-scripts/template/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1378,6 +1378,8 @@ The watcher includes an interactive command-line interface with the ability to r

![Jest watch mode](http://facebook.github.io/jest/img/blog/15-watch.gif)

(If you are on OSX and running into errors about `FSEvents` when running tests then [install watchman](https://github.com/facebook/create-react-app/issues/871))

### Version Control Integration

By default, when you run `npm test`, Jest will only run the tests related to files changed since the last commit. This is an optimization designed to make your tests run fast regardless of how many tests you have. However it assumes that you don’t often commit the code that doesn’t pass the tests.
Expand Down

0 comments on commit d581f0a

Please sign in to comment.