Skip to content

Commit 3ab62e6

Browse files
authored
Fix Issue 76 (CMake install dir) (cpp-redis#79)
* try fix cpp-redis#76 by using add_subdirectory instead of external project and disabling test/example builds forwarding to tacopie. * fix build
1 parent 0b9c6d9 commit 3ab62e6

File tree

1 file changed

+16
-23
lines changed

1 file changed

+16
-23
lines changed

CMakeLists.txt

Lines changed: 16 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ ENDIF (WIN32)
7777
# variables
7878
###
7979
set(CPP_REDIS_INCLUDES ${PROJECT_SOURCE_DIR}/includes)
80-
set(DEPS_INCLUDES ${PROJECT_SOURCE_DIR}/deps/include)
80+
set(DEPS_INCLUDES ${PROJECT_SOURCE_DIR}/deps/include tacopie/includes)
8181
set(DEPS_LIBRARIES ${PROJECT_SOURCE_DIR}/deps/lib)
8282

8383

@@ -159,35 +159,18 @@ ENDIF (USE_CUSTOM_TCP_CLIENT)
159159
install(DIRECTORY DESTINATION ${CMAKE_BINARY_DIR}/lib/)
160160
install(DIRECTORY DESTINATION ${CMAKE_BINARY_DIR}/bin/)
161161
# install cpp_redis
162-
install (DIRECTORY ${CMAKE_BINARY_DIR}/lib/ DESTINATION lib USE_SOURCE_PERMISSIONS)
163-
install (DIRECTORY ${CMAKE_BINARY_DIR}/bin/ DESTINATION bin USE_SOURCE_PERMISSIONS)
164-
install (DIRECTORY ${CPP_REDIS_INCLUDES}/ DESTINATION include USE_SOURCE_PERMISSIONS)
165-
166-
167-
###
168-
# tacopie
169-
###
170-
IF (NOT USE_CUSTOM_TCP_CLIENT)
171-
# Path to tacopie
172-
set(TACOPIE_CMAKE_ARGS "-DCMAKE_INSTALL_PREFIX=${PROJECT_SOURCE_DIR}/deps")
173-
# For windows, forward the runtime environment configuration
174-
IF (WIN32)
175-
set(TACOPIE_CMAKE_ARGS ${TACOPIE_CMAKE_ARGS} "-DMSVC_RUNTIME_LIBRARY_CONFIG=${MSVC_RUNTIME_LIBRARY_CONFIG}")
176-
ENDIF (WIN32)
177-
178-
# Add tacopie as dependency
179-
ExternalProject_Add("tacopie"
180-
GIT_SUBMODULES ""
181-
CMAKE_ARGS ${TACOPIE_CMAKE_ARGS}
182-
SOURCE_DIR "${PROJECT_SOURCE_DIR}/tacopie")
183-
ENDIF (NOT USE_CUSTOM_TCP_CLIENT)
162+
install(DIRECTORY ${CMAKE_BINARY_DIR}/lib/ DESTINATION lib USE_SOURCE_PERMISSIONS)
163+
install(DIRECTORY ${CMAKE_BINARY_DIR}/bin/ DESTINATION bin USE_SOURCE_PERMISSIONS)
164+
install(DIRECTORY ${CPP_REDIS_INCLUDES}/ DESTINATION include USE_SOURCE_PERMISSIONS)
184165

185166

186167
###
187168
# examples
188169
###
189170
IF (BUILD_EXAMPLES)
190171
add_subdirectory(examples)
172+
# Reset variable to false to ensure tacopie does no build examples
173+
set (BUILD_EXAMPLES false)
191174
ENDIF(BUILD_EXAMPLES)
192175

193176
###
@@ -198,4 +181,14 @@ IF (BUILD_TESTS)
198181
ExternalProject_Add("googletest"
199182
GIT_REPOSITORY "https://github.com/google/googletest.git"
200183
CMAKE_ARGS "-DCMAKE_INSTALL_PREFIX=${PROJECT_SOURCE_DIR}/deps")
184+
# Reset variable to false to ensure tacopie does no build tests
185+
set (BUILD_TESTS false)
201186
ENDIF(BUILD_TESTS)
187+
188+
189+
###
190+
# tacopie
191+
###
192+
IF (NOT USE_CUSTOM_TCP_CLIENT)
193+
add_subdirectory(tacopie)
194+
ENDIF (NOT USE_CUSTOM_TCP_CLIENT)

0 commit comments

Comments
 (0)