Use ES6. Fixed connect listener never being called.

Author: randunel

.gitignore

@@ -0,0 +1,3 @@
+node_modules
+build
+

.jshintrc

@@ -0,0 +1,17 @@
+{
+    "esnext": true,
+    "node": true,
+    "unused": true,
+    "undef": true,
+    "newcap": false,
+    "varstmt": true,
+    "predef": [
+        "describe",
+        "it",
+        "beforeEach",
+        "before",
+        "afterEach",
+        "after"
+    ]
+}
+

examples/client.js

@@ -0,0 +1,17 @@
+'use strict';
+const abs = require('./lib/abstract_socket');
+
+const client = abs.connect('\0foo2', function() { //'connect' listener
+    console.log('client connected');
+});
+
+client.on('data', function(data) {
+    console.log(data.toString());
+});
+
+process.stdin.setEncoding('utf8');
+process.stdin.on('readable', function() {
+    const chunk = process.stdin.read();
+    if (chunk !== null)
+        client.write(chunk);
+});

examples/server.js

@@ -0,0 +1,14 @@
+'use strict';
+
+const abs = require('./lib/abstract_socket');
+
+const server = abs.createServer(function(c) { //'connection' listener
+    console.log('client connected');
+    c.on('end', function() {
+        console.log('client disconnected');
+    });
+    c.write('hello\r\n');
+    c.pipe(c);
+});
+server.listen('\0foo2');
+

lib/abstract_socket.js

@@ -1,57 +1,56 @@
+'use strict';
 
-var net = require('net');
-var util = require('util');
-var binding = require('bindings')('abstract_socket.node');
+const net = require('net');
+const binding = require('bindings')('abstract_socket.node');
 
-var socket  = binding.socket;
-var bind    = binding.bind;
-var connect = binding.connect;
-var close   = binding.close;
+const socket  = binding.socket;
+const bind    = binding.bind;
+const connect = binding.connect;
+const close   = binding.close;
 
 
 function errnoException(errorno, syscall) {
     // TODO: having the errno message here would be nice
-    var e = new Error(syscall + ' ' + errorno);
+    const e = new Error(syscall + ' ' + errorno);
     e.errno = e.code = errorno;
     e.syscall = syscall;
     return e;
 }
 
+class AbstractSocketServer extends net.Server {
+    constructor(listener) {
+        super(listener);
+    }
 
-function AbstractSocketServer(connectionListener) {
-    net.Server.call(this, connectionListener);
-}
-util.inherits(AbstractSocketServer, net.Server);
-
+    listen(name, listener) {
+        let err = socket();
+        if (err < 0) {
+            throw errnoException(err, 'socket');
+        }
 
-AbstractSocketServer.prototype.listen = function(name, listeningListener) {
-    var err = socket();
-    if (err < 0)
-        throw errnoException(err, 'socket');
+        const handle = {fd: err};
 
-    var handle = {fd: err};
-
-    err = bind(err, name);
-    if (err < 0) {
-        close(handle.fd);
-        throw errnoException(err, 'bind');
+        err = bind(err, name);
+        if (err < 0) {
+            close(handle.fd);
+            throw errnoException(err, 'bind');
+        }
+        super.listen(handle, listener);
     }
+}
 
-    net.Server.prototype.listen.call(this, handle, listeningListener);
-};
-
-
-exports.createServer = function(connectionListener) {
-    return new AbstractSocketServer(connectionListener);
+exports.createServer = function(listener) {
+    return new AbstractSocketServer(listener);
 };
 
 
-exports.connect = function(name, connectListener) {
-    var err = socket();
-    if (err < 0)
+exports.connect = exports.createConnection = function(name, connectListener) {
+    let err = socket();
+    if (err < 0) {
         throw errnoException(err, 'socket');
+    }
 
-    var options = {fd: err, readable: true, writable: true};
+    const options = {fd: err, readable: true, writable: true};
 
     // yes, connect is synchronous, so sue me
     err = connect(err, name);
@@ -60,8 +59,8 @@ exports.connect = function(name, connectListener) {
         throw errnoException(err, 'connect');
     }
 
-    return new net.Socket(options);
+    const sock = new net.Socket(options);
+    setImmediate(() => connectListener(sock));
+    return sock;
 };
 
-exports.createConnection = exports.connect;
-

package.json

@@ -1,27 +1,28 @@
 {
-  "author": {
-    "name": "Saúl Ibarra Corretgé",
-    "email": "saghul@gmail.com",
-    "url": "http://bettercallsaghul.com"
-  },
-  "name": "abstract-socket",
-  "version": "1.1.0",
-  "description": "Abstract domain socket support for Node / io.js",
-  "main": "lib/abstract_socket",
-  "homepage": "https://github.com/saghul/node-abstractsocket",
-  "license": "MIT",
-  "repository": {
-    "type": "git",
-    "url": "git://github.com/saghul/node-abstractsocket.git"
-  },
-  "engines": {
-    "node": ">=0.10.0"
-  },
-  "dependencies": {
-    "bindings": "^1.2.1",
-    "nan": "^2.0.9"
-  },
-  "os": [
-    "linux"
-  ]
+    "author": {
+        "name": "Saúl Ibarra Corretgé",
+        "email": "saghul@gmail.com",
+        "url": "http://bettercallsaghul.com"
+    },
+    "name": "abstract-socket",
+    "version": "1.1.0",
+    "description": "Abstract domain socket support for Node / io.js",
+    "main": "lib/abstract_socket",
+    "homepage": "https://github.com/saghul/node-abstractsocket",
+    "license": "MIT",
+    "repository": {
+        "type": "git",
+        "url": "git://github.com/saghul/node-abstractsocket.git"
+    },
+    "engines": {
+        "node": ">=0.10.0"
+    },
+    "dependencies": {
+        "bindings": "^1.2.1",
+        "nan": "^2.0.9"
+    },
+    "os": [
+        "linux"
+    ]
 }
+