Skip to content

Commit 628578b

Browse files
randunelsaghul
authored andcommitted
Client emits error instead of throwing.
1 parent e36af97 commit 628578b

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

lib/abstract_socket.js

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,20 +43,28 @@ exports.createServer = function(listener) {
4343
return new AbstractSocketServer(listener);
4444
};
4545

46-
4746
exports.connect = exports.createConnection = function(name, connectListener) {
47+
const defaultOptions = {
48+
readable: true,
49+
writable: true
50+
};
51+
4852
let err = socket();
4953
if (err < 0) {
50-
throw errnoException(err, 'socket');
54+
const sock = new net.Socket(defaultOptions);
55+
setImmediate(() => sock.emit('error', errnoException(err, 'socket')));
56+
return sock;
5157
}
5258

53-
const options = {fd: err, readable: true, writable: true};
59+
const options = Object.assign({fd: err}, defaultOptions);
5460

5561
// yes, connect is synchronous, so sue me
5662
err = connect(err, name);
5763
if (err < 0) {
5864
close(options.fd);
59-
throw errnoException(err, 'connect');
65+
const sock = new net.Socket(defaultOptions);
66+
setImmediate(() => sock.emit('error', errnoException(err, 'connect')));
67+
return sock;
6068
}
6169

6270
const sock = new net.Socket(options);

0 commit comments

Comments
 (0)