fix(menu): alignment with tabs & virtualedit#2560
Open
Tom94 wants to merge 1 commit into
Open
Conversation
e9f0505 to
516b3c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2558
Temporarily disabling
vim.wo.virtualeditfeels a little bit hacky to me. I'm not sure whether this is an acceptable approach or not -- I'm relatively new to nvim plugin programming.That said, I tried several alternative approaches that were all significantly more complex and brittle when combined with multi-width non-tab characters. This approach here is the only one I could come up with that would reliably work in all situations, including manually triggered completion in virtual regions.