enable typescript strict checks #9
Conversation
sapphi-red
force-pushed
the
refacotr/enable-ts-strict-checks
branch
from
350a403 to
7d22922
Compare
| @@ -12,7 +12,6 @@ export const isSSL = /^https|wss/; | |||
| type Outgoing0 = ProxyTargetDetailed & ServerOptions; | |||
|
|
|||
| export interface Outgoing extends Outgoing0 { | |||
| method?: any; | |||
There was a problem hiding this comment.
This is moved to ServerOptions.
| outgoing.port = | ||
| options[forward || "target"].port ?? | ||
| (isSSL.test(options[forward || "target"].protocol) ? 443 : 80); | ||
| +(target.port ?? (target.protocol !== undefined && isSSL.test(target.protocol) ? 443 : 80)); |
There was a problem hiding this comment.
+ is to convert options[forward || "target"].port (string | number) to number.
| if (isSSL.test(options[forward || "target"].protocol)) { | ||
| if (target.protocol !== undefined && isSSL.test(target.protocol)) { |
There was a problem hiding this comment.
When target.protocol is undefined, it was working like isSSL.test('undefined') and returned false.
| target.protocol !== undefined && | ||
| required(outgoing.port, target.protocol) && |
There was a problem hiding this comment.
When target.protocol is undefined, required(outgoing.port, options[forward || "target"].protocol) throwed an error before this PR.
| // @ts-expect-error FIXME: options.target may be undefined | ||
| const proto = common.isSSL.test(options.target.protocol) ? https : http; |
There was a problem hiding this comment.
This is probably a bug. If options.forward is set and options.target is not set, this line throws an error. I kept the behavior for now.
| it("creates the round robin proxy server", async () => { | ||
| // create one proxy for each backend server | ||
| const proxies = addresses.map((target) => | ||
| httpProxy.createProxyServer({ target }), | ||
| ); | ||
|
|
||
| proxyPort = await getPort(); | ||
| servers.proxy = httpProxy.createProxyServer({}); |
There was a problem hiding this comment.
This line doesn't seem to be needed.
There was a problem hiding this comment.
feel free to remove it in another PR.
| port: "you", | ||
| port: 3000, |
There was a problem hiding this comment.
This change is needed because of #9 (comment)
| @@ -154,7 +155,7 @@ describe("#setupOutgoing", () => { | |||
|
|
|||
| it("should set the agent to false if none is given", () => { | |||
| const outgoing: any = {}; | |||
| setupOutgoing(outgoing, { target: "http://localhost" }, { url: "/" }); | |||
| setupOutgoing(outgoing, { target: new URL("http://localhost") }, { url: "/" }); | |||
There was a problem hiding this comment.
setupOutgoing expects target to be normalized.
|
Thanks!!! Merged and published. |
Added
strict: trueto tsconfig.json and fixed the type errors so that it's easier to maintain.