Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Commutator subgroup of permutation group #39624

Merged
merged 6 commits into from
Mar 9, 2025
Merged

Fix Commutator subgroup of permutation group #39624

merged 6 commits into from
Mar 9, 2025

Conversation

AdityaK1729
Copy link
Contributor

@AdityaK1729 AdityaK1729 commented Mar 3, 2025 •
edited
Loading

Fixes #39416 as mentioned here

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@AdityaK1729 AdityaK1729 mentioned this pull request Mar 3, 2025
Closed
2 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

Documentation preview for this PR (built with commit e0d4916; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@fchapoton
Copy link
Contributor

fchapoton commented Mar 3, 2025 •
edited
Loading

The linter complains :

./sage/groups/perm_gps/permgroup.py:3309:1: W293 blank line contains whitespace
W293 blank line contains whitespace

empty line means really empty

@AdityaK1729
Copy link
Contributor Author

Yeah sure, I have fixed whitespace, also see this comment

@AdityaK1729 AdityaK1729 requested a review from fchapoton March 4, 2025 05:32
@AdityaK1729
Copy link
Contributor Author

@fchapoton do I need to change anything else as well

fchapoton
fchapoton approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, good enough

@AdityaK1729
Copy link
Contributor Author

Thanks :)
Also while we are here can you tell me why is 1 test still failing

@fchapoton
Copy link
Contributor

because we have randomly failing doctests that nobody has the stamina to fix

vbraun pushed a commit to vbraun/sage that referenced this pull request Mar 9, 2025
03cdceb 
sagemathgh-39624: Fix Commutator subgroup of permutation group
    
Fixes sagemath#39416 as mentioned [here](https://github.com/sagemath/sage/issues
/39416#issuecomment-2689882838)

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies
    
URL: sagemath#39624
Reported by: Aditya Khambete
Reviewer(s): Aditya Khambete, Frédéric Chapoton
@vbraun vbraun merged commit 8f05564 into sagemath:develop Mar 9, 2025
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchapoton fchapoton fchapoton approved these changes

Assignees
No one assigned
Labels
c: group theory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Commutator subgroup of permutation group ignores the domain
3 participants
@AdityaK1729 @fchapoton @vbraun